[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||6.0 Latest Commit|https://commits.kde.org/kde |https://invent.kde.org/plas |plasma-addons/84742d8965bdc |ma/kdeplasma-addons/-/commi |c06fb08601cc11707de1b84e488 |t/daef6107bf40b791ab2860d9c ||d2c3fd317d5d3c3 Resolution|--- |FIXED --- Comment #23 from Nate Graham --- Testing this again, it appears to be fixed now in Plasma 6. Tested with black and white note colors with both Breeze Light and Breeze Dark global themes. It looks like I accidentally fixed it with https://invent.kde.org/plasma/kdeplasma-addons/-/commit/daef6107bf40b791ab2860d9cd2c3fd317d5d3c3! -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Bacteria changed: What|Removed |Added CC|dev.bacterios...@aleeas.com | -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Bacteria changed: What|Removed |Added CC||dev.bacterios...@aleeas.com -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 --- Comment #22 from Nate Graham --- There is no override; the issue here is the *lack* of an override. :) Right now the icon colors take into account only Plasma's own color scheme and therefore when using a light theme you get black icons, and when using a dark theme you get white icons. However it doesn't take into account the background color of the note itself. The UI elements of the note would have to be taught about that. The way this works is that the icons' colors are hardcoded into the SVG, but can be re-colored at runtime by code in Plasma that reads some CSS inside the icons. However it only exposes the ability to choose which color set the color comes from; you can't just shim in an arbitrary color. So you can say "give me the text color from the View color set", or from the window color set, or from the header color set, or whatever. But that won't help much in this case because the available color sets don't map to the note's available background colors. An easy fix for this would simply to put a window-colored rectangle under the controls, so they get drawn on top of a background whose color they expect. However this might be considered ugly. And it couldn't help the scrollbar unless you did it for that too, which would be even more like to be ugly. It's a bit of a tricky problem to solve for the icons. For text, it's easier since you can actually force a specific color. So we could simply store a mapping of appropriate colors for each note color and use those for the text. But you can't currently do this for the icons, which is the problem. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 --- Comment #21 from ahmed m. <2m.f...@gmail.com> --- I thought that this was a small bug in the applet code and was hoping to fix it but it seems bigger, something in the theme/color scheme is causing this override. Is it too big of a bug to have as a first contribution? I have no idea where to look as a start for this bug, is it "breeze/kstyle/breezestyle.cpp", something plasma related, no idea! I'm just wondering, where in the KDE world does it render "QQC2.ToolButton" or "QQC2.ScrollView" and decides whether to paint the theme palette or the provided color. I saw something like this in the aforementioned breezestyle.cpp but that seems odd because it means it'd only apply to breeze themes, what about the other 3rd party themes? -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added Version Fixed In|5.17| Priority|NOR |HI -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added CC||luca.pedrie...@gmail.com --- Comment #20 from Nate Graham --- *** Bug 441950 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added CC||kde.podag...@slmail.me --- Comment #19 from Nate Graham --- *** Bug 437101 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added Keywords||usability Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 353819] Certain combination of color schemes/plasma themes and note colors yield poor contrast between note and UI controls (buttons, scrollbar)
https://bugs.kde.org/show_bug.cgi?id=353819 Nate Graham changed: What|Removed |Added Ever confirmed|1 |0 Summary|Yellow notes have barely|Certain combination of |visible icons under Breeze |color schemes/plasma themes |Dark|and note colors yield poor ||contrast between note and ||UI controls (buttons, ||scrollbar) Status|RESOLVED|REPORTED Resolution|DUPLICATE |--- --- Comment #18 from Nate Graham --- Actually, let's just re-open this since Bug 437101 is pretty much the same thing. -- You are receiving this mail because: You are watching all bug changes.
