[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 Marcel changed: What|Removed |Added CC||marcel.is...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601
--- Comment #8 from Kevin Funk ---
@Hideaki: No, thanks. You did a great job.
Unfortunately I believe this has nothing to do with KDevelop. It's a
ksshaskpass bug, no?
Also see: https://bugzilla.redhat.com/show_bug.cgi?id=1043311 ("ksshaskpass
asks for username with password dialog, allowing mistaken pass to become part
of URL").
--
You are receiving this mail because:
You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 Kevin Funk changed: What|Removed |Added Resolution|--- |UPSTREAM Status|UNCONFIRMED |RESOLVED --- Comment #10 from Kevin Funk --- It has nothing to do with us, it's a git feature, invoked when doing e.g. `git push`. Thanks. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 --- Comment #9 from Hideaki Kimura --- Got it. I didn't know how kdevelop invokes ksshaskpass, so I imagined there might be some knob to change that behavior. But, sounds like it provides no control to kdevelop. I will poke the ksshaskpass people then... -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 --- Comment #7 from Hideaki Kimura --- I wonder if you need any more info from me? -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 --- Comment #6 from Hideaki Kimura --- Created attachment 97602 --> https://bugs.kde.org/attachment.cgi?id=97602&action=edit password dialog -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 --- Comment #5 from Hideaki Kimura --- Created attachment 97601 --> https://bugs.kde.org/attachment.cgi?id=97601&action=edit username dialog -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 --- Comment #4 from Hideaki Kimura --- Here's the repro step. 0. If you have a global git config to automate authentication (eg per-host private key file), turn it off. These steps are about cases you need to manually input username/password. Also, I assume you have ksshaskpass. 1. Using git command, newly clone a git repo (either github or gitlab or whatever) *that needs authentication*. For example, just clone a private github reop. 2. Import the project to kdevelop, then git pull from kdevelop. 3. The first dialog asks for username, but it surely looks like asking for a password. Type some character and Enter. 4. The second dialog asks for password. Really identical. Also, it shows the "username" you typed above as part of URL without masking. Also attached screenshots. You will be surprised how identical their looks are. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 Milian Wolff changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #3 from Milian Wolff --- can you show a screenshot please? or tell me how to reproduce this? -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 347601] git username dialog looks like a password dialog
https://bugs.kde.org/show_bug.cgi?id=347601 Hideaki Kimura changed: What|Removed |Added CC||hideaki.kim...@gmail.com --- Comment #2 from Hideaki Kimura --- I'm not the original poster, but I have had the same concern for a while. Let me clarify the issue. When the kdevelop/ksshaskpass doesn't know the git username yet, it shows a ksshaskpass dialog for username first, then another for password. Once we configure the project to remember username, it just shows one for password. The two dialogs look almost identical but ask for totally different things. When the user is expecting just the password dialog, almost certainly s/he would just type her password. This causes three issues. 1. On the screen, she would type her password without masking. Oops. 2. Furthermore, kdevelop remembers the credential! Next time it will show a dialog that asks for password on "http://your_password_here:github.com/bluh/"; without masking. Ops. 3. Finally, there is no easy way to make kdevelop forget this setting. Oops. https://forum.kde.org/viewtopic.php?f=218&t=129031 My suggestion is to show just one dialog in all cases (or zero dialog once the project remembers both username and password). Make it very clear which input box is username, which is password. Also, there should be a way to easily make kdevelop forget the 'username'. -- You are receiving this mail because: You are watching all bug changes.
