[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #13 from Kevin Funk  ---
Git commit 8af21faaa88682dfb844cc2001a5b8c46eeff576 by Kevin Funk.
Committed on 02/03/2016 at 21:25.
Pushed by kfunk into branch '5.0'.

clang: Make use of CXTranslationUnit_KeepGoing

Differential Revision: https://phabricator.kde.org/D1051

M  +5-1languages/clang/duchain/parsesession.cpp
M  +11   -0languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/8af21faaa88682dfb844cc2001a5b8c46eeff576

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

Milian Wolff  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #12 from Milian Wolff  ---
Fixed upstream now, but we need to patch the code to pass
CXTranslationUnit_KeepGoing when available.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #11 from Milian Wolff  ---
Proper fix proposed upstream: http://reviews.llvm.org/D17486, also note that
this definitely corresponds to https://llvm.org/bugs/show_bug.cgi?id=24268

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #9 from Milian Wolff  ---
The tentative was reverted as it introduced crashes such as the one shown in
Bug 359031. We'll have to revise the patch and resubmit it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

Milian Wolff  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #10 from Milian Wolff  ---
Git commit 140e6c8193711bfbc033cfde69144e0c60279528 by Milian Wolff.
Committed on 14/02/2016 at 15:17.
Pushed by mwolff into branch '5.0'.

Cleanup test case and broken comparison resulting in XPASS.

M  +18   -11   languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/140e6c8193711bfbc033cfde69144e0c60279528

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

David Nolden  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kdev |http://commits.kde.org/kdev
   |elop/0b506dcbee4c15d4e0f193 |elop/1dffa94f333098bca2830c
   |08364f50cc19dcdbd2  |9da96367156fc9b505

--- Comment #8 from David Nolden  ---
Git commit 1dffa94f333098bca2830c9da96367156fc9b505 by David Nolden.
Committed on 03/02/2016 at 22:18.
Pushed by zwabel into branch '5.0'.

Workaround clang parsing problems when includes are missing

When an include was missing in a parse run, then the corresponding
include directive is removed from the parse using the unsaved-file
mechanism, and the document is re-parsed. This is repeated
until no more missing includes are found. The corresponding
missing-include problems are shown in the problem-reporter
anyway, so the user can fix it.

M  +2-0languages/clang/clangparsejob.cpp
M  +71   -4languages/clang/duchain/parsesession.cpp
M  +9-0languages/clang/duchain/parsesession.h
M  +11   -0languages/clang/duchain/unsavedfile.cpp
M  +4-0languages/clang/duchain/unsavedfile.h
M  +1-5languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/1dffa94f333098bca2830c9da96367156fc9b505

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #5 from David Nolden  ---
Git commit c9dcbaeedef2ec746214d1be91a09293492e4abb by David Nolden.
Committed on 01/02/2016 at 18:15.
Pushed by zwabel into branch '5.0'.

Add a testcase for BUG: 358853

It seems to break as soon as the second missing
include is encountered.

M  +45   -0languages/clang/tests/test_duchain.cpp
M  +1-0languages/clang/tests/test_duchain.h

http://commits.kde.org/kdevelop/c9dcbaeedef2ec746214d1be91a09293492e4abb

--- Comment #6 from David Nolden  ---
Git commit e90e1864039d8ea3c045d64dc35d117060c950b1 by David Nolden.
Committed on 01/02/2016 at 18:15.
Pushed by zwabel into branch '5.0'.

Always show recursive "missing include" errors in problem view

Extend the missing-include test so that it becomes a recursive
include and also tests this fix. The problem is only actually
visible together with my previous commit to kdevplatform.

M  +3-1languages/clang/duchain/parsesession.cpp
M  +12   -7languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/e90e1864039d8ea3c045d64dc35d117060c950b1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #5 from David Nolden  ---
Git commit c9dcbaeedef2ec746214d1be91a09293492e4abb by David Nolden.
Committed on 01/02/2016 at 18:15.
Pushed by zwabel into branch '5.0'.

Add a testcase for BUG: 358853

It seems to break as soon as the second missing
include is encountered.

M  +45   -0languages/clang/tests/test_duchain.cpp
M  +1-0languages/clang/tests/test_duchain.h

http://commits.kde.org/kdevelop/c9dcbaeedef2ec746214d1be91a09293492e4abb

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #3 from Milian Wolff  ---
Maybe related upstream issue: https://llvm.org/bugs/show_bug.cgi?id=24268

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #4 from David Nolden  ---
Git commit a1d6a13183c01b9ea2c45e470e81f9ec53df7ada by David Nolden.
Committed on 01/02/2016 at 18:11.
Pushed by zwabel into branch 'master'.

Always show recursive "missing include" errors in problem view

Extend the missing-include test so that it becomes a recursive
include and also tests this fix. The problem is only actually
visible together with my previous commit to kdevplatform.

M  +3-1languages/clang/duchain/parsesession.cpp
M  +12   -7languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/a1d6a13183c01b9ea2c45e470e81f9ec53df7ada

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

David Nolden  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kdev
   ||elop/0b506dcbee4c15d4e0f193
   ||08364f50cc19dcdbd2

--- Comment #7 from David Nolden  ---
Git commit 0b506dcbee4c15d4e0f19308364f50cc19dcdbd2 by David Nolden.
Committed on 01/02/2016 at 22:13.
Pushed by zwabel into branch 'master'.

Workaround clang parsing problems when includes are missing

When an include was missing in a parse run, then the corresponding
include directive is removed from the parse using the unsaved-file
mechanism, and the document is re-parsed. This is repeated
until no more missing includes are found. The corresponding
missing-include problems are shown in the problem-reporter
anyway, so the user can fix it.

M  +2-0languages/clang/clangparsejob.cpp
M  +71   -4languages/clang/duchain/parsesession.cpp
M  +9-0languages/clang/duchain/parsesession.h
M  +11   -0languages/clang/duchain/unsavedfile.cpp
M  +4-0languages/clang/duchain/unsavedfile.h
M  +1-5languages/clang/tests/test_duchain.cpp

http://commits.kde.org/kdevelop/0b506dcbee4c15d4e0f19308364f50cc19dcdbd2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[David Nolden via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

--- Comment #2 from David Nolden  ---
Git commit 7bdc9e8d9539c6e904edbd021d0cc359cdc8e843 by David Nolden.
Committed on 01/02/2016 at 15:53.
Pushed by zwabel into branch 'master'.

Add a testcase for BUG: 358853

It seems to break as soon as the second missing
include is encountered.

M  +45   -0languages/clang/tests/test_duchain.cpp
M  +1-0languages/clang/tests/test_duchain.h

http://commits.kde.org/kdevelop/7bdc9e8d9539c6e904edbd021d0cc359cdc8e843

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 358853] include not found in a header causes random parsing/highlighting/code completion glitches

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358853

Milian Wolff  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
   Target Milestone|--- |5.0.0
   Keywords||release_blocker
 Ever confirmed|0   |1
   Priority|NOR |VHI

--- Comment #1 from Milian Wolff  ---
Agreed, on all parts. Esp. considering that we already offer a simple
workaround for such problems (i.e. add manual include path), we should just
show this to the user when we spot such an error anywhere in the include chain.

-- 
You are receiving this mail because:
You are watching all bug changes.