[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Igor Kushnir]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #11 from Igor Kushnir  ---
(In reply to JATothrim from comment #10)
> I scratched my itch with this bug. I want it *gone*. :-)
Welcome to KDevelop development :)
> I checkout master branch at 4c984656ade6e602dbd8ac4c7e4bbf440aad7173 commit.
> My first question is: is this the correct branch for bug fix development?
Yes, unless the bug fix is simple and safe enough to be included in the stable
branch, which the fix to this bug is unlikely to end up.
> void MarkInterface::marksChanged(KTextEditor::Document *document);
> 
> This is the *only* signal activated when the editor updates the mark(s) in
> the document.
> 
> This is implemented in ktexteditor/src/document/katedocument.h by the
> KTextEditor::DocumentPrivate.
> 
> I have now noticed that this API looks to be internal to ktexteditor?
> It's unfortunate if this can't be used because I actually managed to
> write a crude bug-fix patch using it.
MarkInterface is part of public KTextEditor API:
https://api.kde.org/frameworks/ktexteditor/html/classKTextEditor_1_1MarkInterface.html
> The linked patches are *not* the real fix.
> I provided them here only so that I could get in contact with the developers.
You can create a Draft merge request at
https://invent.kde.org/kdevelop/kdevelop.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[JATothrim]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #10 from JATothrim  ---
I scratched my itch with this bug. I want it *gone*. :-)
I built the kdevelop in the LXC container last week:
I used the kdesrc-build tool to build and checkout the sources.

I checkout master branch at 4c984656ade6e602dbd8ac4c7e4bbf440aad7173 commit.
My first question is: is this the correct branch for bug fix development?

The initial thing I did was run kdevelop under GDB:
This allowed me to dissect what was happening.

After browsing and running the code enough, I found a suitable event for
updating the BreakpointModel on the Kdevelop side:

void MarkInterface::marksChanged(KTextEditor::Document *document);

This is the *only* signal activated when the editor updates the mark(s) in the
document.

This is implemented in ktexteditor/src/document/katedocument.h by the
KTextEditor::DocumentPrivate.

I have now noticed that this API looks to be internal to ktexteditor?
It's unfortunate if this can't be used because I actually managed to
write a crude bug-fix patch using it.

The linked patches are *not* the real fix.
I provided them here only so that I could get in contact with the developers.

And yes, the BreakpointModel code looks... bit iffy even to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[JATothrim]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #9 from JATothrim  ---
Created attachment 161752
  --> https://bugs.kde.org/attachment.cgi?id=161752=edit
patch 2/2

The RFC bug fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[JATothrim]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #8 from JATothrim  ---
Created attachment 161751
  --> https://bugs.kde.org/attachment.cgi?id=161751=edit
patch 1/2

Wire an new event handler in BreakpointModel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Axel Kellermann]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #7 from Axel Kellermann  ---
See my comment in the MR mentioned above:
https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/147#note_89877

BreakpointModel already contains all the logic needed to resolve the issue.
What's missing is an appropriate event to react on. And as remarked by Igor, it
would probably also be a good idea to refactor the code in BreakpointModel a
bit to prevent a potential negative impact on performance.

Maybe one of the more senior KDE/KDevelop devs could have a look at my comment
in the MR and assess if my statement makes sense and how it could be
implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[JATothrim]

https://bugs.kde.org/show_bug.cgi?id=363237

--- Comment #6 from JATothrim  ---
(In reply to Sven Brauch from comment #2)
> Hmm, can't reproduce the crash but yes, the display is definitely buggy, we
> need to look into that.
> 
> But, how did you lose data? Crash recovery should easily be able to restore
> all changes to the file in this case ...

This is such an old issue, I don't remember anymore. :-/
Recent kdevelop versions: 5.11.230403 (23.04.3) have not crashed anymore for
long time by fiddling with the break points.

(In reply to Axel Kellermann from comment #5)
> (In reply to Igor Kushnir from comment #4)
> > (In reply to Piotr Mierzwinski from comment #3)
> > > Fixed in Bug 424431
> > Are you sure this bug is really fixed already? Even with the fix for Bug
> > 424431, Breakpoints view only synchronizes when the document is saved. See
> > https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/147#note_89877
> This issue is definitely not resolved. Reopening it.

I was supprised this issue is *still* open and that I had an comment here. :-)
I have bug-fix/feature request how to solve this:

The Core problem persist as of 5.11.230403 (23.04.3): break points are not kept
up to date with editing the source.
All break points are updated in document when user adds/toggles/removes them.
Current behavior of kdevelop is to keep the break point on the exact line
number it was set on, even if that source line doesn't exists anymore since the
break points were last updated.

This very annoying when you add/remove source lines from source file before any
enabled break points. But it is better than nothing.

My suggestion how to solve this:
When break point is set kdevelop should to record the source line *hash* it was
set on.
When that source line moves, kdevelop can attempt to update the break point
line number
based on this break point context (the source line hash)
If the break point context doesn't match anything in the file it was enabled in
kdevelop should *disable* it, as the code user enabled it on is unlikely to
exists anymore.

When recording new break point context it might be good idea to
ignore white-space parts of the source line:
This would allow slightly editing the source line and the hash would still
match the source line.

As last note adding an "Refresh break points" command to the IDE would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Axel Kellermann]

https://bugs.kde.org/show_bug.cgi?id=363237

Axel Kellermann  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 CC||axel.kellerm...@gmx.de

--- Comment #5 from Axel Kellermann  ---
(In reply to Igor Kushnir from comment #4)
> (In reply to Piotr Mierzwinski from comment #3)
> > Fixed in Bug 424431
> Are you sure this bug is really fixed already? Even with the fix for Bug
> 424431, Breakpoints view only synchronizes when the document is saved. See
> https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/147#note_89877
This issue is definitely not resolved. Reopening it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Igor Kushnir]

https://bugs.kde.org/show_bug.cgi?id=363237

Igor Kushnir  changed:

   What|Removed |Added

 CC||igor...@gmail.com

--- Comment #4 from Igor Kushnir  ---
(In reply to Piotr Mierzwinski from comment #3)
> Fixed in Bug 424431
Are you sure this bug is really fixed already? Even with the fix for Bug
424431, Breakpoints view only synchronizes when the document is saved. See
https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/147#note_89877

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Piotr Mierzwinski]

https://bugs.kde.org/show_bug.cgi?id=363237

Piotr Mierzwinski  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Piotr Mierzwinski  ---
Fixed in Bug 424431

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Alexander Potashev]

https://bugs.kde.org/show_bug.cgi?id=363237

Alexander Potashev  changed:

   What|Removed |Added

 CC||aspotas...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Sven Brauch]

https://bugs.kde.org/show_bug.cgi?id=363237

Sven Brauch  changed:

   What|Removed |Added

 CC||m...@svenbrauch.de
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Sven Brauch  ---
Hmm, can't reproduce the crash but yes, the display is definitely buggy, we
need to look into that.

But, how did you lose data? Crash recovery should easily be able to restore all
changes to the file in this case ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[JATothrim]

https://bugs.kde.org/show_bug.cgi?id=363237

JATothrim  changed:

   What|Removed |Added

 CC||jarmo.tii...@gmail.com

--- Comment #1 from JATothrim  ---
I'm seeing exactly same behaviour. I also had kdevelop crashing instantly on me
by adding lines above the break points and then trying to remove/change/add the
breakpoints then. Bigger the project was the sooner kdevelop may crash. Usually
no crash happens except that break points go invalid and I manage to 'fix' the
break points by removing them and adding them back.

I think this bug is rather severe as I have lost data because of it.

I have Kdevelop 5.0.3, KDE Frameworks 5.30.0, Qt 5.7.1.

Please fix this issue on next release. I don't like instantly segfaulting
sofware.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 363237] Breakpoints (Breakpoints View) are not updated after removing/adding couple lines of code

[Piotr Mierzwinski via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363237

Piotr Mierzwinski  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.