[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Piotr Mierzwinski]

https://bugs.kde.org/show_bug.cgi?id=365420

Piotr Mierzwinski  changed:

   What|Removed |Added

Version|5.1.1   |5.3.1
 Ever confirmed|0   |1
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #6 from Piotr Mierzwinski  ---
Either I found new case when constructor is broken by inserting void on its
begin or this is just regression.
Initial code looks like below:

Header file (myclass.h):
public:
MyClass();

cpp file (myclass.cpp):
MyClass::MyClass()
{
// some code
}

Steps to reproduce:
1. instead of "// some code" in definition of constructor put code like below:

   if (bParam)
  ;

2. copy to clipboard string like: "bool bParam"
3. paste copied string as parameter for constructor in cpp file. 
   After that definition will look like this:

   MyClass::MyClass( bool bParam )

4. Click on end above line, KDevelop will show two solutions, suggesting how to
fix the code
5. Click into the first one and after click into the second one
6. Switch to header file

CURRENT RESULT:
public:
void MyClass( bool bParam );

EXPECTED RESULT:
public:
MyClass( bool bParam );

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=365420

--- Comment #5 from Kevin Funk  ---
*** Bug 375277 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=365420

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||5.2.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=365420

Kevin Funk  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
   |velop/e334d754bf510bdf21368 |velop/3f99e3deefbe3b77ba023
   |858d8494adf3622fb16 |bf09b69d8da3ca815fc

--- Comment #4 from Kevin Funk  ---
Git commit 3f99e3deefbe3b77ba023bf09b69d8da3ca815fc by Kevin Funk, on behalf of
Shashwat Dixit.
Committed on 15/03/2018 at 18:39.
Pushed by kfunk into branch '5.2'.

Do not add return type to constructors declaration when editing definition in
signature assistant.

Reviewers: kfunk, mwolff, #kdevelop, brauch

Reviewed By: mwolff, #kdevelop, brauch

Subscribers: brauch, apol, #kdevelop, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D11291

(cherry picked from commit e334d754bf510bdf21368858d8494adf3622fb16)

M  +1-1plugins/clang/codegen/adaptsignatureassistant.cpp
M  +8-0plugins/clang/tests/test_assistants.cpp

https://commits.kde.org/kdevelop/3f99e3deefbe3b77ba023bf09b69d8da3ca815fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Milian Wolff]

https://bugs.kde.org/show_bug.cgi?id=365420

Milian Wolff  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kde
   ||velop/e334d754bf510bdf21368
   ||858d8494adf3622fb16

--- Comment #3 from Milian Wolff  ---
Git commit e334d754bf510bdf21368858d8494adf3622fb16 by Milian Wolff, on behalf
of Shashwat Dixit.
Committed on 15/03/2018 at 10:40.
Pushed by mwolff into branch 'master'.

Do not add return type to constructors declaration when editing definition in
signature assistant.

Reviewers: kfunk, mwolff, #kdevelop, brauch

Reviewed By: mwolff, #kdevelop, brauch

Subscribers: brauch, apol, #kdevelop, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D11291

M  +1-1plugins/clang/codegen/adaptsignatureassistant.cpp
M  +8-0plugins/clang/tests/test_assistants.cpp

https://commits.kde.org/kdevelop/e334d754bf510bdf21368858d8494adf3622fb16

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 365420] Usage of "Adapt signature" to rename argument in constructor inserts keyword "void" in its declaration

[Piotr Mierzwinski]

https://bugs.kde.org/show_bug.cgi?id=365420

Piotr Mierzwinski  changed:

   What|Removed |Added

Summary|Use of "Adapt signature" to |Usage of "Adapt signature"
   |rename argument in  |to rename argument in
   |constructor inserts keyword |constructor inserts keyword
   |"void" in its declaration   |"void" in its declaration

-- 
You are receiving this mail because:
You are watching all bug changes.