[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-21 Thread Kevin Funk via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||5.1.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-21 Thread RJVB via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

RJVB  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/kdev
   ||platform/3c559df38551ba0a06
   ||54e944ea2b68dd4b85a15d

--- Comment #2 from RJVB  ---
Git commit 3c559df38551ba0a0654e944ea2b68dd4b85a15d by René J.V. Bertin.
Committed on 21/10/2016 at 14:51.
Pushed by rjvbb into branch 'master'.

add an IDocumentController::DocumentActivation flag to control adding
documents to the "Files/Open Recent" menu and use it in the patchreview
plugin to prevent pollution of said menu.
DocumentController::activateDocument() no longer adds the target document
to the Open Recent menu; use DocumentController::openDocument() for that.
Additionally, the patch review plugin now handles the hardwired maximum
number of files to open (15) correctly, instead of opening no files when
that maximum is exceeded.

REVIEW: 129231

M  +2-1interfaces/idocumentcontroller.h
M  +21   -19   plugins/patchreview/patchreview.cpp
M  +7-2plugins/patchreview/patchreviewtoolview.cpp
M  +2-2shell/documentcontroller.cpp
M  +2-0shell/documentcontroller.h

http://commits.kde.org/kdevplatform/3c559df38551ba0a0654e944ea2b68dd4b85a15d

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-20 Thread Simon Andric via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-20 Thread RJVB via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

RJVB  changed:

   What|Removed |Added

URL||https://git.reviewboard.kde
   ||.org/r/129231/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-20 Thread RJVB via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

RJVB  changed:

   What|Removed |Added

   Severity|wishlist|normal

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 371210] patch review shouldn't add files it opens to the recent files menu

2016-10-19 Thread RJVB via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=371210

--- Comment #1 from RJVB  ---
Created attachment 101650
  --> https://bugs.kde.org/attachment.cgi?id=101650=edit
patch review temporary patchfiles in the recent files menu

The large number of changed files that overwrote my recent files menu contents
hid another thing that I think is a real and recent regression: the presence of
the patch files themselves in the recent files menu.

-- 
You are receiving this mail because:
You are watching all bug changes.