[kdiagram] [Bug 383160] Crash on showing investment price chart

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=383160

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #10 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=383160

--- Comment #9 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=383160

Justin Zobel  changed:

   What|Removed |Added

 Status|REOPENED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Justin Zobel  ---
Thank you for the crash report.

As it has been a while since this was reported, can you please test and confirm
if this issue is still occurring or if this bug report can be marked as
resolved.

I have set the bug status to "needsinfo" pending your response, please change
back to "reported" or "resolved/worksforme" when you respond, thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Dag Andersen]

https://bugs.kde.org/show_bug.cgi?id=383160

--- Comment #7 from Dag Andersen  ---
(In reply to Ralf Habacker from comment #6)
> (In reply to Ralf Habacker from comment #5)
> > -   position.row >=0 && position.row < m_data[ 0 ].size();
> > -> this checks if the requested row is in column 0, which may be wrong if 
> On the crash I had 
> 
> m_data[0].size was 367
> m_data[1].size was 110
> position.column was 1
> position.row was 110
If I understand item models correctly, this should be impossible as all rows
with the same parent must have the same column count, so you should get the
same number of rows for all columns.
> 
> The original codes checkes that position.row < m_data[ 0 ].size() which
> returns true (where it should return false) but fails later on access to
> m_data[1][110] with an out of index exception.
There are many places in the code it is assumed that all column have the same
tow count.

I'm afraid this will just hide a problem eslewhere.
I have tested master branch with the attached file but cannot trigger a crash.
More info will be appricated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Friedrich W . H . Kossebau]

https://bugs.kde.org/show_bug.cgi?id=383160

Friedrich W. H. Kossebau  changed:

   What|Removed |Added

   Assignee|kosse...@kde.org|dand...@get2net.dk

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383160

--- Comment #6 from Ralf Habacker  ---
(In reply to Ralf Habacker from comment #5)
> -   position.row >=0 && position.row < m_data[ 0 ].size();
> -> this checks if the requested row is in column 0, which may be wrong if 
On the crash I had 

m_data[0].size was 367
m_data[1].size was 110
position.column was 1
position.row was 110

The original codes checkes that position.row < m_data[ 0 ].size() which returns
true (where it should return false) but fails later on access to m_data[1][110]
with an out of index exception.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383160

--- Comment #5 from Ralf Habacker  ---
(In reply to NSLW from comment #4)
> (In reply to Thomas Baumgart from comment #3)
it
> doesn't crash for me on master branch of KMM. Thomas, can you confirm Ralf's
> crash?
If it does not crash it does not mean that there is no bug. See the
implementation of CartesianDiagramDataCompressor::mapsToModelIndex

My observations shows that m_data is constructed as following:

m_data
  [0]  column 0
 [0]  row 0 of column 0
 [1]  row 1 of column 0
 [m]  row m of column 0
  [1]  column 1
 [0]  row 0 of column 1
 [1]  row 1 of column 1
 [p]  row p of column 1
  [n]  column n
 [0]  row 0 of column n
 [1]  row 1 of column n
 [q]  row q of column n

 return m_model && m_data.size() > 0 && m_data[ 0 ].size() > 0 &&
position.column >= 0 && 

position.column < m_data.size() &&
-> this checks if the requested column is in m_data

-   position.row >=0 && position.row < m_data[ 0 ].size();
-> this checks if the requested row is in column 0, which may be wrong if 

+   position.row >=0 && position.row < m_data[ position.column
].size();
instead the requested row needs to be checked against m_data[position.column]

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[NSLW]

https://bugs.kde.org/show_bug.cgi?id=383160

NSLW  changed:

   What|Removed |Added

 CC||lukasz.wojnilow...@gmail.co
   ||m

--- Comment #4 from NSLW  ---
(In reply to Thomas Baumgart from comment #3)
> Reopened and moved to KDiagram and assigned to maintainer for upstream
> handling

I'm afraid that KChart developers' time may be wasted here, because, it doesn't
crash for me on master branch of KMM. Thomas, can you confirm Ralf's crash?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383160

Thomas Baumgart  changed:

   What|Removed |Added

Product|kmymoney4   |kdiagram
  Component|general |KChart
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 CC||kmymoney-de...@kde.org
   Assignee|kmymoney-de...@kde.org  |kosse...@kde.org

--- Comment #3 from Thomas Baumgart  ---
Reopened and moved to KDiagram and assigned to maintainer for upstream handling

-- 
You are receiving this mail because:
You are watching all bug changes.