[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 Bug 410008 depends on bug 404477, which changed state. Bug 404477 Summary: Binary file causes Desktop freeze https://bugs.kde.org/show_bug.cgi?id=404477 What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 Bug 410008 depends on bug 404477, which changed state. Bug 404477 Summary: Binary file causes Desktop freeze https://bugs.kde.org/show_bug.cgi?id=404477 What|Removed |Added Status|CONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 michael changed: What|Removed |Added Depends on||404477 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=404477 [Bug 404477] Binary file causes Desktop freeze -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 michael changed: What|Removed |Added Depends on||411885 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=411885 [Bug 411885] Out of memory error from kdiff3 on small binary files -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 michael changed: What|Removed |Added Status|ASSIGNED|CONFIRMED --- Comment #3 from michael --- The first case now fixed as this was an unintended regression. I am not going to say that the second case will not be coming back. However I have concerns over how kdiff3's current comparison code behaves in this case. Anything beyond basic binary equality testing seems to assume its working with a text file of some kind. As a result binary data can trigger odd corner cases that text files don't hit. To avoid this kdiff3 currently does not run such code for binary files. I'll have to look into this further to see just what would be needed for binary comparison to come back. -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 --- Comment #1 from michael --- Git commit 2c8c09e06ff97ff171181674507590e28c8fd618 by Michael Reeves. Committed on 26/07/2019 at 22:00. Pushed by mreeves into branch 'master'. Fix text file diff not shown on comparison to empty/missing file. M +2-2src/SourceData.cpp M +1-1src/SourceData.h https://invent.kde.org/kde/kdiff3/commit/2c8c09e06ff97ff171181674507590e28c8fd618 -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 --- Comment #1 from michael --- Git commit 2c8c09e06ff97ff171181674507590e28c8fd618 by Michael Reeves. Committed on 26/07/2019 at 22:00. Pushed by mreeves into branch 'master'. Fix text file diff not shown on comparison to empty/missing file. M +2-2src/SourceData.cpp M +1-1src/SourceData.h https://invent.kde.org/kde/kdiff3/commit/2c8c09e06ff97ff171181674507590e28c8fd618 --- Comment #2 from michael --- Git commit b1b4cb830c4a8f5b01b8ca018a17edf4de162ca7 by Michael Reeves. Committed on 26/07/2019 at 21:56. Pushed by mreeves into branch '1.8'. Fix text file diff not shown on comparison to empty/missing file. M +2-2src/SourceData.cpp M +1-1src/SourceData.h https://invent.kde.org/kde/kdiff3/commit/b1b4cb830c4a8f5b01b8ca018a17edf4de162ca7 -- You are receiving this mail because: You are watching all bug changes.
[kdiff3] [Bug 410008] Kdiff3 inadequately shows line diff for files
https://bugs.kde.org/show_bug.cgi?id=410008 michael changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
