[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2018-02-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||alois.stei...@tuwien.ac.at

--- Comment #17 from Nate Graham  ---
*** Bug 390551 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2018-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||franc...@duretz.net

--- Comment #16 from Nate Graham  ---
*** Bug 388791 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-12-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||macca...@hotmail.com

--- Comment #15 from Nate Graham  ---
*** Bug 387485 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-11-06 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=385708

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-11-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #14 from madc...@atlas.cz ---
Small update, Samba 4.7.1 does not fix the problem
(https://www.samba.org/samba/history/samba-4.7.1.html) and per my testing the
current workaround is still working.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-11-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kio |https://commits.kde.org/kio
   |-extras/a36b797913a844dbb26 |-extras/5ddb81c5ec7d8907ca4
   |d5dc1542b3ce304f5f445   |a8be20499fa40e75be861

--- Comment #13 from Nate Graham  ---
Git commit 5ddb81c5ec7d8907ca4a8be20499fa40e75be861 by Nathaniel Graham, on
behalf of Michal Malý.
Committed on 05/11/2017 at 02:51.
Pushed by ngraham into branch 'Applications/17.08'.

Workaround incorrectly returned EEXIST instead of EPERM regression introduced
by libsmbclient 4.7

Summary:
There appears to be an issue with libsmbclient 4.7 that returns nonsensical
EEXIST error code when a user has not authenticated themselves to access
password-protected shares. This patch attempts to work around the issue by
treating EEXIST as another case of "invalid login credentials". The workaround
tries to detect broken versions of libsmbclient and enables itself only when
such a version is found.

See https://bugzilla.samba.org/show_bug.cgi?id=13050 for upstream bug report.

Reviewers: ngraham, davidedmundson, elvisangelaccio, #frameworks

Reviewed By: ngraham, davidedmundson

Subscribers: cfeck, rdieter, graesslin, z3ntu

Differential Revision: https://phabricator.kde.org/D8387

M  +29   -1smb/kio_smb.cpp
M  +3-0smb/kio_smb.h
M  +6-1smb/kio_smb_browse.cpp

https://commits.kde.org/kio-extras/5ddb81c5ec7d8907ca4a8be20499fa40e75be861

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kio
   ||-extras/a36b797913a844dbb26
   ||d5dc1542b3ce304f5f445

--- Comment #12 from Nate Graham  ---
Git commit a36b797913a844dbb26d5dc1542b3ce304f5f445 by Nathaniel Graham, on
behalf of Michal Malý.
Committed on 01/11/2017 at 00:21.
Pushed by ngraham into branch 'master'.

Workaround incorrectly returned EEXIST instead of EPERM regression introduced
by libsmbclient 4.7

Summary:
There appears to be an issue with libsmbclient 4.7 that returns nonsensical
EEXIST error code when a user has not authenticated themselves to access
password-protected shares. This patch attempts to work around the issue by
treating EEXIST as another case of "invalid login credentials". The workaround
tries to detect broken versions of libsmbclient and enables itself only when
such a version is found.

See https://bugzilla.samba.org/show_bug.cgi?id=13050 for upstream bug report.

Reviewers: ngraham, davidedmundson, elvisangelaccio, #frameworks

Reviewed By: ngraham, davidedmundson

Subscribers: cfeck, rdieter, graesslin, z3ntu

Differential Revision: https://phabricator.kde.org/D8387

M  +29   -1smb/kio_smb.cpp
M  +3-0smb/kio_smb.h
M  +6-1smb/kio_smb_browse.cpp

https://commits.kde.org/kio-extras/a36b797913a844dbb26d5dc1542b3ce304f5f445

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-31 Thread Bruno Friedmann
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #11 from Bruno Friedmann  ---
(In reply to Bruno Friedmann from comment #10)
> Also seen on openSUSE Tumbleweed as samba 4.7.0 has been incorporated

Reported on openSUSE as https://bugzilla.opensuse.org/show_bug.cgi?id=1065868
Hope some samba people from there can help

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-31 Thread Bruno Friedmann
https://bugs.kde.org/show_bug.cgi?id=385708

Bruno Friedmann  changed:

   What|Removed |Added

 CC||br...@ioda-net.ch

--- Comment #10 from Bruno Friedmann  ---
Also seen on openSUSE Tumbleweed as samba 4.7.0 has been incorporated

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-24 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=385708

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #9 from Nate Graham  ---
Any idea how we can get the Samba folks' attention? Clearly a bug report alone
isn't sufficient. Do they have a mailing list or a developer forum or
something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #8 from madc...@atlas.cz ---
I was hoping that either the Samba guys will respond to the bug report or there
will be others hitting the same problem before submitting this workaround as an
actual patch. Since the latter has happened, the patch is now up:
https://phabricator.kde.org/D8387

Can anyone think of a way how to restrict this behavior to the broken
version(s) of libsmbclient? There doesn't seem to be a way how to ask
libsmbclient for any version information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Luca Weiss
https://bugs.kde.org/show_bug.cgi?id=385708

Luca Weiss  changed:

   What|Removed |Added

 CC||l...@z3ntu.xyz

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #7 from Nate Graham  ---
Looks like this is pretty widespread for users of rolling release distros who
got samba 4.7.0. I don't see any movement on the upstream bug report in a month
(boo), so my vote is for accepting this patch, once it's on phabricator.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||jask...@gmail.com

--- Comment #6 from Nate Graham  ---
*** Bug 384201 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||bronsonmath...@gmail.com

--- Comment #5 from Nate Graham  ---
*** Bug 385483 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||unnamedp...@protonmail.com

--- Comment #4 from Nate Graham  ---
*** Bug 385999 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #3 from Nate Graham  ---
Any chance you can submit the patch on https://phabricator.kde.org/? Even if
it's not ideal, it may be better than nothing, and you may get some good
suggestions for improvement there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugzilla.samba.org/
   ||show_bug.cgi?id=13050

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=385708

--- Comment #2 from madc...@atlas.cz ---
Non-existing files are not really a problem as you should get an ENOENT. There
is something oddly wrong with libsmbclient, for instance, entering a
nonexistent URL such as smb://MY_SERVER/nonsense (nonsense being a name of a
share here) also seems to return EEXIST. With the workaround in place I get
incorrectly asked for login creds, without the workaround I just get an
"Internal error: File exists" warning. A URL like this -
smb://MY_SERVER/good_share/nonsense - however returns ENOENT and I get the
correct warning in Dolphin.

The workaround at least lets me enter the login credentials when the server
needs them although it is pretty far from an actual solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385708

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 385708] kio-smb reports internal error instead of asking for login credentials with libsmbclient 4.7

2017-10-13 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=385708

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
With your workaround does it still behave Ok when you visit a URL that really
doesn't exist?

-- 
You are receiving this mail because:
You are watching all bug changes.