[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Harald Sitter changed: What|Removed |Added Latest Commit||https://commits.kde.org/kio ||-extras/ec40cd6ef3f497637f4 ||e7e31e3dc60c221e25f5c Status|ASSIGNED|RESOLVED Version Fixed In||20.04.0 Resolution|--- |FIXED --- Comment #4 from Harald Sitter --- Git commit ec40cd6ef3f497637f4e7e31e3dc60c221e25f5c by Harald Sitter. Committed on 16/03/2020 at 12:25. Pushed by sitter into branch 'master'. add readdirplus2 support for samba>=4.12 Summary: unlike the dirent itering we do not need a separate stat call with this new api by instead itering on what are effectively stat-like objects. this simply runs before the regular itering which we still use to list shares and workgroups. browse_stat_path has been split into stat and udsentry-construction-from-stat so it can be used across both code paths. fun fact on the side: if there actually was a stat() api that returned libsmb_file_info, we could use that as well and forget about the stats structs in general :S FIXED-IN: 20.04.0 Test Plan: - build samba 4.12 rc - list server - list share - list dir in share - on 4.7 - all of the above Reviewers: ngraham, asn Reviewed By: ngraham Subscribers: kde-frameworks-devel, kfm-devel Tags: #dolphin, #frameworks Differential Revision: https://phabricator.kde.org/D27520 # Conflicts: # smb/CMakeLists.txt # smb/kio_smb.h # smb/kio_smb_browse.cpp M +7-0smb/CMakeLists.txt M +1-0smb/config-smb.h.cmake M +1-1smb/kio_smb.h M +82 -53 smb/kio_smb_browse.cpp https://commits.kde.org/kio-extras/ec40cd6ef3f497637f4e7e31e3dc60c221e25f5c -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Harald Sitter changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Assignee|plasma-b...@kde.org |sit...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 --- Comment #3 from Andreas Schneider --- Yes, this is only for listing directory contents. In the meantime we have smbc_readdirplus2() which addresses some bugs created with smbc_readdirplus(). -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Harald Sitter changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Harald Sitter --- That only applies to directory listing, right? To list shares and printers and whatnot we'd still need the smbc_dirents from smbc_readdir. Also this documentation seems a bit lackluster ``` /** * DOS attributes of file */ uint16_t attrs; ``` are they mode bits like SMBC_DOS_MODE_HIDDEN? -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Andreas Schneider changed: What|Removed |Added CC||mikhail...@dumalogiya.ru -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 --- Comment #1 from Andreas Schneider --- We need to implement smbc_readdirplus2() as we fscked up the API :-( -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Christoph Feck changed: What|Removed |Added Severity|normal |task -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 402988] SMBSlave::listDir() should use smbc_readdirplus() if available
https://bugs.kde.org/show_bug.cgi?id=402988 Andreas Schneider changed: What|Removed |Added CC||a...@cryptomilk.org, ||sit...@kde.org -- You are receiving this mail because: You are watching all bug changes.
