[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Stefan Brüns changed: What|Removed |Added Latest Commit||https://invent.kde.org/netw ||ork/kio-extras/commit/015a2 ||65d32bc216d198410f11d63cbf8 ||4245c124 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #11 from Stefan Brüns --- Git commit 015a265d32bc216d198410f11d63cbf84245c124 by Stefan Brüns. Committed on 22/09/2020 at 13:49. Pushed by bruns into branch 'master'. [DjvuThumbnailer] Replace open coded ddjvu invocation with QProcess This also fixes a kdeinit crash due to calling exit(1) in case execvp failed (e.g. due to a missing ddjvu binary). M +5-0thumbnail/CMakeLists.txt M +29 -107 thumbnail/djvucreator.cpp M +5-20 thumbnail/djvucreator.h https://invent.kde.org/network/kio-extras/commit/015a265d32bc216d198410f11d63cbf84245c124 -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #10 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/kio-extras/-/merge_requests/30 -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #9 from Norbert Preining --- Ok, I sent a merge request for this code. When it is merged, this bug can be closed, but for now it is still valid. -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #8 from Martin Mirchev --- Okay, that is nice. Well all is good, I assume you can close the issue. Hope I helped On 9/16/20 9:25 AM, Norbert Preining wrote: > https://bugs.kde.org/show_bug.cgi?id=420074 > > --- Comment #7 from Norbert Preining --- > (In reply to Martin Mirchev from comment #6) >> Sorry, making it a dependency would be a best option but I do not really >> know how many people use Djvu these days so it may come as extra bloat >> for some people. > Well, the correct solution is to use > _exit(1); > instead of >exit(1); > because the normal exit(1) triggers the atexit registered functions to be > executed, and that is not what we want (and crashed kdeinit5). > > I can confirm that with _exit(1) instead all works as expected - just that > there are no thumbnails available, well, also this is expected. > -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #7 from Norbert Preining --- (In reply to Martin Mirchev from comment #6) > Sorry, making it a dependency would be a best option but I do not really > know how many people use Djvu these days so it may come as extra bloat > for some people. Well, the correct solution is to use _exit(1); instead of exit(1); because the normal exit(1) triggers the atexit registered functions to be executed, and that is not what we want (and crashed kdeinit5). I can confirm that with _exit(1) instead all works as expected - just that there are no thumbnails available, well, also this is expected. -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #6 from Martin Mirchev --- Sorry, making it a dependency would be a best option but I do not really know how many people use Djvu these days so it may come as extra bloat for some people. On 9/16/20 8:32 AM, Norbert Preining wrote: > https://bugs.kde.org/show_bug.cgi?id=420074 > > --- Comment #5 from Norbert Preining --- > (In reply to Martin Mirchev from comment #4) >> Okay, so this means it can be added as general info for the tooltip right? > Not sure what you mean with "tooltip", I see two options: > > - either make ddjvu binary a hard dependency via CMakeFile > - fix the code that it does not crash (not call exit) if ddjvu is not > available > > Both are possible solutions, but the current state is sub-optimal. > -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #5 from Norbert Preining --- (In reply to Martin Mirchev from comment #4) > Okay, so this means it can be added as general info for the tooltip right? Not sure what you mean with "tooltip", I see two options: - either make ddjvu binary a hard dependency via CMakeFile - fix the code that it does not crash (not call exit) if ddjvu is not available Both are possible solutions, but the current state is sub-optimal. -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 --- Comment #4 from Martin Mirchev --- Okay, so this means it can be added as general info for the tooltip right? On Tue, Sep 15, 2020, 18:00 Norbert Preining wrote: > https://bugs.kde.org/show_bug.cgi?id=420074 > > Norbert Preining changed: > >What|Removed |Added > > > CC||norb...@preining.info > > --- Comment #3 from Norbert Preining --- > I just realized that this is simply because `ddjvu` the program is not > available. This means that in the pid==0 case the execvp fails and drops > down > to the exit(1). > > On my system, where I had the same problem, a simple installation of > djvulibre-bin package fixed the crashes. > > -- > You are receiving this mail because: > You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Norbert Preining changed: What|Removed |Added CC||norb...@preining.info --- Comment #3 from Norbert Preining --- I just realized that this is simply because `ddjvu` the program is not available. This means that in the pid==0 case the execvp fails and drops down to the exit(1). On my system, where I had the same problem, a simple installation of djvulibre-bin package fixed the crashes. -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Méven Car changed: What|Removed |Added CC||mirchevmartin2...@gmail.com --- Comment #2 from Méven Car --- *** Bug 420542 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Christoph Feck changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 420074] DJVU thumbnailer crashes kdeinit
https://bugs.kde.org/show_bug.cgi?id=420074 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik --- Calls > exit(1); But this is the child process. -- You are receiving this mail because: You are watching all bug changes.
