[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Ingo Klöcker]

https://bugs.kde.org/show_bug.cgi?id=415168

Ingo Klöcker  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/pim/
   ||libkleo/commit/44439dfa8454
   ||c0a86d194f6a777af003d719521
   ||2
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #10 from Ingo Klöcker  ---
Git commit 44439dfa8454c0a86d194f6a777af003d7195212 by Ingo Klöcker, on behalf
of Adriaan de Groot.
Committed on 13/01/2021 at 17:12.
Pushed by kloecker into branch 'master'.

Avoid RTTI mix-ups by exporting KeyListModelInterface

This attempts to fix a crash on FreeBSD. See: D26393 for
more info.

M  +1-0src/CMakeLists.txt
A  +13   -0src/models/keylistmodelinterface.cpp [License: GPL(v2.0+)]
M  +4-2src/models/keylistmodelinterface.h

https://invent.kde.org/pim/libkleo/commit/44439dfa8454c0a86d194f6a777af003d7195212

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #9 from gr...@kde.org ---
I've filed a MR in invent for this patch, since it wasn't being applied from
here. Same patch also applied in downstream packaging,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242670

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=415168

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/pim/libkleo/-/merge_requests/8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #7 from gr...@kde.org ---
@aheineke, your patch resolves the issue for me. I don't know how I missed
notifications from when you posted it, though (and Phab doesn't know about this
patch either, and .. sigh)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Gerard Seibert]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #6 from Gerard Seibert  ---
(In reply to Andre Heinecke from comment #4)
> Created attachment 125893 [details]
> De- Inline virtual dtor of Keylistmodelinterface and export it
> 
> The underlying reason is the "Invalid Model" from the debug output.
> 
> So I followed volkers advice from: https://phabricator.kde.org/D26393
> without completely understanding it.
> 
> Could someone try to compile libkleo and then recompile kleopatra with the
> attached patch?
> 
> I don't have a build setup for FreeBSD. For Linux it still works so I'm
> tempted to just push this but it would be better if someone could test it :-)

Thanks. I appreciate your efforts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Andre Heinecke]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #5 from Andre Heinecke  ---
*** Bug 417389 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Andre Heinecke]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #4 from Andre Heinecke  ---
Created attachment 125893
  --> https://bugs.kde.org/attachment.cgi?id=125893&action=edit
De- Inline virtual dtor of Keylistmodelinterface and export it

The underlying reason is the "Invalid Model" from the debug output.

So I followed volkers advice from: https://phabricator.kde.org/D26393 without
completely understanding it.

Could someone try to compile libkleo and then recompile kleopatra with the
attached patch?

I don't have a build setup for FreeBSD. For Linux it still works so I'm tempted
to just push this but it would be better if someone could test it :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=415168

gr...@kde.org changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D26393

--- Comment #3 from gr...@kde.org ---
There's a fix for this in Phabricator. I can't tell if it's a clang problem or
what, but the "double downcast" from QAbstractItemModel to
KeyListModelInterface fails; doing it explicitly in two steps works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=415168

gr...@kde.org changed:

   What|Removed |Added

 CC||gr...@kde.org

--- Comment #2 from gr...@kde.org ---
The relevant bit of Gerard's stack trace is this:

```
#6  0x0050ec86 in
Kleo::Dialogs::LookupCertificatesDialog::Private::selectedCertificates
(this=0x81666e280)
at
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp:103
view = 0x81ea3c300
model = 0x0
sm = 0x7fffcde0
```

which is tripping the assert() on that line (model is null). Since this is a
FreeBSD-specific thing, it seems, we'll track it at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242670 in first instance.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Gerard Seibert]

https://bugs.kde.org/show_bug.cgi?id=415168

--- Comment #1 from Gerard Seibert  ---
I rebuild kleopatra with debug symbols. This is the output when run under 'gdb'
when it crashes.

GNU gdb (GDB) 8.3.1 [GDB v8.3.1 for FreeBSD]
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-portbld-freebsd11.3".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
.
Find the GDB manual and other documentation resources online at:
.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from kleopatra...
run(gdb) run
Starting program: /usr/local/bin/kleopatra 
[New LWP 100796 of process 85700]
[New LWP 100797 of process 85700]
[Detaching after fork from child process 85701]
[Detaching after fork from child process 85702]
[Detaching after fork from child process 85703]
[Detaching after fork from child process 85705]
[Detaching after fork from child process 85707]
[Detaching after fork from child process 85709]
[Detaching after fork from child process 85711]
[Detaching after fork from child process 85713]
[Detaching after fork from child process 85714]
[Detaching after fork from child process 85716]
[Detaching after fork from child process 85719]
[Detaching after fork from child process 85722]
[Detaching after fork from child process 85725]
[Detaching after fork from child process 85728]
[Detaching after fork from child process 85731]
[New LWP 100799 of process 85700]
[New LWP 100801 of process 85700]
[Detaching after fork from child process 85733]
[LWP 100801 of process 85700 exited]
[New LWP 100802 of process 85700]
[New LWP 100803 of process 85700]
[Detaching after fork from child process 85735]
[Detaching after fork from child process 85737]
[LWP 100803 of process 85700 exited]
[Detaching after fork from child process 85739]
[LWP 100802 of process 85700 exited]
qt.xkb.compose: failed to create compose table
ASSERT: "model" in file
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp,
line 103

Thread 1 received signal SIGABRT, Aborted.
0x000807b379ba in thr_kill () from /lib/libc.so.7
(gdb) bt full
#0  0x000807b379ba in thr_kill () from /lib/libc.so.7
No symbol table info available.
#1  0x000807b37984 in raise () from /lib/libc.so.7
No symbol table info available.
#2  0x000807b378f9 in abort () from /lib/libc.so.7
No symbol table info available.
#3  0x000806aa68c9 in ?? () from /usr/local/lib/qt5/libQt5Core.so.5
No symbol table info available.
#4  0x000806aa7f2e in QMessageLogger::fatal(char const*, ...) const () from
/usr/local/lib/qt5/libQt5Core.so.5
No symbol table info available.
#5  0x000806aa26ad in qt_assert(char const*, char const*, int) () from
/usr/local/lib/qt5/libQt5Core.so.5
No symbol table info available.
#6  0x0050ec86 in
Kleo::Dialogs::LookupCertificatesDialog::Private::selectedCertificates
(this=0x81666e280)
at
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp:103
view = 0x81ea3c300
model = 0x0
sm = 0x7fffcde0
#7  0x0050db33 in
Kleo::Dialogs::LookupCertificatesDialog::selectedCertificates
(this=0x81ec1e1c0)
at
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp:202
No locals.
#8  0x0050de38 in
Kleo::Dialogs::LookupCertificatesDialog::Private::enableDisableWidgets
(this=0x81666e280)
at
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp:250
n = 8
#9  0x0050efb5 in
Kleo::Dialogs::LookupCertificatesDialog::Private::slotSearchTextChanged
(this=0x81666e280)
at
/usr/ports/security/kleopatra/work/kleopatra-19.12.0/src/dialogs/lookupcertificatesdialog.cpp:71
No locals.
#10 0x0050e217 in
Kleo::Dialogs::LookupCertificatesDialog::qt_static_metacall (_o=0x81ec1e1c0,
_c=QMetaObject::InvokeMetaMethod, _id=5, _a=0x7fffd090)
at src/kleopatra_bin_autogen/include/moc_lookupcertificatesdialog.cpp:118
_t = 0x81ec1e1c0
#11 0x000806cbd241 in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/local/lib/qt5/libQt5Core.so.5
No symbol table info available.
#12 0x000805abbe91 in ?? () from /usr/local/lib/qt5/libQt5Widgets.so.5
No symbol table info available.
#13 0x000806cbd241 in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/local/lib/qt5/libQt5Core.so.5
No symbol table info available.
#14 0x000805abe237 in QWidgetLineControl::finishChange(int, bool, bool) ()
from /usr/local/lib/qt5/libQt5Widgets.so.5
No symbol table info a

[kleopatra] [Bug 415168] Kleopatra crashing when looking up id on server

[Gerard Seibert]

https://bugs.kde.org/show_bug.cgi?id=415168

Gerard Seibert  changed:

   What|Removed |Added

 CC||gerard.seib...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.