[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 Laurent Montel changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|https://commits.kde.org/mes |https://commits.kde.org/mes |sagelib/56f1d42f68ed2f597fc |sagelib/b551d400afe823b4357 |599e4952ee81e579cd355 |b9e3a0ed7ba233e27a77e Status|REOPENED|RESOLVED --- Comment #7 from Laurent Montel --- Git commit b551d400afe823b4357b9e3a0ed7ba233e27a77e by Laurent Montel. Committed on 19/12/2019 at 07:22. Pushed by mlaurent into branch 'release/19.12'. Fix Bug 415254 - [regression] HTML viewer complains about "external references to images etc." when there are no images FIXED-IN: 5.13.1 M +0-3messageviewer/src/utils/autotests/messageviewerutilstest.cpp M +23 -4messageviewer/src/utils/messageviewerutil.cpp https://commits.kde.org/messagelib/b551d400afe823b4357b9e3a0ed7ba233e27a77e -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 --- Comment #6 from Laurent Montel --- Git commit 34ab26ced039167a87f71a8b0a39630480305d99 by Laurent Montel. Committed on 17/12/2019 at 12:38. Pushed by mlaurent into branch 'release/19.12'. Test excludeExtraHeader. Need to improve regexp. (cherry picked from commit e7a170f39c26ee7d4a180724c813e65331727492) M +1-52 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp M +1-0messageviewer/src/utils/autotests/CMakeLists.txt A +6-0messageviewer/src/utils/autotests/data/image.txt A +6-0messageviewer/src/utils/autotests/data/image2.txt A +5-0messageviewer/src/utils/autotests/data/noimage.txt A +3-0messageviewer/src/utils/autotests/data/noimage2.txt A +3-0messageviewer/src/utils/autotests/data/noimage3.txt M +29 -0messageviewer/src/utils/autotests/messageviewerutilstest.cpp M +3-0messageviewer/src/utils/autotests/messageviewerutilstest.h M +50 -0messageviewer/src/utils/messageviewerutil.cpp M +1-0messageviewer/src/utils/messageviewerutil.h https://commits.kde.org/messagelib/34ab26ced039167a87f71a8b0a39630480305d99 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 --- Comment #5 from Laurent Montel --- Git commit e7a170f39c26ee7d4a180724c813e65331727492 by Laurent Montel. Committed on 17/12/2019 at 12:36. Pushed by mlaurent into branch 'master'. Test excludeExtraHeader. Need to improve regexp. M +1-52 messageviewer/src/messagepartthemes/default/defaultrenderer.cpp M +1-0messageviewer/src/utils/autotests/CMakeLists.txt A +6-0messageviewer/src/utils/autotests/data/image.txt A +6-0messageviewer/src/utils/autotests/data/image2.txt A +5-0messageviewer/src/utils/autotests/data/noimage.txt A +3-0messageviewer/src/utils/autotests/data/noimage2.txt A +3-0messageviewer/src/utils/autotests/data/noimage3.txt M +29 -0messageviewer/src/utils/autotests/messageviewerutilstest.cpp M +3-0messageviewer/src/utils/autotests/messageviewerutilstest.h M +50 -0messageviewer/src/utils/messageviewerutil.cpp M +1-0messageviewer/src/utils/messageviewerutil.h https://commits.kde.org/messagelib/e7a170f39c26ee7d4a180724c813e65331727492 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 Laurent Montel changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Laurent Montel --- Hum... indeed. I will improve check. -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254
--- Comment #3 from Thiago Macieira ---
(In reply to Laurent Montel from comment #2)
> Git commit 56f1d42f68ed2f597fc599e4952ee81e579cd355 by Laurent Montel.
> Committed on 17/12/2019 at 06:05.
> Pushed by mlaurent into branch 'release/19.12'.
>
> Fix Bug 415254 - [regression] HTML viewer complains about "external
> references to images etc." when there are no images
>
> FIXED-IN: 5.13.1
>
> M +2-2
> messageviewer/src/messagepartthemes/default/defaultrenderer.cpp
>
> https://commits.kde.org/messagelib/56f1d42f68ed2f597fc599e4952ee81e579cd355
+if (str.contains(QRegularExpression(QLatin1String("https://...;>, with the quotes? The code above this section
deals with href=", but not src=.
This will also trigger as a false positive in the following HTML:
Some text goes here blah blah src=http://example.com
--
You are receiving this mail because:
You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 Laurent Montel changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.13.1 Latest Commit||https://commits.kde.org/mes ||sagelib/56f1d42f68ed2f597fc ||599e4952ee81e579cd355 Status|ASSIGNED|RESOLVED --- Comment #2 from Laurent Montel --- Git commit 56f1d42f68ed2f597fc599e4952ee81e579cd355 by Laurent Montel. Committed on 17/12/2019 at 06:05. Pushed by mlaurent into branch 'release/19.12'. Fix Bug 415254 - [regression] HTML viewer complains about "external references to images etc." when there are no images FIXED-IN: 5.13.1 M +2-2messageviewer/src/messagepartthemes/default/defaultrenderer.cpp https://commits.kde.org/messagelib/56f1d42f68ed2f597fc599e4952ee81e579cd355 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 415254] [regression] HTML viewer complains about "external references to images etc." when there are no images
https://bugs.kde.org/show_bug.cgi?id=415254 Laurent Montel changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED CC||mon...@kde.org --- Comment #1 from Laurent Montel --- I confirm it. I will work on it soon. -- You are receiving this mail because: You are watching all bug changes.
