[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2023-01-13 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=332924

Thomas Baumgart  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/offi |https://invent.kde.org/offi
   |ce/kmymoney/commit/819f2600 |ce/kmymoney/commit/68b81627
   |84b7e29713ce6fec1efcd0946c4 |958ee33b26301b674207da47d06
   |27740   |5f6f8

--- Comment #11 from Thomas Baumgart  ---
Git commit 68b81627958ee33b26301b674207da47d065f6f8 by Thomas Baumgart.
Committed on 14/01/2023 at 05:53.
Pushed by tbaumgart into branch '5.1'.

Investment view, Equities: sort by actual value instead of display value

Backporting commit 819f2600 to stable 5.1 branch
Related: bug 428940

M  +28   -1kmymoney/models/equitiesmodel.cpp
M  +2-1kmymoney/models/equitiesmodel.h

https://invent.kde.org/office/kmymoney/commit/68b81627958ee33b26301b674207da47d065f6f8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2023-01-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=332924

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |ASSIGNED
 Resolution|WAITINGFORINFO  |---

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/office/kmymoney/-/merge_requests/191

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2023-01-08 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=332924

Thomas Baumgart  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO

--- Comment #9 from Thomas Baumgart  ---
Yes, the fix was easy enough, but I don't have any test data. Merge request
https://invent.kde.org/office/kmymoney/-/merge_requests/191 has been added.
Please verify and confirm it's working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2023-01-07 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=332924

--- Comment #8 from Jack  ---
Very odd - it looks like those changes were only made in master and not the 5.1
branch.  Was it actually working in 5.1.2?  The branches differ enough that
backporting will not be trivial (for me.)  Hopefully the fix isn't actually too
difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2023-01-07 Thread Andreas Freimuth
https://bugs.kde.org/show_bug.cgi?id=332924

Andreas Freimuth  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 CC||m.n...@gmx.net

--- Comment #7 from Andreas Freimuth  ---
Still an issue with v5.1.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2021-08-18 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=332924

Thomas Baumgart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|http://commits.kde.org/kmym |https://invent.kde.org/offi
   |oney/4458e573676ee1096cec2a |ce/kmymoney/commit/819f2600
   |55955299983a63c0fe  |84b7e29713ce6fec1efcd0946c4
   ||27740
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Thomas Baumgart  ---
Git commit 819f260084b7e29713ce6fec1efcd0946c427740 by Thomas Baumgart, on
behalf of Wei Qi Ong.
Committed on 18/08/2021 at 19:40.
Pushed by tbaumgart into branch 'master'.

Investment view, Equities: sort by actual value instead of display value
Related: bug 428940

M  +22   -3kmymoney/models/equitiesmodel.cpp
M  +1-0kmymoney/views/kinvestmentview_p.h

https://invent.kde.org/office/kmymoney/commit/819f260084b7e29713ce6fec1efcd0946c427740

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2021-08-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=332924

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/office/kmymoney/-/merge_requests/113

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2020-01-20 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=332924

--- Comment #4 from Jack  ---
It was reverted by commit e5d6a2594c52949deb90ec3751760316e866336b on
2017-09-11 18:51:48 +0200 by Łukasz Wojniłowicz.  I guess he missed the comment
"This class is only needed to implement proper sorting." and just deleted that
class, without addressing sorting at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 332924] Investment view, equity tab, sorts numeric columns by alpha sort instead of numeric

2020-01-20 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=332924

Jack  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Jack  ---
I was about to open a new bug for exactly this reason.  It seems this fix was
somehow reverted since 2014.  I'll try to track down which commit did it.

-- 
You are receiving this mail because:
You are watching all bug changes.