[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[MAG4]

https://bugs.kde.org/show_bug.cgi?id=390024

MAG4  changed:

   What|Removed |Added

 CC|m...@aruba.it   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #22 from Kevin Kofler  ---
*** Bug 417156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #21 from Wolfgang Bauer  ---
*** Bug 417156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=390024

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||mike.gil...@gmail.com

--- Comment #20 from Wolfgang Bauer  ---
*** Bug 417156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Mikle]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #19 from Mikle  ---
good works! Thank's! All functions working now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #18 from Jeremy Whiting  ---
Ah right. Thanks for doing that Luigi.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #17 from Luigi Toscano  ---
(In reply to Jeremy Whiting from comment #15)
> Just pushed a fix for this issue to master branch. It will be in the next
> release 19.08 I believe, Missed the tag for 19.08 beta, but will be in the
> RC and release.

Thanks Jeremy, but the Applications/19.08 has been already created, so the
commit needs to be backported (I just did it), otherwise it will miss
Applications 19.08 RC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=390024

Luigi Toscano  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kom
   ||pare/5f7444b061b6453aad2ede
   ||25a598cf175893eb89

--- Comment #16 from Luigi Toscano  ---
Git commit 5f7444b061b6453aad2ede25a598cf175893eb89 by Luigi Toscano, on behalf
of Jeremy Whiting.
Committed on 22/07/2019 at 07:45.
Pushed by ltoscano into branch 'Applications/19.08'.

Fix browse for files/folders doesn't enable "Compare" button.

Since KUrlComboBox::setUrl doesn't emit textChanged (by design according
to it's documentation) we need to emit a signal from FilesPage when
we set the url programatically so the kompareurldialog knows something
changed and to enable the button if both boxes have content.

(cherry picked from commit 006f36d3628bf4da18fe474f470694828904c197)

M  +2-1kompareurldialog.cpp
M  +1-0libdialogpages/filespage.cpp
M  +7-0libdialogpages/filespage.h

https://commits.kde.org/kompare/5f7444b061b6453aad2ede25a598cf175893eb89

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

Jeremy Whiting  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Jeremy Whiting  ---
Just pushed a fix for this issue to master branch. It will be in the next
release 19.08 I believe, Missed the tag for 19.08 beta, but will be in the RC
and release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=390024

mikz...@gmail.com changed:

   What|Removed |Added

 CC||mikz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Alexander Shchadilov]

https://bugs.kde.org/show_bug.cgi?id=390024

Alexander Shchadilov  changed:

   What|Removed |Added

 CC||alexander.shchadilov@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Ashark]

https://bugs.kde.org/show_bug.cgi?id=390024

Ashark  changed:

   What|Removed |Added

 CC||ash...@linuxcomp.ru

--- Comment #14 from Ashark  ---
Operating System: Arch Linux 
KDE Plasma Version: 5.16.0
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3
Kompare version: 4.1.3 (19.04.2-1)

Still reproducible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Mikle]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #13 from Mikle  ---
...
kompare-18.12.3 and git-version. 
Not usable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Mikle]

https://bugs.kde.org/show_bug.cgi?id=390024

Mikle  changed:

   What|Removed |Added

 CC||gramoz...@rocketmail.com

--- Comment #12 from Mikle  ---
This is still present in the last realize:
Plasma 5.15.3
Frameworks 5.56(and 5.55)
Qt 5.12.2
In dialog "select files" to diff, the "Compare" button is still disabled.
In next dialog "Kompare" → "aplication for diff", select any valid aplications
not effect.
(Meld work fine, diff at console work fine)
in console nothing errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=390024

andreas.sturmlech...@gmail.com changed:

   What|Removed |Added

 CC||andreas.sturmlechner@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Roland]

https://bugs.kde.org/show_bug.cgi?id=390024

Roland  changed:

   What|Removed |Added

 CC||k...@brownslink.net

--- Comment #11 from Roland  ---
This is still present in the updated version of Kubuntu 18.04 (still 4.1.3).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[MAG4]

https://bugs.kde.org/show_bug.cgi?id=390024

MAG4  changed:

   What|Removed |Added

 CC||m...@aruba.it

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Marco Parillo]

https://bugs.kde.org/show_bug.cgi?id=390024

Marco Parillo  changed:

   What|Removed |Added

 CC||marco_pari...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Rik Mills]

https://bugs.kde.org/show_bug.cgi?id=390024

Rik Mills  changed:

   What|Removed |Added

 CC||rikmi...@kubuntu.org

--- Comment #10 from Rik Mills  ---
This bug is still present with Kompare 18.08 and latest frameworks master

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Karsten de Freese]

https://bugs.kde.org/show_bug.cgi?id=390024

Karsten de Freese  changed:

   What|Removed |Added

 CC||kars...@maxi-dsl.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Francesco Turco]

https://bugs.kde.org/show_bug.cgi?id=390024

Francesco Turco  changed:

   What|Removed |Added

 CC||ftu...@fastmail.fm

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=390024

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler  changed:

   What|Removed |Added

 CC|kevin.kof...@chello.at  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler  changed:

   What|Removed |Added

 CC||kevin.kof...@chello.at

--- Comment #9 from Kevin Kofler  ---
Just so the workaround is also clearly visible here, I am reposting
https://bugs.kde.org/show_bug.cgi?id=391405#c2 here:

Jeremy Whiting wrote:
> As a temporary workaround after choosing files typing anything in either box
> (even a space) activates the button. Working on the proper solution for the
> bug in frameworks though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler  changed:

   What|Removed |Added

 CC||f.alexander.wi...@gmail.com

--- Comment #8 from Kevin Kofler  ---
*** Bug 391405 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #7 from Jeremy Whiting  ---
Alternatively we could have the FilesPage emit a signal after it calls setUrl
on the KUrlCombobox

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #6 from Jeremy Whiting  ---
https://cgit.kde.org/kio.git/commit/?id=a43aea3ebc697fad4be8be821b94c8374d08
is definitely the cause undoing the bits of that commit in kurlrequester.cpp
fix the bug, but I'm not sure why yet. We are connecting to KURLRequester's
textChanged signal in kompare, but we are changing the KURLRequester's
KUrlComboBox itself with setUrl when those buttons are clicked.
KUrlComboBox::setUrl turns off its own signals, so I don't see how that ever
worked except that we were connected to the lineedit rather than the QComboBox
I guess.

A simple fix is in KUrlComboBox setUrl to emit textChanged after changing the
url in setUrl, but I'm not sure if that makes the most sense or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #5 from Jeremy Whiting  ---
Yep, I can recreate with latest kompare and kf5 from git. Let's see if I can
find the cause now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Platform|Other   |Fedora RPMs
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Kevin Kofler  ---
I can reproduce the issue here:
kompare 4.1.3 from kompare-17.12.1-1.fc27.x86_64
kf5 5.42.0 from Fedora RPMs
qt5-qtbase 5.9.2 from Fedora RPMs
which is why I asked Luigi to file this issue here to begin with.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #3 from Jeremy Whiting  ---
I used the buttons to select files here which worked. That's not working there?
I wonder if KURLRequester has a regression possibly. We are connecting to it's
textChanged signal which seems to be working here with the kf5 packages I have
from debian.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #2 from Luigi Toscano  ---
Right: you don't have to type. If you type the file path, it works. If you
click on the right buttons and browse and select the name from there, then the
signal is not triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

Jeremy Whiting  changed:

   What|Removed |Added

 CC||jpwhit...@kde.org

--- Comment #1 from Jeremy Whiting  ---
Luigi, it seems to work fine here. From looking at the code a KUrlRequester is
used for each line edit and if either of them change they tell the ui to check
if they are both not empty and enable that button. I tried here with the
packaged version in debian buster and it worked ok, can you recreate this every
time there?

-- 
You are receiving this mail because:
You are watching all bug changes.