[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-22 Thread Stefano Crocco
https://bugs.kde.org/show_bug.cgi?id=478255

Stefano Crocco  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/netw
   ||ork/konqueror/-/commit/94fe
   ||eeec7bef391c3e48d9c8f884bb0
   ||a68e1c7ea

--- Comment #11 from Stefano Crocco  ---
Git commit 94fc7bef391c3e48d9c8f884bb0a68e1c7ea by Stefano Crocco.
Committed on 22/12/2023 at 19:50.
Pushed by stefanocrocco into branch 'master'.

Don't delay loading of views which aren't in the tab container

Delay loading of views which aren't in the tab container doesn't make sense
because they are always visible. Besides, it didn't work because they were
never actually loaded.

M  +56   -4src/konqviewmanager.cpp
M  +12   -0src/konqviewmanager.h

https://invent.kde.org/network/konqueror/-/commit/94fc7bef391c3e48d9c8f884bb0a68e1c7ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=478255

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/network/konqueror/-/merge_requests/267

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread Stefano Crocco
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #9 from Stefano Crocco  ---
(In reply to avlas from comment #8)
> > What I mean is that when konqueror restarts the sidebar is not seen but the
> > space for it is there. You then can reactivate the sidebar and it appears. 
> > 
> > If you repeat the cycle, the empty space grows 1 sidebar-length each time,
> > accumulating space for sidebar after sidebar. In fact, if you then checkout
> > to the commit previous to kf6 and open konqueror, you can see n sidebars one
> > after the other.
> 
> If you cannot reproduce this, try with the setting that restores tabs on
> startup

Ok. Now I can reproduce the issue. I'll try to find out the cause

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #8 from avlas  ---
> What I mean is that when konqueror restarts the sidebar is not seen but the
> space for it is there. You then can reactivate the sidebar and it appears. 
> 
> If you repeat the cycle, the empty space grows 1 sidebar-length each time,
> accumulating space for sidebar after sidebar. In fact, if you then checkout
> to the commit previous to kf6 and open konqueror, you can see n sidebars one
> after the other.

If you cannot reproduce this, try with the setting that restores tabs on
startup

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #7 from avlas  ---

> Regarding the location bar issue, I found the cause and created a merge
> request for it: https://invent.kde.org/network/konqueror/-/merge_requests/266


Awesome!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #6 from avlas  ---
(In reply to Stefano Crocco from comment #5)
> (In reply to avlas from comment #4)
> > I use kf5. See the effect here: https://i.imgur.com/PbJLzDQ.png
> > 
> > The way to show this is: activate the sidebar and restart konqueror
> 
> Just to be clear, is this what you mean?
> - open Konqueror
> - turn on "Show sidebar"
> - close Konqueror
> - start Konqueror again. The sidebar is not visible anymore
> - turn on "Show sidebar" again. The sidebar doesn't become visibile but the
> space of the main view is reduced to make place for it.
> 
> If It is so, I can't reproduce your issue. Or rather, I can confirm that the
> sidebar status isn't remembered from one session to the next (which
> shouldn't happen), but toggling it on again works correctly.
> 
> Regarding the location bar issue, I found the cause and created a merge
> request for it: https://invent.kde.org/network/konqueror/-/merge_requests/266

What I mean is that when konqueror restarts the sidebar is not seen but the
space for it is there. You then can reactivate the sidebar and it appears. 

If you repeat the cycle, the empty space grows 1 sidebar-length each time,
accumulating space for sidebar after sidebar. In fact, if you then checkout to
the commit previous to kf6 and open konqueror, you can see n sidebars one after
the other.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread Stefano Crocco
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #5 from Stefano Crocco  ---
(In reply to avlas from comment #4)
> I use kf5. See the effect here: https://i.imgur.com/PbJLzDQ.png
> 
> The way to show this is: activate the sidebar and restart konqueror

Just to be clear, is this what you mean?
- open Konqueror
- turn on "Show sidebar"
- close Konqueror
- start Konqueror again. The sidebar is not visible anymore
- turn on "Show sidebar" again. The sidebar doesn't become visibile but the
space of the main view is reduced to make place for it.

If It is so, I can't reproduce your issue. Or rather, I can confirm that the
sidebar status isn't remembered from one session to the next (which shouldn't
happen), but toggling it on again works correctly.

Regarding the location bar issue, I found the cause and created a merge request
for it: https://invent.kde.org/network/konqueror/-/merge_requests/266

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread Stefano Crocco
https://bugs.kde.org/show_bug.cgi?id=478255

Stefano Crocco  changed:

   What|Removed |Added

   Keywords|qt6 |

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #4 from avlas  ---
I use kf5. See the effect here: https://i.imgur.com/PbJLzDQ.png

The way to show this is: activate the sidebar and restart konqueror

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-15 Thread Stefano Crocco
https://bugs.kde.org/show_bug.cgi?id=478255

Stefano Crocco  changed:

   What|Removed |Added

 CC||stefano.cro...@alice.it

--- Comment #3 from Stefano Crocco  ---
(In reply to avlas from comment #2)
> The issue with the sidebar returned. Unsure what triggers it but the active
> status is not hold and more and more space is created for the sidebars when
> reactivated (loops of open konqueror, reactivate the sidebar, close
> konqueror and open again). After this, if you go back with git checkout to
> the commit previous to the kf6 merge you can see several sidebars being
> active.

Are you testing with KF5 or KF6? I just discovered a bug which would cause
(among other things) the sidebar not to load in KF6. There's a merge request
for it at https://invent.kde.org/network/konqueror/-/merge_requests/265

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-11 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=478255

--- Comment #2 from avlas  ---
The issue with the sidebar returned. Unsure what triggers it but the active
status is not hold and more and more space is created for the sidebars when
reactivated (loops of open konqueror, reactivate the sidebar, close konqueror
and open again). After this, if you go back with git checkout to the commit
previous to the kf6 merge you can see several sidebars being active.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=478255

fanzhuyi...@gmail.com changed:

   What|Removed |Added

 CC|fanzhuyi...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[konqueror] [Bug 478255] localization bar (URL) does not get compressed with small window size

2023-12-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=478255

fanzhuyi...@gmail.com changed:

   What|Removed |Added

 CC||fanzhuyi...@gmail.com
Summary|Issues after merging Kf6|localization bar (URL) does
   |branch  |not get compressed with
   ||small window size
   Keywords||qt6

-- 
You are receiving this mail because:
You are watching all bug changes.