[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #7 from Duncan <1i5t5.dun...@cox.net> --- Verified fixed, thanks. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 Kurt Hindenburg changed: What|Removed |Added Latest Commit||https://commits.kde.org/kon ||sole/274633a321625cd2790a21 ||7c4422c15ed730f00d Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Kurt Hindenburg --- Git commit 274633a321625cd2790a217c4422c15ed730f00d by Kurt Hindenburg. Committed on 22/06/2018 at 10:40. Pushed by hindenburg into branch 'master'. Revert "Simplify code dealing with creating new sessions." This reverts commit e1f7107cc0b42113be9b7ea6b4a0f83ce885ba2d. This broke -e . Since this was just to simpify code, reverting for now M +16 -2src/MainWindow.cpp M +12 -5src/Part.cpp M +43 -12 src/ViewManager.cpp M +12 -1src/ViewManager.h https://commits.kde.org/konsole/274633a321625cd2790a217c4422c15ed730f00d -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 --- Comment #5 from Kurt Hindenburg --- I'll just revert thanks -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 --- Comment #4 from tcanabr...@kde.org --- People, I'v tried to fix e1f7107cc for two days without being able to, so let's just revert that, I'll try to came up with another solution for the code duplication in the future. Kurt, as I'm new to konsole development, should I revert and push or should I add a review? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 --- Comment #3 from tcanabr...@kde.org --- I'm on it. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 --- Comment #2 from Kurt Hindenburg --- Thanks for the report - the issue is in the MW:createSession change - if Thomaz or I can't fix in shortly I'll revert this. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com, ||tcanabr...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 395555] konsole commit e1f7107cc breaks -e option
https://bugs.kde.org/show_bug.cgi?id=39 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Duncan <1i5t5.dun...@cox.net> --- Confirming it's commit e1f7107cc. Reverting that on top of current 48448131e gives me a working -e option. (It's gentoo/kde live-git packages so I can apply a patch by simply dropping it in the appropriate dir and rebuilding, as I did here for the revert, redirecting the output of git show -R, if you need me to test further patches.) -- You are receiving this mail because: You are watching all bug changes.
