[konsole] [Bug 399140] Notification for "Bell" is useless

2020-12-27 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=399140

Ahmad Samir  changed:

   What|Removed |Added

 CC||d...@net.com.org.es

--- Comment #5 from Ahmad Samir  ---
*** Bug 165193 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-11-11 Thread Oded Arbel
https://bugs.kde.org/show_bug.cgi?id=399140

Oded Arbel  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #4 from Oded Arbel  ---
Works nicely. Thank you very much for this fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-11-01 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=399140

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kon
   ||sole/674243f126bb3bd72ce823
   ||ff0144b870d64bcf21
   Version Fixed In||18.12
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Kurt Hindenburg  ---
Git commit 674243f126bb3bd72ce823ff0144b870d64bcf21 by Kurt Hindenburg, on
behalf of Andrew Smith.
Committed on 01/11/2018 at 22:06.
Pushed by hindenburg into branch 'master'.

Update session icon on notification bell

Summary:
Change the icon of the session when a `bel` is triggered as a visually alert
FIXED-IN: 18.12

Test Plan:
1. Start Konsole and create 2 sessions (tabs) from the same profile
 (for example, the default profile)
2. In one tab run `sleep 3; tput bel`
3. Switch to the other tab and wait 3 seconds

Reviewers: #konsole, konsole-devel, hindenburg, ngraham

Reviewed By: ngraham

Subscribers: ngraham, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D16511

M  +5-0src/SessionController.cpp

https://commits.kde.org/konsole/674243f126bb3bd72ce823ff0144b870d64bcf21

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-10-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399140

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
   Keywords||investigated, triaged
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-10-11 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=399140

--- Comment #2 from Kurt Hindenburg  ---
For #2, I recall someone provided some code for that.  I'd have to search what
happened to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-09-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399140

Nate Graham  changed:

   What|Removed |Added

   Keywords||junior-jobs, usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-09-28 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=399140

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
The relevant code [1] sends "_nameTitle" in the notification. Session class
also contains _displayTitle and _userTitle which I think is used for the window
title. Looks like an easy fix? :)

[1] https://cgit.kde.org/konsole.git/tree/src/Session.cpp#n692

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 399140] Notification for "Bell" is useless

2018-09-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399140

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.