[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589
Kurt Hindenburg changed:
What|Removed |Added
Latest Commit|https://commits.kde.org/kon |https://commits.kde.org/kon
|sole/eccfb1f62bbf67ebffee11 |sole/9af659c73e3203e1d5ef38
|e241bd05757b826ff1 |73fa6c0144258b9673
--- Comment #8 from Kurt Hindenburg ---
Git commit 9af659c73e3203e1d5ef3873fa6c0144258b9673 by Kurt Hindenburg, on
behalf of Wolfgang Bauer.
Committed on 07/03/2019 at 01:32.
Pushed by hindenburg into branch 'Applications/18.12'.
Fix ibeam and underline cursor rendering
Summary:
Since anti-aliasing was enabled in the painter, coordinates need to
be shifted half a pixel so that they align with the pixel grid,
otherwise the result gets "blurred" due to the anti-aliasing.
And as parts of the blurred shape leak outside the cursor rectangle,
this also leaves artifacts when the cursor moves or blinks as these
parts are not cleared.
This is basically the same as commit
e7085310d6d594823d0ed491fa8bdbd99dec4932 for the
standard block cursor.
Test Plan:
- Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"
profile settings
The cursors are a single line again now, before they were blurred by
anti-aliasing.
Screenshots:
Before:
{F6656366}
{F6656370}
After:
{F6656371}
{F6656373}
Also, there are no more artifacts when the cursor is moved or
cursor blinking is enabled.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19513
(cherry picked from commit eccfb1f62bbf67ebffee11e241bd05757b826ff1)
M +10 -8src/TerminalDisplay.cpp
https://commits.kde.org/konsole/9af659c73e3203e1d5ef3873fa6c0144258b9673
--
You are receiving this mail because:
You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Nate Graham changed: What|Removed |Added Version Fixed In||19.04.0 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589
Kurt Hindenburg changed:
What|Removed |Added
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit||https://commits.kde.org/kon
||sole/eccfb1f62bbf67ebffee11
||e241bd05757b826ff1
--- Comment #7 from Kurt Hindenburg ---
Git commit eccfb1f62bbf67ebffee11e241bd05757b826ff1 by Kurt Hindenburg, on
behalf of Wolfgang Bauer.
Committed on 05/03/2019 at 14:37.
Pushed by hindenburg into branch 'master'.
Fix ibeam and underline cursor rendering
Summary:
Since anti-aliasing was enabled in the painter, coordinates need to
be shifted half a pixel so that they align with the pixel grid,
otherwise the result gets "blurred" due to the anti-aliasing.
And as parts of the blurred shape leak outside the cursor rectangle,
this also leaves artifacts when the cursor moves or blinks as these
parts are not cleared.
This is basically the same as commit
e7085310d6d594823d0ed491fa8bdbd99dec4932 for the
standard block cursor.
Test Plan:
- Switch cursor shape to "I-Beam" or "Underline" in the "Advanced"
profile settings
The cursors are a single line again now, before they were blurred by
anti-aliasing.
Screenshots:
Before:
{F6656366}
{F6656370}
After:
{F6656371}
{F6656373}
Also, there are no more artifacts when the cursor is moved or
cursor blinking is enabled.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19513
M +10 -8src/TerminalDisplay.cpp
https://commits.kde.org/konsole/eccfb1f62bbf67ebffee11e241bd05757b826ff1
--
You are receiving this mail because:
You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 --- Comment #6 from Nikos Chantziaras --- (In reply to Wolfgang Bauer from comment #5) > This fixes it for me: > https://phabricator.kde.org/D19513 Same here. Applied to 18.12.2 and it fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #5 from Wolfgang Bauer --- This fixes it for me: https://phabricator.kde.org/D19513 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Wolfgang Bauer changed: What|Removed |Added CC||i...@ilya.pp.ua --- Comment #4 from Wolfgang Bauer --- *** Bug 404873 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 --- Comment #3 from Nikos Chantziaras --- If you have problems reproducing, try using a bitmap font. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Michael Everitt changed: What|Removed |Added CC||m.j.ever...@iee.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Nate Graham changed: What|Removed |Added CC||awil...@adelielinux.org --- Comment #2 from Nate Graham --- *** Bug 404973 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Nikos Chantziaras changed: What|Removed |Added Version|master |18.12.1 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 andreas.sturmlech...@gmail.com changed: What|Removed |Added CC||andreas.sturmlechner@gmail. ||com -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402589] Text cursor disappears or doesn't move
https://bugs.kde.org/show_bug.cgi?id=402589 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||martin.sandsm...@kde.org --- Comment #1 from Kurt Hindenburg --- Thanks - Martin can you look at this? -- You are receiving this mail because: You are watching all bug changes.
