[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752
--- Comment #12 from j...@forestfield.org ---
Great catch Carlos Alves, changing that setting to "always" does make the new
tab button always appear and that is a setting that makes sense to me. The
"never" setting also makes sense to me.
But there's a third setting ("when needed") which makes me think: what is "when
needed" supposed to mean? How is "when needed" different than "always" in terms
of rationale?
I don't understand how having two tabs makes the new tab button 'needed' but
having one tab means the new tab button is 'not needed'.
Thanks again Carlos Alves.
--
You are receiving this mail because:
You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Carlos Alves changed: What|Removed |Added CC||cbc.al...@gmail.com --- Comment #11 from Carlos Alves --- Settings->Tab Bar->Show->Always and check the "Show 'New Tab' button" (then Apply And Ok) Seems to be this the problem. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 j...@forestfield.org changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #10 from j...@forestfield.org --- In Konsole version 20.12.0 there appears to be no new tab button at all until a second tabs is added. I have no idea why 2 tabs are needed to see the button. I would have thought the new tab button should always be visible so that that button can be used to add a second tab. I've added a video to show what I'm referring to. System information: Operating System: Debian GNU/Linux KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.74.0 Qt Version: 5.15.2 Kernel Version: 5.9.0-5-amd64 OS Type: 64-bit Processors: 8 × AMD FX(tm)-8150 Eight-Core Processor Memory: 31.3 GiB of RAM Graphics Processor: NV106 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 j...@forestfield.org changed: What|Removed |Added CC||j...@forestfield.org --- Comment #9 from j...@forestfield.org --- Created attachment 134238 --> https://bugs.kde.org/attachment.cgi?id=134238=edit Showing Konsole new tab button behavior -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Justin Zobel changed: What|Removed |Added CC||justin.zo...@gmail.com --- Comment #8 from Justin Zobel --- I've just tested this and the profile menu from the new tab popup only ever appears on my primary screen no matter where Konsole is (triple monitor setup). -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 --- Comment #7 from Christoph Feck --- Fixed with Qt 5.15. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Arfrever Frehtes Taifersar Arahesis changed: What|Removed |Added CC||da...@davidhallas.dk --- Comment #6 from Arfrever Frehtes Taifersar Arahesis --- This problem was introduced in commit 03a78c2a9f4248653e928c341bb4610c4aeea33b: https://cgit.kde.org/konsole.git/commit/?id=03a78c2a9f4248653e928c341bb4610c4aeea33b commit 03a78c2a9f4248653e928c341bb4610c4aeea33b (HEAD) Author: David Hallas AuthorDate: 2019-03-28 08:55:18 -0400 Commit: Kurt Hindenburg CommitDate: 2019-03-28 09:14:13 -0400 Fixes minor memory leaks Summary: Fixes a few minor memory leaks found with address sanitizer. The newTabButton and closeTabButton was not passed a parent and is not deleted in the destructor of TabbedViewContainer which will cause them to be leaked when closing a tab. Instead pass the TabbedViewContainer as the parent. The same goes for the profileMenu, it was not passed a parent pointer at contruction and the setMenu function doesn't take ownership of it, so therefore it was also leaked. Test Plan: Compile konsole with address sanitizer. Open and close konsole. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D19634 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Arfrever Frehtes Taifersar Arahesis changed: What|Removed |Added CC|tcanabr...@kde.org | --- Comment #5 from Arfrever Frehtes Taifersar Arahesis --- (In reply to Arfrever Frehtes Taifersar Arahesis from comment #4) > This problem was introduced in commit > 4cddc420e319686956446da2724a27a672817ff1 I have been deceived by https://cgit.kde.org/konsole.git/log/?h=master showing commits from all branches (not only "master" branch) (while e.g. https://cgit.kde.org/konsole.git/log/?h=Applications/19.04 shows commits from only "Applications/19.04" branch). -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Arfrever Frehtes Taifersar Arahesis changed: What|Removed |Added See Also|https://bugs.kde.org/show_b | |ug.cgi?id=406828| -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Arfrever Frehtes Taifersar Arahesis changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=406828 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Arfrever Frehtes Taifersar Arahesis changed: What|Removed |Added CC||tcanabr...@kde.org --- Comment #4 from Arfrever Frehtes Taifersar Arahesis --- This problem was introduced in commit 4cddc420e319686956446da2724a27a672817ff1: https://cgit.kde.org/konsole.git/commit/?id=4cddc420e319686956446da2724a27a672817ff1 commit 4cddc420e319686956446da2724a27a672817ff1 Author: Tomaz Canabrava AuthorDate: 2019-03-28 09:27:15 -0400 Commit: Kurt Hindenburg CommitDate: 2019-03-28 09:50:38 -0400 Simplify TerminalDisplay code Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D20088 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 --- Comment #3 from Arfrever Frehtes Taifersar Arahesis --- I use Qt from branch 5.12 from around time of 5.12.3, however it is unrelated. For testing, I have now installed Konsole 19.04.0 and this bug is not reproducible. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 --- Comment #2 from Christoph Feck --- I can confirm this, but I guessed this was caused by the Qt 5.12.3 update. Did you also update Qt? If not, it's really a Konsole regression. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering
https://bugs.kde.org/show_bug.cgi?id=406752 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #1 from Nate Graham --- Hmm, I'm not able to reproduce with git master. -- You are receiving this mail because: You are watching all bug changes.
