[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-03-07 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=432327

Kurt Hindenburg  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/34f85c
   ||ecea5010a5b8fa8c15020bf894f
   ||4d0bbcc
   Version Fixed In||21.04
 Resolution|--- |FIXED

--- Comment #8 from Kurt Hindenburg  ---
Git commit 34f85cecea5010a5b8fa8c15020bf894f4d0bbcc by Kurt Hindenburg, on
behalf of Carlos Alves.
Committed on 07/03/2021 at 20:50.
Pushed by hindenburg into branch 'master'.

Fix Bookmark all tabs as a folder crash

The list of active sessions needs to be refreshed when a session is
destroyed. It was being refreshed only on creation.
FIXED-IN: 21.04

M  +4-0src/ViewManager.cpp
M  +2-0src/widgets/ViewContainer.cpp
M  +3-0src/widgets/ViewContainer.h

https://invent.kde.org/utilities/konsole/commit/34f85cecea5010a5b8fa8c15020bf894f4d0bbcc

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-03-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=432327

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #7 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/361

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-03-04 Thread Jack Thomasson
https://bugs.kde.org/show_bug.cgi?id=432327

Jack Thomasson  changed:

   What|Removed |Added

 CC||j...@moonlitsw.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-03-04 Thread Jack Thomasson
https://bugs.kde.org/show_bug.cgi?id=432327

--- Comment #6 from Jack Thomasson  ---
Created attachment 136373
  --> https://bugs.kde.org/attachment.cgi?id=136373=edit
New crash information added by DrKonqi

konsole (20.12.2) using Qt 5.15.2

- What I was doing when the application crashed:

Bookmark Tabs as Folder after closing several tabs from another bookmark

-- Backtrace (Reduced):
#4  0x7fc0836db8ae in QIcon::name() const () from /lib64/libQt5Gui.so.5
#5  0x7fc08487cb8c in
Konsole::BookmarkHandler::iconForView(Konsole::ViewProperties*) const () from
/lib64/libkonsoleprivate.so.20
#6  0x7fc08487cd53 in Konsole::BookmarkHandler::currentBookmarkList() const
() from /lib64/libkonsoleprivate.so.20
#7  0x7fc082d5cdad in KBookmarkMenu::slotAddBookmarksList() () from
/lib64/libKF5Bookmarks.so.5
#8  0x7fc08325f386 in void doActivate(QObject*, int, void**) () from
/lib64/libQt5Core.so.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-02-08 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=432327

--- Comment #5 from Kurt Hindenburg  ---
The views are not removed when you close a session so when
BookmarkHandler::currentBookmarkList is called, it loops through removed
sessions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-02-08 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=432327

Kurt Hindenburg  changed:

   What|Removed |Added

 CC||tcanabr...@kde.org

--- Comment #4 from Kurt Hindenburg  ---
According to bit bisect (which is a pain to use w/ so many Qt/KF changes) it is

https://invent.kde.org/utilities/konsole/-/commit/6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432327] "Bookmark all tabs as folder" crashes if a tab was closed prior

2021-02-08 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=432327

Kurt Hindenburg  changed:

   What|Removed |Added

Summary|When I attempted to |"Bookmark all tabs as
   |bookmark all tabs as folder |folder" crashes if a tab
   |konsole crashed.|was closed prior

--- Comment #3 from Kurt Hindenburg  ---
It has nothing to do w/ ssh or # of tabs.

To reproduce:
1. start 2 tabs
2. close one tab
3. Bookmark->Bookmark tabs as folder

crash

-- 
You are receiving this mail because:
You are watching all bug changes.