[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Richard Ullger changed: What|Removed |Added CC|rull...@protonmail.com | -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Richard Ullger changed: What|Removed |Added CC||rull...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #11 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/457 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #10 from Ahmad Samir --- Git commit fb7f838fd3138a39aea3bcb2e91f923741587137 by Ahmad Samir. Committed on 13/08/2021 at 18:21. Pushed by ahmadsamir into branch 'cherry-pick-09035666'. Fix KXmlGUI toolbars; and Konsole MainWindow size Call setupGUI(), which will call createGUI (since we set the KXmlGuiWindow::Create flag), omit the StatusBar flag since we don't have a statusbar and don't want the "Show StatusBar" menu action. TabbedViewContainer::sizeHint() calculates an optimum size for itself, including the sizes of its child widgets; added in efb621d091c05f11 by Mariusz Glebocki; following the code: MainWindow creates a ViewManager ViewManager creates a TabbedViewContainer and then a TerminalDisplay which means that the first time TabbedViewContainer::sizeHint() is called the TerminalDisplay widget size is 0, then TabbedViewContainer::sizeHint() would return 0. Which is why calling resize() in MainWindow was delayed to the showEvent(), (and even delayed more by a QTimer::singleShot() call in Application), at which point all the child widgets have been created and MainWindow::sizeHint() (which logically takes into account the sizeHint() of its child widgets) would return a sensible size. Related: bug 436471, bug 430036 (cherry picked from commit 090356661c92bfedeeeaf6f4f77d294facb3d8c6) M +12 -5src/MainWindow.cpp https://invent.kde.org/utilities/konsole/commit/fb7f838fd3138a39aea3bcb2e91f923741587137 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #9 from Andrey --- Thanks! For some reason the patches were not marked as a fix? (I can't test it right now) -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #8 from Kurt Hindenburg --- Git commit 090356661c92bfedeeeaf6f4f77d294facb3d8c6 by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 02/08/2021 at 15:28. Pushed by hindenburg into branch 'master'. Fix KXmlGUI toolbars; and Konsole MainWindow size Call setupGUI(), which will call createGUI (since we set the KXmlGuiWindow::Create flag), omit the StatusBar flag since we don't have a statusbar and don't want the "Show StatusBar" menu action. TabbedViewContainer::sizeHint() calculates an optimum size for itself, including the sizes of its child widgets; added in efb621d091c05f11 by Mariusz Glebocki; following the code: MainWindow creates a ViewManager ViewManager creates a TabbedViewContainer and then a TerminalDisplay which means that the first time TabbedViewContainer::sizeHint() is called the TerminalDisplay widget size is 0, then TabbedViewContainer::sizeHint() would return 0. Which is why calling resize() in MainWindow was delayed to the showEvent(), (and even delayed more by a QTimer::singleShot() call in Application), at which point all the child widgets have been created and MainWindow::sizeHint() (which logically takes into account the sizeHint() of its child widgets) would return a sensible size. Related: bug 436471, bug 430036 M +12 -5src/MainWindow.cpp https://invent.kde.org/utilities/konsole/commit/090356661c92bfedeeeaf6f4f77d294facb3d8c6 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #7 from Ahmad Samir --- Please test https://invent.kde.org/utilities/konsole/-/merge_requests/447 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #6 from gr...@kde.org --- ## Neon user 20210725 - boot machine (in vbox, starts in 1024x768) - alt-space, "konsole", enter - konsole starts as 53x1 - resize konsole to 80x24, type "exit", enter - alt-space, "konsole", enter - konsole comes up in the just-used size - *Settings* > *Configure Konsole* > *General* tab > uncheck *Remember window size*, click *OK* - alt-space, "konsole", enter - comes up as 110x28 - resize to 80x31, type "exit", enter - alt-space, "konsole", enter - comes up as 110x28 (this is expected, because "remember" is unchecked) - *Settings* > *Edit current profile* (it says 110x28) - Change the window size to 80x31, click *Apply*, *OK* - close konsole and start it again .. comes up 110x28 - *Settings* > *Edit current profile* (it **still** says 110x28) - Click *Settings* > *Switch profile* and notice there are now *Default*, *Profile 1* and 3 times *Profile 2* in the menu - Restart konsole, now there's only 3 profiles in the menu Note that doing *Settings* > *Manage Profiles* shows the *Default* profile as "read-only", so it's not that surprising that it is not editable; setting a different profile as default makes konsole come up in the size entered there (e.g. 80x31). ## Neon unstable 20210725 konsole 21.07.70, frameworks 5.85.0 - konsole starts as 80x1 - resize, exit, restart: comes up in new size - Edit profile (remember, creates new profile 1, set it to 80x31; the default profile says 110x28) - Uncheck *Remember window size* - Start konsole (with the default profile), comes up 124x28 - Start konsole (with Profile 1), comes up 124x31 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Andrey changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED Keywords||regression Ever confirmed|0 |1 --- Comment #5 from Andrey --- Seems we regressed it - was able to reproduce on neon-unstable-20210725-0328.iso -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Andrey changed: What|Removed |Added CC||tum...@gmail.com --- Comment #4 from Andrey --- Tomaz, do you have an idea about the reason? Can it be because my Qt 5 is unpatched or something? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Andrey changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=437791 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Andrey changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Andrey --- Thanks. I've retested and still see the issue here on master: whatever Profile is set, I get 289 columns on start regardless what set in there: (127 in Profile1, 110 in Profiles 2 and 3). But row amount is honored. "Remember window size" is not set and last used size is not saved. BUT you gave me idea and I tried to reproduce it on Neon, and couldn't. Still Neon build doesn't include konsole sizing patch we've merged recently: https://bugs.kde.org/show_bug.cgi?id=437791 I'll wait until it get to Neon and retest. If still no go, probably it's signal that something broken in my build, maybe it's time to reinstall.. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 gr...@kde.org changed: What|Removed |Added CC||gr...@kde.org --- Comment #1 from gr...@kde.org --- Can't reproduce with: OS: FreeBSD 13 Plasma: 5.21.1 Frameworks: 5.82.0 Qt version: 5.15.2 Graphics: X11 I have my **default** profile (called "shell"; that's not the default konsole profile which is called "Default [read-only]") set to 81x44. *Remember window size* is off in *Settings* -> *Configure Konsole* -> *General*. On the other hand, if I turn **on** remember window size, then all my konsole windows are 43x1 rather than the "remembered" window size. That's a different issue, though. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 439339] Konsole window doesn't honor Initial terminal size columns setting
https://bugs.kde.org/show_bug.cgi?id=439339 Andrey changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=345403 -- You are receiving this mail because: You are watching all bug changes.
