[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 Nate Graham changed: What|Removed |Added Version Fixed In||22.04 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 tcanabr...@kde.org changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util |ities/konsole/-/merge_reque |ities/konsole/commit/29977a |sts/480/diffs?commit_id=d62 |23645e2401f9e108f06692176c7 |e9474e080821bf1e61b1d998085 |d7f8366 |22133fb8e0 | Status|CONFIRMED |RESOLVED --- Comment #7 from tcanabr...@kde.org --- Git commit 29977a23645e2401f9e108f06692176c7d7f8366 by Tomaz Canabrava, on behalf of Nathan Sprangers. Committed on 15/11/2021 at 14:02. Pushed by tcanabrava into branch 'master'. Disconnect view/session after drag-and-drop Adds a missing signal/slot connection for when a split-view is drag-and- dropped to a new window. Use an existing method to handle it the same way as drag-and-dropping or detaching a tab. M +12 -5src/ViewManager.cpp M +7-0src/ViewManager.h M +5-0src/session/SessionController.h M +1-1src/widgets/ViewContainer.cpp https://invent.kde.org/utilities/konsole/commit/29977a23645e2401f9e108f06692176c7d7f8366 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 nsprang...@gmail.com changed: What|Removed |Added Latest Commit||https://invent.kde.org/util ||ities/konsole/-/merge_reque ||sts/480/diffs?commit_id=d62 ||e9474e080821bf1e61b1d998085 ||22133fb8e0 --- Comment #6 from nsprang...@gmail.com --- Added a commit to MR 480 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 --- Comment #5 from nsprang...@gmail.com --- I was able trace it to this commit on 21.08 branch https://invent.kde.org/utilities/konsole/-/commit/58d526f83b924732b8c82306fcc177f0bbe63295 AFAICT the issue is that both ViewManagers are hanging onto the session after a dnd, so that commit is just causing both to hit empty() in sessionFinished (kind of expected I think, but I was able to verify it). I can see how ViewManager disconnects from sessions when *detaching* a view or tab, but I don't see how they are supposed to be released after drag-and-drop. Both the ViewSplitter and SessionController from the source window get deleted, so maybe there's a missing connection to one of those signals? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 --- Comment #4 from nsprang...@gmail.com --- Not on 21.08.1 Manjaro... -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 --- Comment #3 from Kurt Hindenburg --- I see the same issue on the 21.08 branch. Are you sure you don't see it there? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Kurt Hindenburg --- yep thanks confirmed on master - I'll have to check 21.08 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 442238] Closing a DnD'd view also closes the window it came from
https://bugs.kde.org/show_bug.cgi?id=442238 --- Comment #1 from nsprang...@gmail.com --- Also, not present on 21.08.1 -- You are receiving this mail because: You are watching all bug changes.
