[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 ninj...@gmail.com changed: What|Removed |Added Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util |ities/konsole/commit/d2ca20 |ities/konsole/commit/a6fce7 |2abd4e6b415a7647927db493337 |0f6c4e4d355c14475be8f5669a8 |092d5f3 |3c7023f --- Comment #7 from ninj...@gmail.com --- Git commit a6fce70f6c4e4d355c14475be8f5669a83c7023f by Luis Javier Merino Morán. Committed on 01/06/2022 at 22:16. Pushed by ahmadsamir into branch 'release/22.04'. Fix scroll position jumps regression Commit d37d3ac1 "CompactHistoryScroll: Remove _maxLineCount + 5 lines at a time" caused a regression: addHistLine queried the number of lines in history before and after adding a line, and if it had not incremented it assumed one line entered history and another was dropped at the other end. Now, lines are dropped from history in batches, so take care of that. Very similar to the regression fixed at 7a1e4768, only this one is about keeping the scroll position on the presence of scroll, and that other one is about keeping the selection. Thanks to the bug reporters Michael and Luke-Jr for the heads-up. Related: bug 452955 (cherry picked from commit d2ca202abd4e6b415a7647927db493337092d5f3) M +4-4src/Screen.cpp https://invent.kde.org/utilities/konsole/commit/a6fce70f6c4e4d355c14475be8f5669a83c7023f -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 --- Comment #6 from Luke-Jr --- (In reply to ninjalj from comment #5) > Git commit d2ca202abd4e6b415a7647927db493337092d5f3 by Luis Javier Merino > Morán. > Committed on 24/05/2022 at 10:51. Confirmed this seems to fix it (backported to 22.04.0) -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 ninj...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/util ||ities/konsole/commit/d2ca20 ||2abd4e6b415a7647927db493337 ||092d5f3 Status|REPORTED|RESOLVED --- Comment #5 from ninj...@gmail.com --- Git commit d2ca202abd4e6b415a7647927db493337092d5f3 by Luis Javier Merino Morán. Committed on 24/05/2022 at 10:51. Pushed by tcanabrava into branch 'master'. Fix scroll position jumps regression Commit d37d3ac1 "CompactHistoryScroll: Remove _maxLineCount + 5 lines at a time" caused a regression: addHistLine queried the number of lines in history before and after adding a line, and if it had not incremented it assumed one line entered history and another was dropped at the other end. Now, lines are dropped from history in batches, so take care of that. Very similar to the regression fixed at 7a1e4768, only this one is about keeping the scroll position on the presence of scroll, and that other one is about keeping the selection. Thanks to the bug reporters Michael and Luke-Jr for the heads-up. Related: bug 452955 M +6-4src/Screen.cpp https://invent.kde.org/utilities/konsole/commit/d2ca202abd4e6b415a7647927db493337092d5f3 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 --- Comment #4 from Michael --- Okay. Upon more careful examination, it turns out the !645 works if the output is spit out in separate lines, like `while true; do date; done` However, the reason I thought it didn't work, is because I was testing it with `cat /dev/urandom | base64`, which spits out one long noodle, and konsole I guess is linewrapping (?), and in that case the !645 doesn't work. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 --- Comment #3 from Ahmad Samir --- >From https://bugs.kde.org/show_bug.cgi?id=452955#c2: I tested !645 and it didn't help. It might be a duplicate, from just looking at it, but something else is going on. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com, ||ninj...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 --- Comment #2 from Ahmad Samir --- https://invent.kde.org/utilities/konsole/-/merge_requests/645 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 Ahmad Samir changed: What|Removed |Added CC||vor...@gmail.com --- Comment #1 from Ahmad Samir --- *** Bug 452955 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 453112] Fixed scroll position jumps around during non-visible output
https://bugs.kde.org/show_bug.cgi?id=453112 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
