[konsole] [Bug 474055] Partial selection of double width characters

2023-11-13 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=474055

ninj...@gmail.com changed:

   What|Removed |Added

 CC||ninj...@gmail.com
   Version Fixed In||v23.08.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 474055] Partial selection of double width characters

2023-10-04 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=474055

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/-/commit/8fc9
   ||24849a592c410f2fb519fe6ccba
   ||edb55517b

--- Comment #2 from Kurt Hindenburg  ---
Git commit 8fc924849a592c410f2fb519fe6ccbaedb55517b by Kurt Hindenburg, on
behalf of Luis Javier Merino MorĂ¡n.
Committed on 04/10/2023 at 15:45.
Pushed by hindenburg into branch 'master'.

Don't select half a CJK character

This was a visual regression.  Code using the selection already takes
care of dealing with CJK wide characters (mostly), and the old rendering
in TerminalPainter also did.  The new rendering is split in several
layers, which need to know about the selection to use the proper
background and foreground colors, but don't necessarily need to know
about characters, and this caused the regression.

To prevent trouble, we now take care of CJK wide characters before
rendering, when obtaining the characters from the model (Screen), where
characters are marked as selected if they fall into the selection
coordinates.

M  +21   -4src/Screen.cpp
M  +0-6src/terminalDisplay/TerminalPainter.cpp

https://invent.kde.org/utilities/konsole/-/commit/8fc924849a592c410f2fb519fe6ccbaedb55517b

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 474055] Partial selection of double width characters

2023-09-22 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=474055

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/897

-- 
You are receiving this mail because:
You are watching all bug changes.