[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-04-24 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=478181

Kurt Hindenburg  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/-/commit/5f1f
   ||d57b50e7e3899ba682c021697b6
   ||a61194f76
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #12 from Kurt Hindenburg  ---
Git commit 5f1fd57b50e7e3899ba682c021697b6a61194f76 by Kurt Hindenburg, on
behalf of Matan Ziv-Av.
Committed on 24/04/2024 at 22:56.
Pushed by hindenburg into branch 'master'.

Don't use Lam-Alef ligatures when shaping arabic letters

ICU automatically shapes the two letters Lam and Alef to a single ligature,
so it is necessary to undo it.

M  +48   -1src/terminalDisplay/TerminalDisplay.cpp

https://invent.kde.org/utilities/konsole/-/commit/5f1fd57b50e7e3899ba682c021697b6a61194f76

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-04-23 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=478181

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/989

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-04-02 Thread Mohammad K.
https://bugs.kde.org/show_bug.cgi?id=478181

--- Comment #10 from Mohammad K.  ---
(In reply to Matan Ziv-Av from comment #9)
> (In reply to Mohammad K. from comment #7)
> > (In reply to Matan Ziv-Av from comment #6)
> > > This is the result of using ICU for shaping Arabic letters. This library
> > > shapes Lam (0x0644) + Alef (0x627) into a Lam-Alef ligature (0xfefc) and a
> > > space.
> > > 
> > > I wrote some code to undo this ligature.
> > > 
> > > If you know how to compile konsole, please test one of the branches:
> > > https://invent.kde.org/matan/konsole/-/tree/local-qt5 (for qt5), or
> > > https://invent.kde.org/matan/konsole/-/tree/lamalef (for qt6).
> > 
> > Thanks! I just tested it and the issue looks be solved. 
> > The only problem is that, when a text contains Lam-Alef, emojis in that line
> > of text are messed (Seems to happen only in those lines). 
> > I'll Attach a video to show the test.
> 
> I think I fixed it now. Please try again.

I just tested it. It seems to working alright now! Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-04-01 Thread Matan Ziv-Av
https://bugs.kde.org/show_bug.cgi?id=478181

--- Comment #9 from Matan Ziv-Av  ---
(In reply to Mohammad K. from comment #7)
> (In reply to Matan Ziv-Av from comment #6)
> > This is the result of using ICU for shaping Arabic letters. This library
> > shapes Lam (0x0644) + Alef (0x627) into a Lam-Alef ligature (0xfefc) and a
> > space.
> > 
> > I wrote some code to undo this ligature.
> > 
> > If you know how to compile konsole, please test one of the branches:
> > https://invent.kde.org/matan/konsole/-/tree/local-qt5 (for qt5), or
> > https://invent.kde.org/matan/konsole/-/tree/lamalef (for qt6).
> 
> Thanks! I just tested it and the issue looks be solved. 
> The only problem is that, when a text contains Lam-Alef, emojis in that line
> of text are messed (Seems to happen only in those lines). 
> I'll Attach a video to show the test.

I think I fixed it now. Please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-03-30 Thread Mohammad K.
https://bugs.kde.org/show_bug.cgi?id=478181

--- Comment #8 from Mohammad K.  ---
Created attachment 167962
  --> https://bugs.kde.org/attachment.cgi?id=167962=edit
Test after Lam-Alef fix patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-03-30 Thread Mohammad K.
https://bugs.kde.org/show_bug.cgi?id=478181

--- Comment #7 from Mohammad K.  ---
(In reply to Matan Ziv-Av from comment #6)
> This is the result of using ICU for shaping Arabic letters. This library
> shapes Lam (0x0644) + Alef (0x627) into a Lam-Alef ligature (0xfefc) and a
> space.
> 
> I wrote some code to undo this ligature.
> 
> If you know how to compile konsole, please test one of the branches:
> https://invent.kde.org/matan/konsole/-/tree/local-qt5 (for qt5), or
> https://invent.kde.org/matan/konsole/-/tree/lamalef (for qt6).

Thanks! I just tested it and the issue looks be solved. 
The only problem is that, when a text contains Lam-Alef, emojis in that line of
text are messed (Seems to happen only in those lines). 
I'll Attach a video to show the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-03-30 Thread Matan Ziv-Av
https://bugs.kde.org/show_bug.cgi?id=478181

Matan Ziv-Av  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ma...@svgalib.org
 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #6 from Matan Ziv-Av  ---
This is the result of using ICU for shaping Arabic letters. This library shapes
Lam (0x0644) + Alef (0x627) into a Lam-Alef ligature (0xfefc) and a space.

I wrote some code to undo this ligature.

If you know how to compile konsole, please test one of the branches:
https://invent.kde.org/matan/konsole/-/tree/local-qt5 (for qt5), or
https://invent.kde.org/matan/konsole/-/tree/lamalef (for qt6).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2024-01-05 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=478181

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #5 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2023-12-21 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=478181

--- Comment #4 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2023-12-06 Thread Salem Yaslem
https://bugs.kde.org/show_bug.cgi?id=478181

Salem Yaslem  changed:

   What|Removed |Added

 CC||s...@sy.sa

--- Comment #3 from Salem Yaslem  ---
Created attachment 163964
  --> https://bugs.kde.org/attachment.cgi?id=163964=edit
Show the setting is enabled and have same issue

I'm facing same issue even that option is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2023-12-06 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=478181

ratijas  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #2 from ratijas  ---
Changing status of the bug report. (Bugzilla requires comment not be empty when
doing so, and I forgot to change it when posting the first one)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 478181] Problem in rendering a specific Farsi/Arabic character combination

2023-12-06 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=478181

ratijas  changed:

   What|Removed |Added

 CC||m...@ratijas.tk

--- Comment #1 from ratijas  ---
Created attachment 163959
  --> https://bugs.kde.org/attachment.cgi?id=163959=edit
where to enable the option

It works for me. Try enabling this option:

Edit current profile -> Appearance -> Complex Text Layout -> force LTR line
direction.

It should be ON by default. Did you turn it off accidentally or on purpose?

-- 
You are receiving this mail because:
You are watching all bug changes.