[kontact] [Bug 401337] Kmail crashes on hitting reply to email/new email

2018-11-30 Thread fhess
https://bugs.kde.org/show_bug.cgi?id=401337

--- Comment #8 from fhess  ---
Thanks for the quick fix and your hard work! 

Just updated to 

kmail (4:18.08.3+p18.04+git20181130.0018-0)

and can confirm problem is fixed (new and reply).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kontact] [Bug 401337] Kmail crashes on hitting reply to email/new email

2018-11-29 Thread Allen Winter
https://bugs.kde.org/show_bug.cgi?id=401337

Allen Winter  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/mes
   ||sagelib/32bbd45cdbbb8c60105
   ||ced80debab1eb6ed40226
   Version Fixed In||18.12.0
 Resolution|--- |FIXED

--- Comment #7 from Allen Winter  ---
Git commit 32bbd45cdbbb8c60105ced80debab1eb6ed40226 by Allen Winter.
Committed on 29/11/2018 at 14:21.
Pushed by winterz into branch 'Applications/18.12'.

templateparserextracthtmlinfo.cpp - deleteLater in dtor

ack'd by Laurent
FIXED-IN: 18.12.0

M  +2-2templateparser/src/templateparserextracthtmlinfo.cpp

https://commits.kde.org/messagelib/32bbd45cdbbb8c60105ced80debab1eb6ed40226

-- 
You are receiving this mail because:
You are watching all bug changes.

[kontact] [Bug 401337] Kmail crashes on hitting reply to email/new email

2018-11-29 Thread Allen Winter
https://bugs.kde.org/show_bug.cgi?id=401337

--- Comment #6 from Allen Winter  ---
right.  my hack was just desperation.
I tried the deleteLater() solution with Laurent's help and it seems to work
fine.
I will commit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kontact] [Bug 401337] Kmail crashes on hitting reply to email/new email

2018-11-28 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=401337

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org

--- Comment #5 from Laurent Montel  ---
(In reply to Allen Winter from comment #3)
> Here is my hack to get kmail working again (I doubt this is a kmail bug --
> more likely a QWebEngine bug).  Be warned: you will see memory leaks with
> this patch.
> 
> iff --git a/templateparser/src/templateparserextracthtmlinfo.cpp
> b/templateparser/src/templateparserextracthtmlinfo.cpp
> index 72dddbdc..2f7c59e8 100644
> --- a/templateparser/src/templateparserextracthtmlinfo.cpp
> +++ b/templateparser/src/templateparserextracthtmlinfo.cpp
> @@ -31,8 +31,8 @@
> TemplateParserExtractHtmlInfo::TemplateParserExtractHtmlInfo(QObject *parent)
>  
>  TemplateParserExtractHtmlInfo::~TemplateParserExtractHtmlInfo()
>  {
> -delete mTemplateWebEngineView;
> -delete mExtractHtmlElementWebEngineView;
> +//delete mTemplateWebEngineView;
> +//delete mExtractHtmlElementWebEngineView;
>  }
>  
>  void TemplateParserExtractHtmlInfo::setHtmlForExtractingTextPlain(const
> QString &html)

For sure a mem leak => it's not a good patch for source.
did you try a deleteLater() ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kontact] [Bug 401337] Kmail crashes on hitting reply to email/new email

2018-11-28 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=401337

l...@frankhess.de changed:

   What|Removed |Added

Summary|Kmail crashes on hitting|Kmail crashes on hitting
   |reply to email  |reply to email/new email

-- 
You are receiving this mail because:
You are watching all bug changes.