[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from Johannes Zarl-Zierl  ---
With commit 0088b7aa this situation should not occur again.

Unfortunately, there's not much we can do inside kphotoalbum to fix an
index.xml file that already contains invalid characters. But since the
workaround fixed your immediate problem, I'll close this bug anyways...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #10 from Johannes Zarl-Zierl  ---
Git commit 680499cfaafc8e57dfb38f2c0685f58ba0b1fc3f by Johannes Zarl-Zierl.
Committed on 02/01/2017 at 22:29.
Pushed by johanneszarl into branch '4.7'.

Prevent invalid characters in image description.

Some cameras seem to add invalid characters (i.e. control characters) to
the Exif.Image.ImageDescription. When the description is saved into the
database, we end up with an invalid index.xml file.
This patch removes control characters from the exif image description.

M  +4-1DB/FileInfo.cpp

https://commits.kde.org/kphotoalbum/680499cfaafc8e57dfb38f2c0685f58ba0b1fc3f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #9 from Johannes Zarl-Zierl  ---
Git commit 0088b7aa3a6b8824d23f68f0f821fe3d4a07a012 by Johannes Zarl-Zierl.
Committed on 02/01/2017 at 22:12.
Pushed by johanneszarl into branch 'master'.

Prevent invalid characters in image description.

Some cameras seem to add invalid characters (i.e. control characters) to
the Exif.Image.ImageDescription. When the description is saved into the
database, we end up with an invalid index.xml file.
This patch removes control characters from the exif image description.

M  +4-1DB/FileInfo.cpp

https://commits.kde.org/kphotoalbum/0088b7aa3a6b8824d23f68f0f821fe3d4a07a012

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Alex6 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #8 from Alex6  ---
Thanks! it works!

Not understood where te "WANGZ^B" comes from...
Not apparently from camera: the so tagged images were transformed from Nef
Nikon D80 with Gimp for 6/7 years and saved as xcf or jpg , Gimp ignored
metadata, related nef files in this index have no "WANGZ^B" tag...
Hav*e pasted this accidentally?*

Thanks again and happy Kpa + personal/private* 2017 !!

*My taylor is rich, but my english is poor.



Le lundi 2 janvier 2017 16:56:18 CET, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=374431
> 
> Johannes Zarl-Zierl  changed:
> 
>What|Removed |Added
> 
>  Ever confirmed|0   |1
>  Status|UNCONFIRMED |CONFIRMED
> 
> --- Comment #7 from Johannes Zarl-Zierl  ---
> Thanks.
> 
> The issue seems to be that your camera puts the string "WANGZ^B" into the EXIF
> description.
> 
> Between Qt4 and Qt5, the handling of control characters like '\x02' ('^B')
> seems to have changed, which causes KPhotoAlbum to choke on the previously
> working database.
> 
> As an immediate workaround you can remove the '^B' characters from your
> database:
> 
>  mv index.xml index.xml.bak
>  sed 's/\x02/#/' index.xml.bak > index.xml
> 
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #7 from Johannes Zarl-Zierl  ---
Thanks.

The issue seems to be that your camera puts the string "WANGZ^B" into the EXIF
description.

Between Qt4 and Qt5, the handling of control characters like '\x02' ('^B')
seems to have changed, which causes KPhotoAlbum to choke on the previously
working database.

As an immediate workaround you can remove the '^B' characters from your
database:

 mv index.xml index.xml.bak
 sed 's/\x02/#/' index.xml.bak > index.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-02 Thread Alex6 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #6 from Alex6  ---
*The problematic lines are annotations made with versions of kpa probably older
then 4.7.*
*The index.xml file is here:*

*https://framadrop.org/r/nRgCs1Ze21#mUK269XJhkYk7e5EpvClhL6CXz9spsmcoUOILg3DXhs=*


*Le dimanche 1 janvier 2017 22:10:45 CET, vous avez écrit :*
*> https://bugs.kde.org/show_bug.cgi?id=374431*
*> *
*> --- Comment #4 from Johannes Zarl-Zierl  ---*
*> The snippet of your index.xml looks ok. Is this snippet directly from KPA
4.7*
*> or after starting KPA 5.1?*
*> *
*> If possible, could you send me the problematic index.xml file via email?*
*> *
*> *

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-01 Thread Alex6 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #5 from Alex6  ---
The problematic lines are annotations made with versions of kpa probably older
then 4.7.
Attached the index.xml file.

Le dimanche 1 janvier 2017 22:10:45 CET, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=374431
> 
> --- Comment #4 from Johannes Zarl-Zierl  ---
> The snippet of your index.xml looks ok. Is this snippet directly from KPA 4.7
> or after starting KPA 5.1?
> 
> If possible, could you send me the problematic index.xml file via email?
> 
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-01 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #4 from Johannes Zarl-Zierl  ---
The snippet of your index.xml looks ok. Is this snippet directly from KPA 4.7
or after starting KPA 5.1?

If possible, could you send me the problematic index.xml file via email?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-01 Thread Alex6 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #3 from Alex6  ---
Tried to remove the "bad" image and regenerate the index with kpa 4.7.
kpa 5.1 crashes with same error on another line...

Le dimanche 1 janvier 2017 19:59:50 CET, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=374431
> 
> Johannes Zarl-Zierl  changed:
> 
>What|Removed |Added
> 
>  CC||johan...@zarl-zierl.at
> 
> --- Comment #1 from Johannes Zarl-Zierl  ---
> Can you post the offending line, plus a little of context of the "bad"
> index.xml file? If you use the commandline, "head -n 702 index.xml |tail"
> should be fine.
> 
> If there is sensitive information (e.g. names) in the output, you can replace
> it with '*' characters or similar...
> 
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-01 Thread Alex6 
https://bugs.kde.org/show_bug.cgi?id=374431

--- Comment #2 from Alex6  ---
Thanks for quick reply!

Here is:
*[ego@xyz Photos]$* head -n 702 index.xml |tail 
*[ego@xyz Photos]$* 




Le dimanche 1 janvier 2017 19:59:50 CET, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=374431
> 
> Johannes Zarl-Zierl  changed:
> 
>What|Removed |Added
> 
>  CC||johan...@zarl-zierl.at
> 
> --- Comment #1 from Johannes Zarl-Zierl  ---
> Can you post the offending line, plus a little of context of the "bad"
> index.xml file? If you use the commandline, "head -n 702 index.xml |tail"
> should be fine.
> 
> If there is sensitive information (e.g. names) in the output, you can replace
> it with '*' characters or similar...
> 
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 374431] Version 5.1 crashes when reading some index files

2017-01-01 Thread Johannes Zarl-Zierl 
https://bugs.kde.org/show_bug.cgi?id=374431

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 CC||johan...@zarl-zierl.at

--- Comment #1 from Johannes Zarl-Zierl  ---
Can you post the offending line, plus a little of context of the "bad"
index.xml file? If you use the commandline, "head -n 702 index.xml |tail"
should be fine.

If there is sensitive information (e.g. names) in the output, you can replace
it with '*' characters or similar...

-- 
You are receiving this mail because:
You are watching all bug changes.