[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-15 Thread Andreas Schleth
https://bugs.kde.org/show_bug.cgi?id=426538

--- Comment #7 from Andreas Schleth  ---
I can confirm that this fix solves this issue.
That was quick! Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=426538

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/kphotoalbum/commit/9bc
   ||2650cc565f4b3b376017b75ef8f
   ||23f841e0ec
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Johannes Zarl-Zierl  ---
Git commit 9bc2650cc565f4b3b376017b75ef8f23f841e0ec by Johannes Zarl-Zierl.
Committed on 14/09/2020 at 21:49.
Pushed by johanneszarl into branch 'master'.

DateBarWidget: fix assertion.

M  +1-1DateBar/DateBarWidget.cpp
M  +1-1DateBar/DateBarWidget.h

https://invent.kde.org/graphics/kphotoalbum/commit/9bc2650cc565f4b3b376017b75ef8f23f841e0ec

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=426538

--- Comment #5 from Johannes Zarl-Zierl  ---
I missed the assertion message in my first reading.
Yes, the assertion is incorrect - I'll push a fix asap...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=426538

--- Comment #4 from Tobias Leupold  ---
It's caused by the Q_ASSERT_X call. I think this won't show up if a release
build is done, only in debug mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=426538

--- Comment #3 from Tobias Leupold  ---
Johannes, could it be that the assert call is wrong?

I never worked on this class, but it seems that it compares the mouse cursor
position minus the left offset of the date bar with the segment width (which is
15 px in my case), thus almost always causing the assertion ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=426538

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 CC||johan...@zarl-zierl.at

--- Comment #2 from Johannes Zarl-Zierl  ---
I can't reproduce this here. Can someone post a stack trace?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 426538] current git master 5.7.0-13 crashes when clicking on the datebar below the histogram

2020-09-14 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=426538

Tobias Leupold  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||tobias.leup...@gmx.de
 Status|REPORTED|CONFIRMED

--- Comment #1 from Tobias Leupold  ---
I don't know yet what causes this, but I can confirm it.

-- 
You are receiving this mail because:
You are watching all bug changes.