[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-11 Thread Victor Lobo
https://bugs.kde.org/show_bug.cgi?id=476561

Victor Lobo  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Victor Lobo  ---
Fix works for me too. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-06 Thread Andreas Schleth
https://bugs.kde.org/show_bug.cgi?id=476561

--- Comment #5 from Andreas Schleth  ---
... with this version (v5.11.0-171-g314e3ca7) I see a different crash that
might be related. But I will post a different bug message:
https://bugs.kde.org/show_bug.cgi?id=476651

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-06 Thread Andreas Schleth
https://bugs.kde.org/show_bug.cgi?id=476561

--- Comment #4 from Andreas Schleth  ---
With v5.11.0-171-g314e3ca7  I do not see the crash anymore :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-05 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=476561

--- Comment #3 from Johannes Zarl-Zierl  ---
I'm not 100% sure that this does actually fix the bug in all instances, but it
does inhibit the issue of the AnnotationDialog being closed when the
Viewer->show context menu is activated.

You can e.g. still trigger the closing of the annotation dialog by changing the
visibility of a category - but this does not cause a crash. And since the stack
trace is mostly inside QtWidgets, I don't know what is causing the crash
exactly.

I'm still debating whether changing the visibility of the Category in the
viewer infobox actually needs to emit the signal that causes the annotation
dialog to close. If I change this detail, I'll CC this bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-05 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=476561

Johannes Zarl-Zierl  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/kphotoalbum/-/commit/0
   ||8a2bf1cbd23d48e199f924bf32b
   ||e128c12bd98b
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Johannes Zarl-Zierl  ---
Git commit 08a2bf1cbd23d48e199f924bf32be128c12bd98b by Johannes Zarl-Zierl.
Committed on 05/11/2023 at 22:57.
Pushed by johanneszarl into branch 'master'.

Don't emit Category::changed() when there's no change.

Emitting the changed() signal caused the
CategoryCollection::categoryCollectionChanged() signal when the Viewer
context menu "show" was activated, causing the AnnotationDialog being
closed if it was open at the time.

M  +17   -4DB/Category.cpp

https://invent.kde.org/graphics/kphotoalbum/-/commit/08a2bf1cbd23d48e199f924bf32be128c12bd98b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-05 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=476561

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 CC||johan...@zarl-zierl.at
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-05 Thread Andreas Schleth
https://bugs.kde.org/show_bug.cgi?id=476561

Andreas Schleth  changed:

   What|Removed |Added

 CC||schleth...@web.de

--- Comment #1 from Andreas Schleth  ---
same here:
openSuse Leap 15.5
KPA git master v5.11.0-166-g7c4b2886
KDE Frameworks 5.103.0
Qt 5.15.8
Plasma 5.27.4

Steps 3 and 4 can be in any order.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 476561] KPhotoAlbum crashes when changes in Annotation window are not saved and then user right clicks "Show" in Viewer window

2023-11-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=476561

Bug Janitor Service  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.