[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=343586

vanyossi  changed:

   What|Removed |Added

 CC||w...@ya.ru

--- Comment #12 from vanyossi  ---
*** Bug 413334 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=343586

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/9b45d78661e01f |krita/commit/8d032ed4bd01eb
   |54f5bd78ae2233407ee79d0ea3  |2a28eaff42c78ec2d56e36b850

--- Comment #11 from Boudewijn Rempt  ---
Git commit 8d032ed4bd01eb2a28eaff42c78ec2d56e36b850 by Boudewijn Rempt, on
behalf of Ivan Yossi.
Committed on 09/10/2019 at 08:40.
Pushed by rempt into branch 'krita/4.2'.

Fix Crop tool loosing aspect ratio on move

Previously there was no check for boundaries after the new
rect position is calculated. Before applying any offset on
move drag we check we no longer go ouside of the
image bounds. 

For aspect ratio we keep aspect ratio growing into the
image instead of outwards getting some weird behaviour
(cherry picked from commit 9b45d78661e01f54f5bd78ae2233407ee79d0ea3)

M  +22   -0plugins/tools/tool_crop/kis_constrained_rect.cpp

https://invent.kde.org/kde/krita/commit/8d032ed4bd01eb2a28eaff42c78ec2d56e36b850

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=343586

--- Comment #10 from Tyson Tan  ---
Thank you Vanyossi! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=343586

vanyossi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/9b45d78661e01f
   ||54f5bd78ae2233407ee79d0ea3
 Resolution|--- |FIXED

--- Comment #9 from vanyossi  ---
Git commit 9b45d78661e01f54f5bd78ae2233407ee79d0ea3 by Ivan Yossi.
Committed on 04/10/2019 at 16:25.
Pushed by ivany into branch 'master'.

Fix Crop tool loosing aspect ratio on move

Previously there was no check for boundaries after the new
rect position is calculated. Before applying any offset on
move drag we check we no longer go ouside of the
image bounds. 

For aspect ratio we keep aspect ratio growing into the
image instead of outwards getting some weird behaviour

M  +22   -0plugins/tools/tool_crop/kis_constrained_rect.cpp

https://invent.kde.org/kde/krita/commit/9b45d78661e01f54f5bd78ae2233407ee79d0ea3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=343586

--- Comment #8 from Boudewijn Rempt  ---
Anyone who builds krita themselves, please test
https://invent.kde.org/kde/krita/merge_requests/162

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[vanyossi]

https://bugs.kde.org/show_bug.cgi?id=343586

vanyossi  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |ghe...@gmail.com
 CC||ghe...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=343586

f...@imo.uto.moe changed:

   What|Removed |Added

 CC||f...@imo.uto.moe

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 343586] Crop Tool loses constant ratio after the handles touching canvas edges

[Dmitry Kazakov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343586

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||thinkinmon...@gmail.com

--- Comment #7 from Dmitry Kazakov  ---
*** Bug 69 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.