[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri |ta/ef43e85ef2815354e64c8358 |ta/c4740297fdf6ef5e5f8ea670 |3b4b734455d9d605|098d69b9aaf1cd0d --- Comment #11 from Boudewijn Rempt --- Git commit c4740297fdf6ef5e5f8ea670098d69b9aaf1cd0d by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 02/05/2018 at 11:54. Pushed by rempt into branch 'krita/4.0'. Implement double Esc key press shortcut for canceling continued transform mode Now if you start a continued transform mode in the transform tool, you have two options: 1) Press Esc key once to reset the transformation to non-transformed state 2) Press Esc key twice to cancel changing the continued transformation CC:kimages...@kde.org (cherry picked from commit 59ffe8bf10c618e35632b466a34578fee79ca78b) M +5-1plugins/tools/tool_transform2/kis_tool_transform.cc https://commits.kde.org/krita/c4740297fdf6ef5e5f8ea670098d69b9aaf1cd0d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit|http://commits.kde.org/krit |https://commits.kde.org/kri |a/d3d45eddadb480ceb9630e1e6 |ta/ef43e85ef2815354e64c8358 |e08d18799435453 |3b4b734455d9d605 --- Comment #10 from Dmitry Kazakov --- Git commit ef43e85ef2815354e64c83583b4b734455d9d605 by Dmitry Kazakov. Committed on 16/04/2018 at 13:40. Pushed by dkazakov into branch 'master'. Implement double Esc key press shortcut for canceling continued transform mode Now if you start a continued transform mode in the transform tool, you have two options: 1) Press Esc key once to reset the transformation to non-transformed state 2) Press Esc key twice to cancel changing the continued transformation CC:kimages...@kde.org M +5-1plugins/tools/tool_transform2/kis_tool_transform.cc https://commits.kde.org/krita/ef43e85ef2815354e64c83583b4b734455d9d605 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 --- Comment #9 from Raghavendra kamath --- Is this patch up in the master? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 --- Comment #8 from Raghavendra kamath --- The patch works as intended, thanks Dmitry -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 --- Comment #7 from Dmitry Kazakov --- Created attachment 110201 --> https://bugs.kde.org/attachment.cgi?id=110201&action=edit Proposed patch for transform cancellation with multiple Esc presses Please test this patch and say your opinion about the UIX -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 --- Comment #6 from Dmitry Kazakov --- Oh, it seems like the things are a bit more complicated. The current function of Escape button is "abandon the changes". That is recovers the content of the layer to the original state. And if I change it to handle resetting the transformations, it might become impossible to "undo and abandon all the changes"... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Dmitry Kazakov changed: What|Removed |Added Status|NEEDSINFO |REOPENED Resolution|WAITINGFORINFO |--- --- Comment #5 from Dmitry Kazakov --- We agreed on the following solution: 1) Single-press of Esc resets the state of the transform tool (equivalent of pressing "Reset" button) 2) If the state is already an identity state, the whole stroke is cancelled -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Status|REOPENED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #4 from Dmitry Kazakov --- Hi, Raghavendra! I've just retested the transform tool and I cannot understand what is wrong with the current version. The point is that "Esc" key does not reset the transformation in our UIX, but cancels the whole operation with hiding GUI controls. If you press "Reset" button explicitly, then the transformation correctly resets to Identity. If you do any meaningful change after that and apply the transform, the saved state will be saved as well. What exactly is wrong for you? How would you expect the UIX work? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Raghavendra kamath changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|FIXED |--- --- Comment #3 from Raghavendra kamath --- In 4.0 master this bug is somehow back. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 Dmitry Kazakov changed: What|Removed |Added Latest Commit||http://commits.kde.org/krit ||a/d3d45eddadb480ceb9630e1e6 ||e08d18799435453 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Dmitry Kazakov --- Git commit d3d45eddadb480ceb9630e1e6e08d18799435453 by Dmitry Kazakov. Committed on 25/04/2016 at 14:17. Pushed by dkazakov into branch 'master'. Add ability to reset the transformation frame even when it was loaded form the previous action Fixes T2326 M +14 -1plugins/tools/tool_transform2/kis_tool_transform.cc M +47 -0plugins/tools/tool_transform2/tool_transform_args.cc M +1-0plugins/tools/tool_transform2/tool_transform_args.h http://commits.kde.org/krita/d3d45eddadb480ceb9630e1e6e08d18799435453 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 361852] pressing "Esc" doesn't clear the earlier transform position (continuous transform)
https://bugs.kde.org/show_bug.cgi?id=361852 --- Comment #1 from Raghavendra kamath --- Created attachment 98418 --> https://bugs.kde.org/attachment.cgi?id=98418&action=edit transform clear demo video depicting the bug -- You are receiving this mail because: You are watching all bug changes.
