[krita] [Bug 376887] layer icon for "show in timeline"

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=376887

Emmet O'Neill  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/grap
   |krita/commit/b382c780fa7707 |hics/krita/commit/ed035fe1f
   |b45a2406e39714c9714ca65886  |ec634dd6a750d0b6dc934c6cade
   ||dee2
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Emmet O'Neill  ---
Git commit ed035fe1fec634dd6a750d0b6dc934c6cadedee2 by Emmet O'Neill.
Committed on 17/06/2020 at 02:38.
Pushed by emmetoneill into branch 'master'.

Added pushpin icon for pinned layers.

Now artists can easily see which of the layers on their timeline are
pinned and which are not.

M  +9-0libs/global/kis_global.h
M  +2-2plugins/dockers/animation/timeline_frames_model.cpp
M  +1-1plugins/dockers/animation/timeline_frames_model.h
M  +73   -32   plugins/dockers/animation/timeline_layers_header.cpp
M  +7-2plugins/dockers/animation/timeline_layers_header.h

https://invent.kde.org/graphics/krita/commit/ed035fe1fec634dd6a750d0b6dc934c6cadedee2

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=376887

Emmet O'Neill  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/b382c780fa7707
   ||b45a2406e39714c9714ca65886
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Emmet O'Neill  ---
Git commit b382c780fa7707b45a2406e39714c9714ca65886 by Emmet O'Neill.
Committed on 15/05/2020 at 23:07.
Pushed by emmetoneill into branch 'emmetpdx/T12769/aninext'.

Added pushpin icon for pinned layers.

Now artists can easily see which of the layers on their timeline are
pinned and which are not.

M  +9-0libs/global/kis_global.h
M  +2-2plugins/dockers/animation/timeline_frames_model.cpp
M  +1-1plugins/dockers/animation/timeline_frames_model.h
M  +73   -32   plugins/dockers/animation/timeline_layers_header.cpp
M  +7-2plugins/dockers/animation/timeline_layers_header.h

https://invent.kde.org/kde/krita/commit/b382c780fa7707b45a2406e39714c9714ca65886

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=376887

Emmet O'Neill  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=376887

Emmet O'Neill  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Tymond]

https://bugs.kde.org/show_bug.cgi?id=376887

Tymond  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Emmet O'Neill]

https://bugs.kde.org/show_bug.cgi?id=376887

Emmet O'Neill  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |emmetoneill@gmail.com
 CC||emmetoneill@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Ahab Greybeard]

https://bugs.kde.org/show_bug.cgi?id=376887

Ahab Greybeard  changed:

   What|Removed |Added

 CC||ahab.greybe...@hotmail.co.u
   ||k

--- Comment #4 from Ahab Greybeard  ---
At the moment, the lightbulb icon is used to indicate that a layer is animated
and it is not present if a layer is not animated. It is grey or black+lit to
show if onion skins are off or on.
This does not intrude for someone who isn't doing animations.
It does not indicate whether the layer is shown in the Timeline or not.

If the lightbulb  icon in the layers docker could be altered to indicate that
the layer was in the Timeline (or not), that would be useful. Maybe a cross
placed over it to indicate that it's not in the Timeline?

The Timeline docker controls for adding a layer are quite good but removing a
layer from the Timeline is clunky and the 'Remove layer' option does in fact
delete the layer from the image. https://bugs.kde.org/show_bug.cgi?id=407416

With many animated layers, it's important that the user has full and detailed
control over which layers are shown in the Timeline and that can be done at the
moment (but with clunky layer removal controls).

As an extra issue, an animated transparency mask does not have a lightbulb
icon. You can't have an animated transparency mask unless its parent layer is
animated but you can have an animated transparency mask alone in the Timeline
(with no lightbulb icon displayed).
I deal with this by giving them a name "Animask 'parent name'" so I know what's
happening.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Scott Petrovic]

https://bugs.kde.org/show_bug.cgi?id=376887

Scott Petrovic  changed:

   What|Removed |Added

 CC||scottpetro...@gmail.com

--- Comment #3 from Scott Petrovic  ---
I personally would not want this. A lot of artists that use krita have no
desire to animate. This just adds extra UI clutter that a lot of people will
have to ignore.

I think if we do anything...we need to think about the workflow for animators
and how they do the "show on timeline" in general. A better option might be to
have a toggle to make all layers show in the timeline.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Bollebib]

https://bugs.kde.org/show_bug.cgi?id=376887

Bollebib  changed:

   What|Removed |Added

 CC||kwadraatn...@hotmail.com

--- Comment #2 from Bollebib  ---
you can see it tho by looking at the layers with a lightbulb



maybe the lightbulb will need a different placmentfor easier parsing
or maybe the color filter needs extra option like hiding all non-animation
layers or vice versa?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376887] layer icon for "show in timeline"

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=376887

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 OS|Windows CE  |All
 Status|UNCONFIRMED |CONFIRMED
   Severity|normal  |wishlist
 CC||b...@valdyas.org

--- Comment #1 from Boudewijn Rempt  ---
I guess we could do this, though the layerbox is already overcrowded and making
the icon take place even if the document doesn't have animation would be bad;
not doing that would be a bit complicated.

-- 
You are receiving this mail because:
You are watching all bug changes.