[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #12 from Dmitry Kazakov  ---
Git commit 7b7ca7efadbd17cfaf3f5cdbd6526c4ae8ec7018 by Dmitry Kazakov.
Committed on 12/04/2017 at 19:50.
Pushed by dkazakov into branch 'master'.

Add a warning dialog that the user is saving possibly corrupted image
Related: bug 361883

M  +12   -1libs/ui/KisMainWindow.cpp
M  +6-1libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +7-0libs/ui/dialogs/kis_delayed_save_dialog.h

https://commits.kde.org/krita/7b7ca7efadbd17cfaf3f5cdbd6526c4ae8ec7018

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #11 from Dmitry Kazakov  ---
Git commit d71f0019e01266bd6b77638fcc37007937b40474 by Dmitry Kazakov.
Committed on 12/04/2017 at 15:20.
Pushed by dkazakov into branch 'krita/3.1'.

Add a warning dialog that the user is saving possibly corrupted image
Related: bug 361883

M  +12   -1libs/ui/KisMainWindow.cpp
M  +6-1libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +7-0libs/ui/dialogs/kis_delayed_save_dialog.h

https://commits.kde.org/krita/d71f0019e01266bd6b77638fcc37007937b40474

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #10 from Dmitry Kazakov  ---
Git commit af9a7841964830f8752e1887d9d5b79658ade4ce by Dmitry Kazakov.
Committed on 12/04/2017 at 15:20.
Pushed by dkazakov into branch 'krita/3.1'.

Lock the image while saving

It is not enough to just disable cloning of the image,
locking should also be recovered.
Related: bug 361883

M  +55   -52   libs/ui/KisDocument.cpp

https://commits.kde.org/krita/af9a7841964830f8752e1887d9d5b79658ade4ce

--- Comment #11 from Dmitry Kazakov  ---
Git commit d71f0019e01266bd6b77638fcc37007937b40474 by Dmitry Kazakov.
Committed on 12/04/2017 at 15:20.
Pushed by dkazakov into branch 'krita/3.1'.

Add a warning dialog that the user is saving possibly corrupted image
Related: bug 361883

M  +12   -1libs/ui/KisMainWindow.cpp
M  +6-1libs/ui/dialogs/kis_delayed_save_dialog.cpp
M  +7-0libs/ui/dialogs/kis_delayed_save_dialog.h

https://commits.kde.org/krita/d71f0019e01266bd6b77638fcc37007937b40474

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #10 from Dmitry Kazakov  ---
Git commit af9a7841964830f8752e1887d9d5b79658ade4ce by Dmitry Kazakov.
Committed on 12/04/2017 at 15:20.
Pushed by dkazakov into branch 'krita/3.1'.

Lock the image while saving

It is not enough to just disable cloning of the image,
locking should also be recovered.
Related: bug 361883

M  +55   -52   libs/ui/KisDocument.cpp

https://commits.kde.org/krita/af9a7841964830f8752e1887d9d5b79658ade4ce

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #9 from Tyson Tan  ---
Hi Dmitry,

No, Krita did not popup any dialogue. Saving was done without interruption. In
fact, there were 3 documents opened simultaneously, only this one got resized.
All of them had the exact same size: A4 300dpi, vertical. The only difference
being the affected one had 2 line art layers (3 in total), while the other 2
had 1 line art layer (2 in total).

BTW I received the postcards. They were beautifully printed. Thank you! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #8 from Dmitry Kazakov  ---
And did it show you "Save without Waiting" dialog?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #7 from Dmitry Kazakov  ---
Hi, Tyson!

Is it possible to get a terminal output of Krita, when it generated this wrong
file? Were there any messages like "Could not lock the document for saving"?

If my hypothesis is correct, then Krita should have warned you about the
problem with locking...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=378681

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Boudewijn Rempt  ---


*** This bug has been marked as a duplicate of bug 361883 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=378681

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||b...@valdyas.org

--- Comment #5 from Boudewijn Rempt  ---
I suspect that it would also have happened in 3.1.3-alpha, and that Krita is
saving the wrong LOD plane.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #4 from Tyson Tan  ---
Correction: This probably only happened with Krita 3.1.3 beta (appimage)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #3 from Tyson Tan  ---
Attachment correction:

attachment 104978 is the 1/16 one because it got 1/4 twice.

attachment 104979 is the backup file of attachment 104978 so it is 1/4 of the
original size. And because of it is being a backup, it doesn't have that extra
layer.

attachment 104978's 2 layers are not aligned, but they were aligned in the
original version.

The now missing original version have the layers fill the canvas.

I was editing 3 documents, all of them were saved multiple times in the same
session. But only this one was affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #2 from Tyson Tan  ---
Created attachment 104979
  --> https://bugs.kde.org/attachment.cgi?id=104979=edit
Second unwated resized layer save

After restarting Krita, I opened the 1/4 version and resaved once, now it
became 1/4 of the 1/4, 1/16 of the original size.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378681] Krita occasionally save documents with resized layers

[Tyson Tan]

https://bugs.kde.org/show_bug.cgi?id=378681

--- Comment #1 from Tyson Tan  ---
Created attachment 104978
  --> https://bugs.kde.org/attachment.cgi?id=104978=edit
First unwanted layer resize save, 1/4 size of original

The line art layer became 1/4 of the original size.

-- 
You are receiving this mail because:
You are watching all bug changes.