[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=388237

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/8c224215e9b9fd |krita/commit/2382b7cc77478e
   |c3d0cc3cf45c044d1b0863be67  |1765b3dfac6c894731f444ee60

--- Comment #9 from Dmitry Kazakov  ---
Git commit 2382b7cc77478e1765b3dfac6c894731f444ee60 by Dmitry Kazakov.
Committed on 23/04/2020 at 09:58.
Pushed by dkazakov into branch 'master'.

Add an option do disable smearing of alpha channel in Colorsmudge Paintop

M  +1-1plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M  +12   -0plugins/paintops/colorsmudge/kis_smudge_option.cpp
M  +4-0plugins/paintops/colorsmudge/kis_smudge_option.h
M  +18   -4plugins/paintops/colorsmudge/kis_smudge_option_widget.cpp
M  +3-0plugins/paintops/colorsmudge/kis_smudge_option_widget.h

https://invent.kde.org/kde/krita/commit/2382b7cc77478e1765b3dfac6c894731f444ee60

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=388237

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/8c224215e9b9fd
   ||c3d0cc3cf45c044d1b0863be67
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #8 from Dmitry Kazakov  ---
Git commit 8c224215e9b9fdc3d0cc3cf45c044d1b0863be67 by Dmitry Kazakov.
Committed on 23/04/2020 at 09:56.
Pushed by dkazakov into branch 'krita/4.3'.

Add an option do disable smearing of alpha channel in Colorsmudge Paintop

M  +1-1plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M  +12   -0plugins/paintops/colorsmudge/kis_smudge_option.cpp
M  +4-0plugins/paintops/colorsmudge/kis_smudge_option.h
M  +18   -4plugins/paintops/colorsmudge/kis_smudge_option_widget.cpp
M  +3-0plugins/paintops/colorsmudge/kis_smudge_option_widget.h

https://invent.kde.org/kde/krita/commit/8c224215e9b9fdc3d0cc3cf45c044d1b0863be67

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388237

--- Comment #7 from reptilli...@live.com ---
(In reply to Storm Engineer from comment #6)
> Makes sense that the brush shouldn't "remove paint" from where there already
> is some. Right now it treats opacity as the same as color and mixes it, it
> should only mix the color.

I don't think the smudge engine should be rewritten to support this task
(There's a lot of people where smudging alpha information is actually
beneficial for them), but it would be nice to add an additional option where
instead of keeping alpha information intact, it should increase opacity, and
emulate actual real-world material.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[Storm Engineer]

https://bugs.kde.org/show_bug.cgi?id=388237

--- Comment #6 from Storm Engineer  ---
(In reply to wolthera from comment #5)
> wy not toggle the "preserve alpha" between the eraser and the reload buttons
> in the tool bar when you need to do this thing?

That's not the same, as that stops you from painting over alpha entirely. The
idea would be (in my interpretation at least) that you can paint over alpha to
increase opacity, but not decrease it.

Makes sense that the brush shouldn't "remove paint" from where there already is
some. Right now it treats opacity as the same as color and mixes it, it should
only mix the color.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=388237

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com

--- Comment #5 from wolthera  ---
wy not toggle the "preserve alpha" between the eraser and the reload buttons in
the tool bar when you need to do this thing?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[Storm Engineer]

https://bugs.kde.org/show_bug.cgi?id=388237

--- Comment #4 from Storm Engineer  ---
I totally agree.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388237

--- Comment #3 from reptilli...@live.com ---
I would suggest made optional because there are Krita users who are ok with the
current behavior. More flexibility, the better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[Storm Engineer]

https://bugs.kde.org/show_bug.cgi?id=388237

Storm Engineer  changed:

   What|Removed |Added

 CC||storm.ant...@gmail.com

--- Comment #2 from Storm Engineer  ---
I agree. It gets really annoying when I paint around edges and the empty part
of the layer is smudged into parts with actual content, causing a mess of
transparency.

This also isn't consistent with how it behaves if you paint over edges created
by neighboring colors rather than color neighboring empty area.

While I see this behavior may be desirable in special cases, I believe it's not
the normal use case, and so it should be either eliminated or made optional.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 388237] Add "Ignore Alpha" to Smudge Brush or "preserve existing alpha"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388237

--- Comment #1 from reptilli...@live.com ---
Also, I forgot to add, I noticed that smudging does not build up alpha value as
much as what would be seen on traditional media. A option to increase alpha
build-up would be greatly appreciated by those who wants more traditional media
approach.

-- 
You are receiving this mail because:
You are watching all bug changes.