[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[Douglas]

https://bugs.kde.org/show_bug.cgi?id=391553

Douglas  changed:

   What|Removed |Added

 CC||magick.c...@gmail.com

--- Comment #6 from Douglas  ---
Wolthera, if you need something tested, please come to the Facebook Krita Group
and ask there. I am sure you would get a lot of people willing to help you out
with testing, especially since this request started there (on at least was
talked about there, by David Revoy.) I do mean anything tested not just this
patch.
Douglas E Knapp

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=391553

wolthera  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from wolthera  ---
Pushed results here:
https://phabricator.kde.org/R37:c97a387a4f7ab40d9fbd85a16d75717263eeb1d4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391553

--- Comment #4 from Boudewijn Rempt  ---
Created attachment 111275
  --> https://bugs.kde.org/attachment.cgi?id=111275=edit
Updated diff

This is an updated diff that correctly initializes the transform to 0 so
there's no crash when selecting a smudge brush. I'm not sure how to test the
patch further, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391553

--- Comment #3 from Boudewijn Rempt  ---
When you say crashes, have you found more than one way to get a crash? I get
one immediately when I select a smudge brush. Is that the one you mean?

[KCrash Handler]
#6  0x7fe6e8c32b66 in KisColorSmudgeOp::~KisColorSmudgeOp
(this=0x7fe64c003890, __in_chrg=) at
/home/boud/dev/krita/plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp:117
#7  0x7fe6e8c32d89 in KisColorSmudgeOp::~KisColorSmudgeOp
(this=0x7fe64c003890, __in_chrg=) at
/home/boud/dev/krita/plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp:118
#8  0x7fe711a8e40d in KisPainter::~KisPainter (this=0xdcf6940,
__in_chrg=) at
/home/boud/dev/krita/libs/image/kis_painter.cc:127
#9  0x7fe711a8e579 in KisPainter::~KisPainter (this=0xdcf6940,
__in_chrg=) at
/home/boud/dev/krita/libs/image/kis_painter.cc:131
#10 0x7fe712f1aad3 in KisFreehandStrokeInfo::~KisFreehandStrokeInfo
(this=0xdd268c0, __in_chrg=) at
/home/boud/dev/krita/libs/ui/tool/strokes/KisFreehandStrokeInfo.cpp:55
#11 0x7fe712f180a0 in KisPainterBasedStrokeStrategy::deletePainters
(this=this@entry=0xdd2f980) at
/home/boud/dev/krita/libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp:210
#12 0x7fe712f1872a in KisPainterBasedStrokeStrategy::finishStrokeCallback
(this=0xdd2f980) at
/home/boud/dev/krita/libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp:341
#13 0x7fe711c8c6b4 in KisUpdateJobItem::run (this=0x927a3a0) at
/home/boud/dev/b-krita/libs/image/../../../krita/libs/image/kis_update_job_item.h:90
#14 0x7fe708b30172 in QThreadPoolThread::run (this=0xdd2fdc0) at
thread/qthreadpool.cpp:101
#15 0x7fe708b32e0f in QThreadPrivate::start (arg=0xdd2fdc0) at
thread/qthread_unix.cpp:376
#16 0x7fe706f34724 in start_thread () from /lib64/libpthread.so.0
#17 0x7fe707f24c1d in clone () from /lib64/libc.so.6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=391553

wolthera  changed:

   What|Removed |Added

 Attachment #111258|0   |1
is obsolete||

--- Comment #2 from wolthera  ---
Created attachment 111259
  --> https://bugs.kde.org/attachment.cgi?id=111259=edit
Correct patch.

Whoops, that one was the old one for the regular pixel brush. >_>

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[wolthera]

https://bugs.kde.org/show_bug.cgi?id=391553

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com

--- Comment #1 from wolthera  ---
Created attachment 111258
  --> https://bugs.kde.org/attachment.cgi?id=111258=edit
Diff with attempt.

So, I attempted this, but the problem is that for some reason the transform
doesn't get deleted properly, leading to crashes. Someone with more knowledge
of the brush engines might pick this up, I guess.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391553] [wish] [Color-Smudge-Brush] new slider: color variation

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391553

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.