[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kri
   ||ta/e9b0661657f67ac4d1186641
   ||a78357f695a9a717
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Boudewijn Rempt  ---
Git commit e9b0661657f67ac4d1186641a78357f695a9a717 by Boudewijn Rempt.
Committed on 14/03/2018 at 13:24.
Pushed by rempt into branch 'master'.

Create actions per-window instead of per-application

Note that this changes the libkis scripting api. The Extension
class now has two methods: setup and createActions. Old code
was like this:

from PyQt5.QtGui import *
from PyQt5.QtWidgets import *
from krita import *

def hello():
QMessageBox.information(QWidget(), "Test", "Hello World")

class HelloExtension(Extension):

  def __init__(self, parent):
  super().__init__(parent)

  def setup(self):
  action = Krita.createAction("Hello")
  action.triggered.connect(hello)

Krita.instance().addExtension(HelloExtension(Krita.instance()))

New code is like this:

from PyQt5.QtGui import *
from PyQt5.QtWidgets import *
from krita import *

def hello():
QMessageBox.information(QWidget(), "Test", "Hello World")

class HelloExtension(Extension):

  def __init__(self, parent):
  super().__init__(parent)

  def setup(self):
  pass

  def createActions(self, window):
  action = window.createAction("Hello")
  action.triggered.connect(hello)

Krita.instance().addExtension(HelloExtension(Krita.instance()))

This also adds a new parameter to createAction: the menu location. This
is a path separated by /, for instance tools/scripts. Note that this
path must exist, otherwise a crash will happen. The paths are defined in
krita4.xmlgui...

Note: we're still leaking Action objects created in Window::createAction;
that's the next fix.

CCMAIL:kimages...@kde.org

M  +1-1krita/krita4.xmlgui
M  +0-11   libs/libkis/Action.cpp
M  +0-12   libs/libkis/Action.h
M  +22   -14   libs/libkis/Extension.h
M  +10   -20   libs/libkis/Krita.cpp
M  +4-10   libs/libkis/Krita.h
M  +5-2libs/libkis/Mainpage.dox
M  +35   -1libs/libkis/Window.cpp
M  +17   -0libs/libkis/Window.h
M  +0-1libs/ui/CMakeLists.txt
M  +0-11   libs/ui/KisPart.cpp
M  +0-11   libs/ui/KisPart.h
M  +0-10   libs/ui/KisViewManager.cpp
M  +0-3libs/ui/KisViewManager.h
D  +0-90   libs/ui/kis_script_manager.cpp
D  +0-52   libs/ui/kis_script_manager.h
M  +2-2plugins/extensions/pykrita/plugin/plugin.cpp
M  +1-2plugins/extensions/pykrita/sip/krita/Action.sip
M  +1-0plugins/extensions/pykrita/sip/krita/Extension.sip
M  +0-1plugins/extensions/pykrita/sip/krita/Krita.sip
M  +1-0plugins/extensions/pykrita/sip/krita/Window.sip
M  +4-1plugins/python/assignprofiledialog/assignprofiledialog.py
M  +4-1plugins/python/colorspace/colorspace.py
M  +4-1plugins/python/documenttools/documenttools.py
M  +4-1plugins/python/exportlayers/exportlayers.py
M  +4-1plugins/python/filtermanager/filtermanager.py
M  +4-2plugins/python/hello/hello.py
M  +4-1plugins/python/highpass/highpass.py
M  +4-1plugins/python/scripter/scripter.py
M  +7-9plugins/python/tenbrushes/tenbrushes.py
M  +7-7plugins/python/tenscripts/tenscripts.py

https://commits.kde.org/krita/e9b0661657f67ac4d1186641a78357f695a9a717

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/e9b0661657f67ac4d1186641 |ta/3de294bc464390acc33be19a
   |a78357f695a9a717|a89a74ebfb18963e

--- Comment #10 from Boudewijn Rempt  ---
Git commit 3de294bc464390acc33be19aa89a74ebfb18963e by Boudewijn Rempt.
Committed on 14/03/2018 at 13:24.
Pushed by rempt into branch 'krita/4.0'.

Create actions per-window instead of per-application

Note that this changes the libkis scripting api. The Extension
class now has two methods: setup and createActions. Old code
was like this:

from PyQt5.QtGui import *
from PyQt5.QtWidgets import *
from krita import *

def hello():
QMessageBox.information(QWidget(), "Test", "Hello World")

class HelloExtension(Extension):

  def __init__(self, parent):
  super().__init__(parent)

  def setup(self):
  action = Krita.createAction("Hello")
  action.triggered.connect(hello)

Krita.instance().addExtension(HelloExtension(Krita.instance()))

New code is like this:

from PyQt5.QtGui import *
from PyQt5.QtWidgets import *
from krita import *

def hello():
QMessageBox.information(QWidget(), "Test", "Hello World")

class HelloExtension(Extension):

  def __init__(self, parent):
  super().__init__(parent)

  def setup(self):
  pass

  def createActions(self, window):
  action = window.createAction("Hello")
  action.triggered.connect(hello)

Krita.instance().addExtension(HelloExtension(Krita.instance()))

This also adds a new parameter to createAction: the menu location. This
is a path separated by /, for instance tools/scripts. Note that this
path must exist, otherwise a crash will happen. The paths are defined in
krita4.xmlgui...

Note: we're still leaking Action objects created in Window::createAction;
that's the next fix.

CCMAIL:kimages...@kde.org
(cherry picked from commit e9b0661657f67ac4d1186641a78357f695a9a717)

M  +1-1krita/krita4.xmlgui
M  +0-11   libs/libkis/Action.cpp
M  +0-12   libs/libkis/Action.h
M  +22   -14   libs/libkis/Extension.h
M  +10   -20   libs/libkis/Krita.cpp
M  +4-10   libs/libkis/Krita.h
M  +5-2libs/libkis/Mainpage.dox
M  +35   -1libs/libkis/Window.cpp
M  +17   -0libs/libkis/Window.h
M  +0-1libs/ui/CMakeLists.txt
M  +0-11   libs/ui/KisPart.cpp
M  +0-11   libs/ui/KisPart.h
M  +0-10   libs/ui/KisViewManager.cpp
M  +0-3libs/ui/KisViewManager.h
D  +0-90   libs/ui/kis_script_manager.cpp
D  +0-52   libs/ui/kis_script_manager.h
M  +2-2plugins/extensions/pykrita/plugin/plugin.cpp
M  +1-2plugins/extensions/pykrita/sip/krita/Action.sip
M  +1-0plugins/extensions/pykrita/sip/krita/Extension.sip
M  +0-1plugins/extensions/pykrita/sip/krita/Krita.sip
M  +1-0plugins/extensions/pykrita/sip/krita/Window.sip
M  +4-1plugins/python/assignprofiledialog/assignprofiledialog.py
M  +4-1plugins/python/colorspace/colorspace.py
M  +4-1plugins/python/documenttools/documenttools.py
M  +4-1plugins/python/exportlayers/exportlayers.py
M  +4-1plugins/python/filtermanager/filtermanager.py
M  +4-2plugins/python/hello/hello.py
M  +4-1plugins/python/highpass/highpass.py
M  +4-1plugins/python/scripter/scripter.py
M  +7-9plugins/python/tenbrushes/tenbrushes.py
M  +7-7plugins/python/tenscripts/tenscripts.py

https://commits.kde.org/krita/3de294bc464390acc33be19aa89a74ebfb18963e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

--- Comment #8 from Boudewijn Rempt  ---
Git commit a59e3f6b8fd93827cafdb455ee5fe2e08fef7516 by Boudewijn Rempt.
Committed on 14/03/2018 at 09:56.
Pushed by rempt into branch 'krita/4.0'.

Rename KisViewPlugin to KisActionPlugin

These plugins are not created per-view, but per-mainwindow, and exist
so every main window can have its own actions, so this makes the naming
more clear.
(cherry picked from commit e443dc644943b76ebc7f8d8060d626c435409ace)

M  +1-1libs/ui/CMakeLists.txt
R  +7-7libs/ui/KisActionPlugin.cpp [from: libs/ui/kis_view_plugin.cpp -
078% similarity]
R  +4-4libs/ui/KisActionPlugin.h [from: libs/ui/kis_view_plugin.h -
087% similarity]
M  +1-1plugins/dockers/throttle/ThrottlePlugin.h
M  +1-1plugins/extensions/animationrenderer/AnimationRenderer.cpp
M  +2-2plugins/extensions/animationrenderer/AnimationRenderer.h
M  +1-1plugins/extensions/bigbrother/bigbrother.cc
M  +2-2plugins/extensions/bigbrother/bigbrother.h
M  +1-1plugins/extensions/buginfo/buginfo.cpp
M  +2-2plugins/extensions/buginfo/buginfo.h
M  +1-1plugins/extensions/clonesarray/clonesarray.cpp
M  +2-2plugins/extensions/clonesarray/clonesarray.h
M  +1-1plugins/extensions/colorrange/colorrange.cc
M  +2-2plugins/extensions/colorrange/colorrange.h
M  +1-1plugins/extensions/colorspaceconversion/colorspaceconversion.cc
M  +2-2plugins/extensions/colorspaceconversion/colorspaceconversion.h
M  +1-1plugins/extensions/histogram/histogram.cc
M  +2-2plugins/extensions/histogram/histogram.h
M  +1-1plugins/extensions/imagesize/imagesize.cc
M  +2-2plugins/extensions/imagesize/imagesize.h
M  +1-1plugins/extensions/imagesplit/imagesplit.cpp
M  +2-2plugins/extensions/imagesplit/imagesplit.h
M  +1-1plugins/extensions/layergroupswitcher/layergroupswitcher.cpp
M  +2-2plugins/extensions/layergroupswitcher/layergroupswitcher.h
M  +1-1plugins/extensions/layersplit/layersplit.cpp
M  +2-2plugins/extensions/layersplit/layersplit.h
M  +1-1plugins/extensions/metadataeditor/metadataeditor.cc
M  +2-2plugins/extensions/metadataeditor/metadataeditor.h
M  +1-1plugins/extensions/modify_selection/modify_selection.cc
M  +2-2plugins/extensions/modify_selection/modify_selection.h
M  +1-1plugins/extensions/offsetimage/offsetimage.cpp
M  +2-2plugins/extensions/offsetimage/offsetimage.h
M  +1-1plugins/extensions/pykrita/plugin/plugin.cpp
M  +2-2plugins/extensions/pykrita/plugin/plugin.h
M  +1-1plugins/extensions/qmic/QMic.cpp
M  +2-2plugins/extensions/qmic/QMic.h
M  +1-1plugins/extensions/resourcemanager/resourcemanager.cpp
M  +2-2plugins/extensions/resourcemanager/resourcemanager.h
M  +1-1plugins/extensions/rotateimage/rotateimage.cc
M  +2-2plugins/extensions/rotateimage/rotateimage.h
M  +1-1   
plugins/extensions/separate_channels/kis_separate_channels_plugin.cc
M  +2-2   
plugins/extensions/separate_channels/kis_separate_channels_plugin.h
M  +1-1plugins/extensions/shearimage/shearimage.cc
M  +2-2plugins/extensions/shearimage/shearimage.h
M  +1-1plugins/extensions/waveletdecompose/waveletdecompose.cpp
M  +2-2plugins/extensions/waveletdecompose/waveletdecompose.h

https://commits.kde.org/krita/a59e3f6b8fd93827cafdb455ee5fe2e08fef7516

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

--- Comment #7 from Boudewijn Rempt  ---
Git commit e443dc644943b76ebc7f8d8060d626c435409ace by Boudewijn Rempt.
Committed on 14/03/2018 at 09:55.
Pushed by rempt into branch 'master'.

Rename KisViewPlugin to KisActionPlugin

These plugins are not created per-view, but per-mainwindow, and exist
so every main window can have its own actions, so this makes the naming
more clear.

M  +1-1libs/ui/CMakeLists.txt
R  +7-7libs/ui/KisActionPlugin.cpp [from: libs/ui/kis_view_plugin.cpp -
078% similarity]
R  +4-4libs/ui/KisActionPlugin.h [from: libs/ui/kis_view_plugin.h -
087% similarity]
M  +1-1plugins/dockers/throttle/ThrottlePlugin.h
M  +1-1plugins/extensions/animationrenderer/AnimationRenderer.cpp
M  +2-2plugins/extensions/animationrenderer/AnimationRenderer.h
M  +1-1plugins/extensions/bigbrother/bigbrother.cc
M  +2-2plugins/extensions/bigbrother/bigbrother.h
M  +1-1plugins/extensions/buginfo/buginfo.cpp
M  +2-2plugins/extensions/buginfo/buginfo.h
M  +1-1plugins/extensions/clonesarray/clonesarray.cpp
M  +2-2plugins/extensions/clonesarray/clonesarray.h
M  +1-1plugins/extensions/colorrange/colorrange.cc
M  +2-2plugins/extensions/colorrange/colorrange.h
M  +1-1plugins/extensions/colorspaceconversion/colorspaceconversion.cc
M  +2-2plugins/extensions/colorspaceconversion/colorspaceconversion.h
M  +1-1plugins/extensions/histogram/histogram.cc
M  +2-2plugins/extensions/histogram/histogram.h
M  +1-1plugins/extensions/imagesize/imagesize.cc
M  +2-2plugins/extensions/imagesize/imagesize.h
M  +1-1plugins/extensions/imagesplit/imagesplit.cpp
M  +2-2plugins/extensions/imagesplit/imagesplit.h
M  +1-1plugins/extensions/layergroupswitcher/layergroupswitcher.cpp
M  +2-2plugins/extensions/layergroupswitcher/layergroupswitcher.h
M  +1-1plugins/extensions/layersplit/layersplit.cpp
M  +2-2plugins/extensions/layersplit/layersplit.h
M  +1-1plugins/extensions/metadataeditor/metadataeditor.cc
M  +2-2plugins/extensions/metadataeditor/metadataeditor.h
M  +1-1plugins/extensions/modify_selection/modify_selection.cc
M  +2-2plugins/extensions/modify_selection/modify_selection.h
M  +1-1plugins/extensions/offsetimage/offsetimage.cpp
M  +2-2plugins/extensions/offsetimage/offsetimage.h
M  +1-1plugins/extensions/pykrita/plugin/plugin.cpp
M  +2-2plugins/extensions/pykrita/plugin/plugin.h
M  +1-1plugins/extensions/qmic/QMic.cpp
M  +2-2plugins/extensions/qmic/QMic.h
M  +1-1plugins/extensions/resourcemanager/resourcemanager.cpp
M  +2-2plugins/extensions/resourcemanager/resourcemanager.h
M  +1-1plugins/extensions/rotateimage/rotateimage.cc
M  +2-2plugins/extensions/rotateimage/rotateimage.h
M  +1-1   
plugins/extensions/separate_channels/kis_separate_channels_plugin.cc
M  +2-2   
plugins/extensions/separate_channels/kis_separate_channels_plugin.h
M  +1-1plugins/extensions/shearimage/shearimage.cc
M  +2-2plugins/extensions/shearimage/shearimage.h
M  +1-1plugins/extensions/waveletdecompose/waveletdecompose.cpp
M  +2-2plugins/extensions/waveletdecompose/waveletdecompose.h

https://commits.kde.org/krita/e443dc644943b76ebc7f8d8060d626c435409ace

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|dimul...@gmail.com  |b...@valdyas.org

--- Comment #6 from Boudewijn Rempt  ---
Okay, the issue is that scripts create actions, and those actions are added to
each main window as the mainwindow is created. Then when a mainwindow is
deleted, those actions are deleted (because they are reparented to the main
window's action manager...), and the other main window now has a pointer to a
deleted action.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391705

--- Comment #5 from Dmitry Kazakov  ---
Hi, Boud!

I still cannot see how the issue can happen. Could you check two things:

1) Clear the **installation** folder (not the build one) and try again?
2) Try applying this patch and see if pressing "Ignore" helps? 
https://phabricator.kde.org/P176

I tried the following ways to reproduce the issue:
1) Built master and 21a86cd locally, no crash
2) Built master and 21a86cd in the appimage docker, no crash
3) Ran the appimage for 21a86cd, crash happens :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391705

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|b...@valdyas.org|dimul...@gmail.com
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org
   Keywords||regression, release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

--- Comment #4 from Boudewijn Rempt  ---
No, this also happens in the rmept/intel-3 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=391705

--- Comment #3 from Alvin Wong  ---
I got a different crash if I closed the first window instead of the new window:

python36.dll!0x3f7df   PyInterpreterState_Clear+0x257
python36.dll!0x182cef  PyGILState_Ensure+0x33
QtCore.pyd!0x1b98dcPyInit_QtCore+0x1113f
krita.pyd!0x3f575  sipDockWidget::qt_metacast(char const*) at
sipkritapart0.cpp:28049
libkritaui.dll!0x2a4e43QObject::inherits(char const*) const at
qobject.h:416
libkritaui.dll!0x2a4e43 (inlined by) KisMainWindow::forceDockTabFonts()
at KisMainWindow.cpp:1924
libkritaui.dll!0x2b3667KisMainWindow::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) at moc_KisMainWindow.cpp:315
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
libkritaui.dll!0x2a5d1eKisMainWindow::restoringDone() at
moc_KisMainWindow.cpp:484
libkritaui.dll!0x2a5d1e (inlined by) KisMainWindow::addView(KisView*)
at KisMainWindow.cpp:543
libkritaui.dll!0x2a5e75   
KisMainWindow::addViewAndNotifyLoadingCompleted(KisDocument*) at
KisMainWindow.cpp:860
libkritaui.dll!0x341cccKisPart::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) at moc_KisPart.cpp:142
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
libkritaui.dll!0x32f491KisOpenPane::documentSelected(KisDocument*) at
moc_KisOpenPane.cpp:237
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
Qt5Widgets.dll!0x100402QAbstractButton::toggled+0x212
Qt5Widgets.dll!0x1006d3QAbstractButton::toggled+0x4e3
Qt5Widgets.dll!0x44ddb QWidget::event+0xc4b
Qt5Widgets.dll!0x7b5c  QApplicationPrivate::notify_helper+0x9c
Qt5Widgets.dll!0x104f3 QApplication::notify+0x1a13
libkritaui.dll!0x27cc76KisApplication::notify(QObject*, QEvent*) at
KisApplication.cpp:601
Qt5Core.dll!0x210768   QCoreApplication::notifyInternal2+0x198
Qt5Widgets.dll!0x5b2df QDesktopWidget::qt_metacall+0x4fff
Qt5Widgets.dll!0x7b5c  QApplicationPrivate::notify_helper+0x9c
Qt5Widgets.dll!0xedd0  QApplication::notify+0x2f0
libkritaui.dll!0x27cc76KisApplication::notify(QObject*, QEvent*) at
KisApplication.cpp:601
Qt5Core.dll!0x210768   QCoreApplication::notifyInternal2+0x198
Qt5Gui.dll!0x35d93 QGuiApplicationPrivate::processKeyEvent+0x1b3
Qt5Gui.dll!0x3ad65
QGuiApplicationPrivate::processWindowSystemEvent+0xe5
Qt5Gui.dll!0x11ca0
QWindowSystemInterface::sendWindowSystemEvents+0x370
Qt5Core.dll!0x268006  
QEventDispatcherWin32Private::sendTimerEvent+0x666
USER32.dll!0xb85d  UserCallWinProcCheckWow+0x2ad
USER32.dll!0xb1ef  DispatchMessageWorker+0x19f
Qt5Core.dll!0x2672fb   QEventDispatcherWin32::processEvents+0x5cb
qwindows.dll!0x5ef35   qt_plugin_instance+0x28e5
Qt5Core.dll!0x20ee4f   QEventLoop::exec+0x13f
Qt5Widgets.dll!0x1dfaf9QDialog::exec+0x1d9
libkritaui.dll!0x2a4a0fKisMainWindow::slotFileNew() at
KisMainWindow.cpp:1417
libkritaui.dll!0x2b34fdKisMainWindow::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) at moc_KisMainWindow.cpp:295
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
Qt5Widgets.dll!0x3e7e  QAction::activate+0xfe
Qt5Widgets.dll!0x48b3  QAction::event+0x23
Qt5Widgets.dll!0x7b5c  QApplicationPrivate::notify_helper+0x9c
Qt5Widgets.dll!0xedd0  QApplication::notify+0x2f0
libkritaui.dll!0x27cc76KisApplication::notify(QObject*, QEvent*) at
KisApplication.cpp:601
Qt5Core.dll!0x210768   QCoreApplication::notifyInternal2+0x198
Qt5Gui.dll!0x6c70e QShortcutMap::dispatchEvent+0xee
Qt5Gui.dll!0x6c922 QShortcutMap::tryShortcut+0x1b2
Qt5Gui.dll!0x17950
QWindowSystemInterface::handleShortcutEvent+0x170
Qt5Gui.dll!0x35c75 QGuiApplicationPrivate::processKeyEvent+0x95
Qt5Gui.dll!0x3ad65
QGuiApplicationPrivate::processWindowSystemEvent+0xe5
Qt5Gui.dll!0x11ca0
QWindowSystemInterface::sendWindowSystemEvents+0x370
Qt5Core.dll!0x268006  
QEventDispatcherWin32Private::sendTimerEvent+0x666
USER32.dll!0xb85d  UserCallWinProcCheckWow+0x2ad
USER32.dll!0xb1ef  DispatchMessageWorker+0x19f
Qt5Core.dll!0x2672fb   QEventDispatcherWin32::processEvents+0x5cb
qwindows.dll!0x5ef35   qt_plugin_instance+0x28e5
Qt5Core.dll!0x20ee4f   QEventLoop::exec+0x13f
Qt5Core.dll!0x2177a7   QCoreApplication::exec+0x77
krita.exe!0x613b   main at main.cc:349
krita.exe!0x13f7   __tmainCRTStartup+0x247
krita.exe!0x14fb   WinMainCRTStartup+0x1b
KERNEL32.DLL!0x11fe4   BaseThreadInitThunk+0x14
ntdll.dll!0x6efc1  RtlUserThreadStart+0x21

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391705

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #2 from Boudewijn Rempt  ---
I can reproduce it as well. I'll build the intel-3 branch and test in that
too,since that has some fixes for handling multiple windows.

Application: Krita (krita), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f1381022900 (LWP 7831))]

Thread 13 (Thread 0x7f1328ff9700 (LWP 7851)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f1328ff9700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 12 (Thread 0x7f13297fa700 (LWP 7850)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f13297fa700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 11 (Thread 0x7f1329ffb700 (LWP 7849)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f1329ffb700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 10 (Thread 0x7f132a7fc700 (LWP 7848)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f132a7fc700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 9 (Thread 0x7f132affd700 (LWP 7847)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f132affd700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 8 (Thread 0x7f132b7fe700 (LWP 7846)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f132b7fe700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 7 (Thread 0x7f132bfff700 (LWP 7845)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1  0x7f137e3ec5b6 in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f137e3e7dfa in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f137e3eb6eb in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f137755a6ba in start_thread (arg=0x7f132bfff700) at
pthread_create.c:333
#5  0x7f137dae241d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 6 (Thread 0x7f1330b7a700 (LWP 7844)):
#0  pthread_cond_timedwait@@GLIBC_2.3.2 () at

[krita] [Bug 391705] Crash on new document after a new window had been created and closed

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=391705

Alvin Wong  changed:

   What|Removed |Added

Version|4.0 pre-alpha   |git master
 Ever confirmed|0   |1
   Platform|Appimage|unspecified
Summary|No open documents + new |Crash on new document after
   |window and close + new  |a new window had been
   |document, crash |created and closed
   |(krita-4.1.0-pre-alpha-21a8 |
   |6cd-x86_64.appimage)|
 OS|Linux   |All
 CC||alvinhoc...@gmail.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Alvin Wong  ---
I tested with krita-nightly-x64-v4.0.0.51-611-g45709b74de on Windows and I can
reliably produce a crash on creating a new document after having opened and
closed a new window.

Backtrace:

Qt5Core.dll!0x238bb0   QObject::objectName+0x0
libkritaui.dll!0x128c1eKisActionManager::actionByName(QString const&)
const at kis_action_manager.cpp:166
libkritaui.dll!0x181a94KisToolPaint::KisToolPaint(KoCanvasBase*,
QCursor const&) at kis_tool_paint.cc:114
libkritaui.dll!0x17223eKisToolFreehand::KisToolFreehand(KoCanvasBase*,
QCursor const&, KUndo2MagicString const&) at kis_tool_freehand.cc:69
kritatooldyna.dll!0x271a   KisToolDyna::KisToolDyna(KoCanvasBase*) at
kis_tool_dyna.cpp:49
kritatooldyna.dll!0x5f01   KisToolDynaFactory::createTool(KoCanvasBase*) at
kis_tool_dyna.h:173
libkritaflake.dll!0x46ce4  ToolHelper::createTool(KoCanvasBase*) const at
KoToolManager_p.cpp:121
libkritaflake.dll!0x4953a  KoToolManager::createTools(KoCanvasController*,
ToolHelper*) at KoToolManager.cpp:410
libkritaflake.dll!0x49a94 
KoToolManager::Private::createCanvasData(KoCanvasController*, KoInputDevice
const&) at KoToolManager.cpp:486
libkritaflake.dll!0x4c801 
KoToolManager::Private::attachCanvas(KoCanvasController*) at
KoToolManager.cpp:784
libkritaflake.dll!0x4cda7 
KoToolManager::addController(KoCanvasController*) at KoToolManager.cpp:276
libkritaui.dll!0x2cac88KisView::setViewManager(KisViewManager*) at
KisView.cpp:324
libkritaui.dll!0x2a8410KisMainWindow::showView(KisView*) at
KisMainWindow.cpp:564
libkritaui.dll!0x2a5cfdKisMainWindow::addView(KisView*) at
KisMainWindow.cpp:541
libkritaui.dll!0x2a5e75   
KisMainWindow::addViewAndNotifyLoadingCompleted(KisDocument*) at
KisMainWindow.cpp:860
libkritaui.dll!0x341cccKisPart::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) at moc_KisPart.cpp:142
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
libkritaui.dll!0x32f491KisOpenPane::documentSelected(KisDocument*) at
moc_KisOpenPane.cpp:237
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
Qt5Widgets.dll!0x100402QAbstractButton::toggled+0x212
Qt5Widgets.dll!0x1006d3QAbstractButton::toggled+0x4e3
Qt5Widgets.dll!0x44ddb QWidget::event+0xc4b
Qt5Widgets.dll!0x7b5c  QApplicationPrivate::notify_helper+0x9c
Qt5Widgets.dll!0x104f3 QApplication::notify+0x1a13
libkritaui.dll!0x27cc76KisApplication::notify(QObject*, QEvent*) at
KisApplication.cpp:601
Qt5Core.dll!0x210768   QCoreApplication::notifyInternal2+0x198
Qt5Widgets.dll!0x5b2df QDesktopWidget::qt_metacall+0x4fff
Qt5Widgets.dll!0x7b5c  QApplicationPrivate::notify_helper+0x9c
Qt5Widgets.dll!0xedd0  QApplication::notify+0x2f0
libkritaui.dll!0x27cc76KisApplication::notify(QObject*, QEvent*) at
KisApplication.cpp:601
Qt5Core.dll!0x210768   QCoreApplication::notifyInternal2+0x198
Qt5Gui.dll!0x35d93 QGuiApplicationPrivate::processKeyEvent+0x1b3
Qt5Gui.dll!0x3ad65
QGuiApplicationPrivate::processWindowSystemEvent+0xe5
Qt5Gui.dll!0x11ca0
QWindowSystemInterface::sendWindowSystemEvents+0x370
Qt5Core.dll!0x268006  
QEventDispatcherWin32Private::sendTimerEvent+0x666
USER32.dll!0xb85d  UserCallWinProcCheckWow+0x2ad
USER32.dll!0xb1ef  DispatchMessageWorker+0x19f
Qt5Core.dll!0x2672fb   QEventDispatcherWin32::processEvents+0x5cb
qwindows.dll!0x5ef35   qt_plugin_instance+0x28e5
Qt5Core.dll!0x20ee4f   QEventLoop::exec+0x13f
Qt5Widgets.dll!0x1dfaf9QDialog::exec+0x1d9
libkritaui.dll!0x2a4a0fKisMainWindow::slotFileNew() at
KisMainWindow.cpp:1417
libkritaui.dll!0x2b34fdKisMainWindow::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) at moc_KisMainWindow.cpp:295
Qt5Core.dll!0x23b41a   QMetaObject::activate+0x7fa
Qt5Widgets.dll!0x3e7e  QAction::activate+0xfe
Qt5Widgets.dll!0x48b3  QAction::event+0x23