[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-10-12 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394117

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |LATER
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Boudewijn Rempt  ---
Okay, I investigated this again and this really is not possible with the
current ora definition:
https://www.openraster.org/baseline/layer-stack-spec.html .

A group layer does not have any pixels, so there's nothing to save. Ora doesn't
do masks (yet) so we cannot save the group mask, unless we save the whole group
as a single layer with the mask applied.

So, until ora contains masks, we cannot solve this issue in Krita :-(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-14 Thread Alex Gleason
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #8 from Alex Gleason  ---
I guess my point is that removing layer masks is also removing pixels. A layer
mask is still a layer of black and white pixels. So if we are removing pixels
anyway, I'd rather preserve the output.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-14 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394117

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #7 from Boudewijn Rempt  ---
I'm still not sure, but I just noticed that we tell the user that the rendered
result will be saved, so I guess that should confirm this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-14 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #6 from Boudewijn Rempt  ---
I don't need the source files: I understand the situation. It's just that
applying the group's transparency mask to the layers in the group will make the
pixels go away for ever, and that's not safe either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-13 Thread Alex Gleason
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #5 from Alex Gleason  ---
I've attached two images to illustrate the point. The first, waterbaby.kra.jpg
is a KRA file I have with lots of transparency masks on layer groups. Looks
great.

The second, waterbaby.ora.jpg, is what happens when I convert the file to ORA
format. I use a lot of full-color layers and then mask them to the shape I want
then add highlights/shading.

I can send the actual source files if you'd like but they are 100MB+

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-13 Thread Alex Gleason
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #4 from Alex Gleason  ---
Created attachment 112631
  --> https://bugs.kde.org/attachment.cgi?id=112631&action=edit
The same image when converted to ORA format

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-13 Thread Alex Gleason
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #3 from Alex Gleason  ---
Created attachment 112630
  --> https://bugs.kde.org/attachment.cgi?id=112630&action=edit
Example KRA export where many layer masks are used

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-13 Thread Alex Gleason
https://bugs.kde.org/show_bug.cgi?id=394117

--- Comment #2 from Alex Gleason  ---
Hi Boudewijn,

As it stands, converting the image to ORA does cause data to be destroyed. It
destroys the layer mask, which can cause the image output to be completely
wrong. The current behavior for Krita is to apply the layer mask when exporting
to ORA. This works on individual layers, but not layer groups, which is where
the bug lies.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 394117] Transparency masks of Group Layers are not applied when converting to OpenRaster

2018-05-11 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394117

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #1 from Boudewijn Rempt  ---
Hm... I'm not sure about this. There will always be things possible in Krita
that cannot be handled by some file formats. Even if we'd add transparency
masks to ORA files, there will still be transform masks and filter masks. But
on the other hand, if we'd apply the masks to the layers in a group we'd be
destroying image data. I am pretty sure that will be seen as a bug by other
users.

-- 
You are receiving this mail because:
You are watching all bug changes.