[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #13 from Tyson Tan  ---
Thank you Dmitry! This is going to help many new users! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kri
   ||ta/4e602f7aaa64256051f4057b
   ||3aa81f5108ee0fc7

--- Comment #12 from Dmitry Kazakov  ---
Git commit 4e602f7aaa64256051f4057b3aa81f5108ee0fc7 by Dmitry Kazakov.
Committed on 18/04/2019 at 14:50.
Pushed by dkazakov into branch 'master'.

Add a GUI settings for useRightMiddleTabletButtonWorkaround

Some tablet devices don't pass barrel-button clicks via tablet API.
If you have such a device, you can try activate this workaround.
Krita will try to read right- and middle-button clicks from the
mouse events stream. It may or may not work on your device
(depends on the tablet driver implementation).
CC:kimages...@kde.org

M  +9-0libs/ui/dialogs/kis_dlg_preferences.cc
M  +43   -33   libs/ui/forms/wdgtabletsettings.ui
M  +1-1libs/ui/input/kis_input_manager_p.cpp
M  +10   -0libs/ui/kis_config.cc
M  +3-0libs/ui/kis_config.h

https://commits.kde.org/krita/4e602f7aaa64256051f4057b3aa81f5108ee0fc7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=399585

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||b...@valdyas.org

--- Comment #11 from Boudewijn Rempt  ---
Closing then.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #10 from Dmitry Kazakov  ---
Okay, thank you for your testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #9 from Tyson Tan  ---
Created attachment 119488
  --> https://bugs.kde.org/attachment.cgi?id=119488=edit
Event log of Windows 1809 and Cintiq Pro 13 2

It worked after I cleared kritarc and everything. This is the event log when it
was working.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #8 from Tyson Tan  ---
Created attachment 119487
  --> https://bugs.kde.org/attachment.cgi?id=119487=edit
Event log of Windows 1809 and Cintiq Pro 13

The event log was generated with:
1) a few failed middle click attempts;
2) 1 right click;
3) 1 successful middle click attempt, but it stuck there;
4) 1 middle click from my mouse to snap out of it.

Hope it helps!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-18 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #7 from Dmitry Kazakov  ---
Hi, Tyson!

Could you please generate a tablet log for one middle-button stroke?

Manual: https://docs.krita.org/en/KritaFAQ.html#windows

Don't forget to press Ctrl+Shift+T before recording the stroke

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=399585

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #6 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Tyson Tan
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #5 from Tyson Tan  ---
Hi Dmitry! Thank you for the patch and I've tested it on Windows 10 1809 with
Cintiq Pro 13 and Intuos Pro 2 M. Both the drivers and Krita have their Windows
Ink enabled. Sadly it didn't work as intended for me.

1) The good part is the mouse event seems to be recognized by Krita:

# Tablet Tester Information BEGIN

Pen tip brought near
Mouse press X=73 Y=127 B=4
Mouse move X=74 Y=127 B=4
Mouse move X=75 Y=127 B=4
Mouse move X=75 Y=128 B=4
Mouse move X=75 Y=129 B=4
Mouse move X=74 Y=129 B=4
Mouse move X=74 Y=130 B=4
Mouse move X=74 Y=129 B=4
Mouse move X=75 Y=129 B=4
Mouse release
Pen tip taken away
Pen tip brought near
Pen tip taken away

# Tablet Tester Information END

2) But for some reason Krita wouldn't pan the canvas according to most of my
attempts.

3) For the roughly 1/30 chance when the canvas managed to pan, I could not stop
it by releasing the middle button. And then I was stuck under the panning
state, none of the stylus's buttons worked. I had to use my mouse's middle
button to snap out of it.

4) Although I have no idea how it works, is it possible that Krita expects the
mouse cursor to stay still while pressing the middle button here? It was the
only human random factor in this test, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Dmitry Kazakov  ---
Hi, Tyson!

Could you please test this package and check if the workaround lets you use
right and middle buttons of the stylus?

https://yadi.sk/d/db3yUdmPLm8wAg

1) Unpack the package
2) Add to %LOCALAPPDATA%\kritarc: 'rightMiddleTabletButtonWorkaround=true'
3) Run Krita, if needed, activate WinInk and restart
4) Test the buttons

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

--- Comment #3 from Dmitry Kazakov  ---
Git commit c30c6f424c4226531738c93a5d01548e986cba8a by Dmitry Kazakov.
Committed on 17/04/2019 at 17:30.
Pushed by dkazakov into branch 'master'.

Implement a hack for right- and middle-buttons on weird tablet devices

If should fix the following cases:

1) Wintab drivers that do not generate tablet events for right-click and
   middle-click.

2) WinInk mode. With the patch both right- and middle-clicks should be
   available with the stylus buttons.

To activate a workaround just add the following to your 'kritarc':

rightMiddleTabletButtonWorkaround=true

This hack just ignores tablet events for right- and middle-click and
starts to use mouse events for them. Please be careful, the hack will
make right- and middle-strokes less precise. And it also can just break
the tablet support completely.
Related: bug 368849

M  +0-5libs/ui/input/kis_input_manager.cpp
M  +36   -6libs/ui/input/kis_input_manager_p.cpp
M  +3-2libs/ui/input/kis_input_manager_p.h

https://commits.kde.org/krita/c30c6f424c4226531738c93a5d01548e986cba8a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Resolution|UPSTREAM|---

--- Comment #2 from Dmitry Kazakov  ---
Okay, it seems like I have a workaround for the bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 399585] Enabling Windows 8+ pointer input breaks middle button actions

2019-04-17 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=399585

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Tyson!

The problem is that "Windows 8+ Pointer API" is not designed for professional
tablet devices. Therefore it doesn't support more than one button on the stylus
barrel. There is a technical hackish workaround for reporting more than one
button (which makes the protocol kind of inconsistent), but none of the drivers
implement it (I tested Wacom and Huion). So we can do nothing about the
problem, sorry :(

There are the following workarounds possible:

1) Map the second button to Space key in the driver. Then button+click will do
pan for you and ctrl+button+click will do zoom.

2) Map the second button to "Pan" action. With such configuration Wacom driver
generates Space+click. Therefore click will do panning for you and ctrl+click
will do zoom. Exactly like it happens when the button is mapped to
middle-button.


PS:
I have also tested Huion tablet and it seems like it doesn't report barrel
buttons via WinInk at all. Again we cannot do anything about it. It needs to be
reported to the manufacturer.

-- 
You are receiving this mail because:
You are watching all bug changes.