[krita] [Bug 405093] Crash after closing a document.

2019-03-18 Thread Anna Medonosova
https://bugs.kde.org/show_bug.cgi?id=405093

Anna Medonosova  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kri
   ||ta/8161893484cc31bb417c980e
   ||978db3a2046b4d4e
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Anna Medonosova  ---
Git commit 8161893484cc31bb417c980e978db3a2046b4d4e by Anna Medonosova.
Committed on 18/03/2019 at 15:10.
Pushed by amedonosova into branch 'master'.

Better pointer handling in KisMirrorManager and KisMirrorAxis

Summary: BUG:405093,404852

Reviewers: #krita, dkazakov

Reviewed By: #krita, dkazakov

Subscribers: dkazakov

Tags: #krita

Differential Revision: https://phabricator.kde.org/D19776

M  +3-0libs/image/kis_types.h
M  +1-2libs/ui/canvas/kis_mirror_axis.cpp
M  +3-1libs/ui/canvas/kis_mirror_axis.h
M  +29   -21   libs/ui/kis_mirror_manager.cpp
M  +3-6libs/ui/kis_mirror_manager.h

https://commits.kde.org/krita/8161893484cc31bb417c980e978db3a2046b4d4e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405093] Crash after closing a document.

2019-03-06 Thread Anna Medonosova
https://bugs.kde.org/show_bug.cgi?id=405093

--- Comment #5 from Anna Medonosova  ---
Git commit f16b1f8b61ad08899a9518577aa6af1e0080eea4 by Anna Medonosova.
Committed on 06/03/2019 at 14:57.
Pushed by amedonosova into branch 'master'.

Fix decoration handling in KisMirrorManager

KisMirrorManager did not update d->mirrorAxisDecoration upon view
change, instead it used last created decoration. If the document tied to
that decoration was closed, Krita crashed.

M  +3-0libs/ui/canvas/KisMirrorAxisConfig.cpp
M  +13   -12   libs/ui/kis_mirror_manager.cpp
M  +0-1libs/ui/kis_mirror_manager.h

https://commits.kde.org/krita/f16b1f8b61ad08899a9518577aa6af1e0080eea4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405093] Crash after closing a document.

2019-03-06 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=405093

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #4 from Boudewijn Rempt  ---
I just took a look, and that's indeed rather weird code. It doesn't look like
the owner is KisMirrorManager. So, at the very least, the config should be in a
QWeakSharedPointer so we know when it's deleted by the owner.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405093] Crash after closing a document.

2019-03-06 Thread Anna Medonosova
https://bugs.kde.org/show_bug.cgi?id=405093

--- Comment #3 from Anna Medonosova  ---
It seems that both crashes are symptoms of one problem: the KisMirrorManager
handles it's decorations incorrectly.

I can reproduce the crash with following steps:
1, open two documents with mirror configuration
2, close one of the documents
3, click on the mirror tool buttons in paintop box

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405093] Crash after closing a document.

2019-03-05 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=405093

--- Comment #2 from wolthera  ---
different but somewhat related crash:

Thread 1 "krita" received signal SIGSEGV, Segmentation fault.
0x766cc739 in KisMirrorAxisConfig::Private::operator==
(this=0x74118b90, 
rhs=...) at
/home/wolthera/krita/src/libs/ui/canvas/KisMirrorAxisConfig.cpp:41
41  return mirrorHorizontal == rhs.mirrorHorizontal &&

---

Thread 1 (Thread 0x77f80840 (LWP 2326)):
#0  0x766cc739 in KisMirrorAxisConfig::Private::operator==
(this=0x74118b90, 
rhs=...) at
/home/wolthera/krita/src/libs/ui/canvas/KisMirrorAxisConfig.cpp:41
#1  0x766cb8a1 in KisMirrorAxisConfig::operator== (this=0x7fffbf20,
rhs=...)
at /home/wolthera/krita/src/libs/ui/canvas/KisMirrorAxisConfig.cpp:98
#2  0x76b15255 in boost::operators_impl::operator!= (x=..., y=...)
at /usr/include/boost/operators.hpp:158
#3  0x76b13aa6 in KisMirrorAxis::setMirrorAxisConfig
(this=0x7796d300, 
config=...) at
/home/wolthera/krita/src/libs/ui/canvas/kis_mirror_axis.cpp:364
#4  0x76b9da48 in KisMirrorManager::setDecorationConfig
(this=0x657a7bd0)
at /home/wolthera/krita/src/libs/ui/kis_mirror_manager.cpp:129
#5  0x76b9d55c in KisMirrorManager::setView (this=0x657a7bd0,
imageView=...)
at /home/wolthera/krita/src/libs/ui/kis_mirror_manager.cpp:86

#6  0x76b8fcaa in KisViewManager::setCurrentView (this=0x66ab4f70, 
view=0x6dce79d0) at
/home/wolthera/krita/src/libs/ui/KisViewManager.cpp:497
#7  0x76b5230e in KisMainWindow::setActiveView (this=0x57331460, 
view=0x6dce79d0) at
/home/wolthera/krita/src/libs/ui/KisMainWindow.cpp:1320
#8  0x76b5940f in KisMainWindow::setActiveSubWindow
(this=0x57331460, 
window=0x6e1f1d10) at
/home/wolthera/krita/src/libs/ui/KisMainWindow.cpp:2298
#9  0x76b573dc in KisMainWindow::subWindowActivated
(this=0x57331460)
at /home/wolthera/krita/src/libs/ui/KisMainWindow.cpp:2075
#10 0x76b5c5f9 in KisMainWindow::qt_static_metacall (_o=0x57331460, 
_c=QMetaObject::InvokeMetaMethod, _id=21, _a=0x7fffc370)
at
/home/wolthera/krita/build/libs/ui/kritaui_autogen/include/moc_KisMainWindow.cpp:323
#11 0x73352e25 in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x7426fbbf in QMdiArea::subWindowActivated(QMdiSubWindow*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#13 0x7427421f in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#14 0x74274f28 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#15 0x74275e05 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
---Type  to continue, or q  to quit---
#16 0x73352e25 in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#17 0x7427b43c in
QMdiSubWindow::windowStateChanged(QFlags,
QFlags) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#18 0x74283233 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#19 0x7427862a in QMdiArea::viewportEvent(QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#20 0x733230ad in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#21 0x74119815 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#22 0x74120dd0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#23 0x76b18e8d in KisApplication::notify (this=0x7fffe0c0, 
receiver=0x66153910, event=0x7fffca20)
at /home/wolthera/krita/src/libs/ui/KisApplication.cpp:607
#24 0x73323328 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#25 0x74284c2b in QMdiSubWindow::closeEvent(QCloseEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#26 0x74159838 in QWidget::event(QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#27 0x742841eb in QMdiSubWindow::event(QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#28 0x7411983c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#29 0x74120dd0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#30 0x76b18e8d in KisApplication::notify (this=0x7fffe0c0, 
receiver=0x71cb3130, event=0x7fffcee0)
at /home/wolthera/krita/src/libs/ui/KisApplication.cpp:607
#31 0x73323328 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
()
   from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#32 0x74154b7e in

[krita] [Bug 405093] Crash after closing a document.

2019-03-04 Thread Anna Medonosova
https://bugs.kde.org/show_bug.cgi?id=405093

Anna Medonosova  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||anna.medonos...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405093] Crash after closing a document.

2019-03-04 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=405093

wolthera  changed:

   What|Removed |Added

 CC||griffinval...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.