[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-20 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=408484

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/0da4a74e407f72 |krita/commit/3ec4483b5fb1f9
   |604b3a7a455d82f29125ed6d5b  |118b81d361c63abf7de32b9fb6

--- Comment #6 from Boudewijn Rempt  ---
Git commit 3ec4483b5fb1f9118b81d361c63abf7de32b9fb6 by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 20/06/2019 at 10:33.
Pushed by rempt into branch 'krita/4.2'.

Fix a crash when undoing node creation too quickly

The loop in getNodeLevelOfDetail() was just unsafe, because `leaf`
may easily become null, when traversing a graph.

M  +9-2libs/image/kis_base_rects_walker.h

https://invent.kde.org/kde/krita/commit/3ec4483b5fb1f9118b81d361c63abf7de32b9fb6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-19 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=408484

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/0da4a74e407f72
   ||604b3a7a455d82f29125ed6d5b
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Dmitry Kazakov  ---
Git commit 0da4a74e407f72604b3a7a455d82f29125ed6d5b by Dmitry Kazakov.
Committed on 19/06/2019 at 20:05.
Pushed by dkazakov into branch 'master'.

Fix a crash when undoing node creation too quickly

The loop in getNodeLevelOfDetail() was just unsafe, because `leaf`
may easily become null, when traversing a graph.

M  +9-2libs/image/kis_base_rects_walker.h

https://invent.kde.org/kde/krita/commit/0da4a74e407f72604b3a7a455d82f29125ed6d5b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-19 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=408484

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|NEEDSINFO   |REOPENED

--- Comment #4 from Dmitry Kazakov  ---
Okay, I found our the reason of the bug. The node became detached and a failing
algorithm in getNodeLevelOfDetail() got fall over it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=408484

--- Comment #3 from epicwraths...@yandex.ru ---
Created attachment 121011
  --> https://bugs.kde.org/attachment.cgi?id=121011=edit
thread1_frame_info_locals

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=408484

--- Comment #2 from epicwraths...@yandex.ru ---
Created attachment 121010
  --> https://bugs.kde.org/attachment.cgi?id=121010=edit
thread1_frame_info_args

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-19 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=408484

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|ASSIGNED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hm... I looked at the code and I cannot find how the assert could happen
without severe memory corruption (in software, not hardware). I will mark this
bug as NEEDSINFO, if you happen to see this crash again, please reopen it and
try to remember, what types of nodes you had. And what actions you did with
them before starting undo operation.

According to the backtrace, a layer or mask has been deleted while a smart
pointer still pointing to it, which is not possible in normal situation... :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408484] SIGSEGV while walking through undo/redo on 4.2.1 git-01440fb

2019-06-12 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=408484

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
 CC||b...@valdyas.org
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.