[krita] [Bug 411081] Crash Without Warning

2019-09-13 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/2fdd504dfe6ec6 |krita/commit/8b436ffc8ab139
   |3b654ee0878c9f95cb69d4a6ad  |98a3d04702583f07c38a20a319

--- Comment #30 from Dmitry Kazakov  ---
Git commit 8b436ffc8ab13998a3d04702583f07c38a20a319 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:55.
Pushed by dkazakov into branch 'krita/4.2'.

Fix checking if swap location is set to a writable location

QFileInfo::isWritable() doesn't work on NTFS by default, so we should
just try to create a test fiel to check that.
Related: bug 411129

M  +31   -5libs/image/kis_image_config.cpp

https://invent.kde.org/kde/krita/commit/8b436ffc8ab13998a3d04702583f07c38a20a319

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-13 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/2fdd504dfe6ec6 |krita/commit/8b436ffc8ab139
   |3b654ee0878c9f95cb69d4a6ad  |98a3d04702583f07c38a20a319
   |https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/8b436ffc8ab139 |krita/commit/57c8db26dc9486
   |98a3d04702583f07c38a20a319  |eff6fab9e046b2df2320f23183

--- Comment #30 from Dmitry Kazakov  ---
Git commit 8b436ffc8ab13998a3d04702583f07c38a20a319 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:55.
Pushed by dkazakov into branch 'krita/4.2'.

Fix checking if swap location is set to a writable location

QFileInfo::isWritable() doesn't work on NTFS by default, so we should
just try to create a test fiel to check that.
Related: bug 411129

M  +31   -5libs/image/kis_image_config.cpp

https://invent.kde.org/kde/krita/commit/8b436ffc8ab13998a3d04702583f07c38a20a319

--- Comment #31 from Dmitry Kazakov  ---
Git commit ea97d0bc790d1be287ab61ac910586eecd23d1e7 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:53.
Pushed by dkazakov into branch 'krita/4.2'.

Fix ConcurrentMap::migrationInProcess() to handle initialization value (0)
properly

Job coordinator of the table may have three states:

1) jobCoordinator == 0: the table was initialized, but no migration
   has ever been started for this table
2) jobCoordinator > 1: a table migration is in progress right now. The
   caller should join *jobCoordinator to help finishing the migration.
3) jobCoordinator == 1: the table migration has been finished. It means
   that the table doesn't have any values in it anymore.

The patch actually fixes the map to consider case 1 as a situation, when
there is no migration.

M  +1-1libs/image/3rdparty/lock_free_map/concurrent_map.h

https://invent.kde.org/kde/krita/commit/ea97d0bc790d1be287ab61ac910586eecd23d1e7

--- Comment #32 from Dmitry Kazakov  ---
Git commit 57c8db26dc9486eff6fab9e046b2df2320f23183 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:54.
Pushed by dkazakov into branch 'krita/4.2'.

Fix random crash when swap-file location has not got enough disk space

Lockfree hash table iterators have a requirement of no-concurrent-inserts,
so we must ensure that the swapper and pooler do *not* insert any tiles,
why iteration is in progress. KisTileDataStore::trySwapTileData() is called
exactly from inside of the swapper iteration loop.

If we break this requirement, the insert operation may request a table
migration, and the iterator will continue iterating the old, invalid,
table.

The actual crash happened after line 'item = iter->next()' in
KisTileDataSwapper::pass(), which actually returned value '1', meaning
"Redirect". Address 0x0029 is a fetch of
KisTileData::m_mementoFlag (offset 0x28) with 'this' set to 0x01 :)

M  +3-0libs/image/3rdparty/lock_free_map/concurrent_map.h
M  +1-4libs/image/tiles3/kis_tile_data_store.cc

https://invent.kde.org/kde/krita/commit/57c8db26dc9486eff6fab9e046b2df2320f23183

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-13 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/57c8db26dc9486 |krita/commit/8c399da9600dba
   |eff6fab9e046b2df2320f23183  |a635a1a87f06556d5b5094d5fa

--- Comment #33 from Dmitry Kazakov  ---
Git commit 8c399da9600dbaa635a1a87f06556d5b5094d5fa by Dmitry Kazakov.
Committed on 13/09/2019 at 08:59.
Pushed by dkazakov into branch 'krita/4.2'.

Fix QRandomGenerator initialization on AMD CPUs

Some AMD CPUs (e.g. AMD A4-6250J and AMD Ryzen 3000-series) have a
failing random generation instruction, which always returns
0x, even when generation was "successful".

This code checks if hardware random generator can generate four
consecutive distinct numbers. If it fails the test, then we probably
have a failing one and should disable it completely.

Gerrit review:
https://codereview.qt-project.org/c/qt/qtbase/+/272837

A  +214  -0   
3rdparty/ext_qt/0070-Fix-QRandomGenerator-initialization-on-AMD-CPUs.patch
M  +7-03rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/kde/krita/commit/8c399da9600dbaa635a1a87f06556d5b5094d5fa

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-13 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/2fdd504dfe6ec6 |krita/commit/8b436ffc8ab139
   |3b654ee0878c9f95cb69d4a6ad  |98a3d04702583f07c38a20a319

--- Comment #30 from Dmitry Kazakov  ---
Git commit 8b436ffc8ab13998a3d04702583f07c38a20a319 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:55.
Pushed by dkazakov into branch 'krita/4.2'.

Fix checking if swap location is set to a writable location

QFileInfo::isWritable() doesn't work on NTFS by default, so we should
just try to create a test fiel to check that.
Related: bug 411129

M  +31   -5libs/image/kis_image_config.cpp

https://invent.kde.org/kde/krita/commit/8b436ffc8ab13998a3d04702583f07c38a20a319

--- Comment #31 from Dmitry Kazakov  ---
Git commit ea97d0bc790d1be287ab61ac910586eecd23d1e7 by Dmitry Kazakov.
Committed on 13/09/2019 at 08:53.
Pushed by dkazakov into branch 'krita/4.2'.

Fix ConcurrentMap::migrationInProcess() to handle initialization value (0)
properly

Job coordinator of the table may have three states:

1) jobCoordinator == 0: the table was initialized, but no migration
   has ever been started for this table
2) jobCoordinator > 1: a table migration is in progress right now. The
   caller should join *jobCoordinator to help finishing the migration.
3) jobCoordinator == 1: the table migration has been finished. It means
   that the table doesn't have any values in it anymore.

The patch actually fixes the map to consider case 1 as a situation, when
there is no migration.

M  +1-1libs/image/3rdparty/lock_free_map/concurrent_map.h

https://invent.kde.org/kde/krita/commit/ea97d0bc790d1be287ab61ac910586eecd23d1e7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-10 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||carinatooc...@gmail.com

--- Comment #29 from Dmitry Kazakov  ---
*** Bug 411779 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-09 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #28 from Dmitry Kazakov  ---
Hi, 4lph4dr4g0nl1ch!

The nightlies starting from 6th of September should actually fix the crash on
broken AMD CPUs, please check the latest one: 
https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/

There is also a workaround for this crash for the non-patched versions. You
should just go to:

C:/Users/nitef/AppData/Local/Temp

and remove all the files that start with KRITA_SWAP_FILE_*

The crash will disappear till the next crash/hard-shutdown of Kirta. Then
you'll have to remove this file again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

4lph4dr4g0nl...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|NEEDSINFO
 Resolution|--- |FIXED

--- Comment #27 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #22)
> Ah, I'm sorry. I gave you a link to a wrong branch, sorry :(
> 
> Could you try this one:
> https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/
> 
> And at the same time, could you check if you have access to this folder?
> C:\Users\nitef\AppData\Local\Temp
> 
> It looks like Krita tries to create a swap file there, but fails. 
> 
> If you still have a crash, try to go to
> Preferences->Performance->SwapFileLocation and select some writable
> location, which you are sure about. After that restart Krita.
> 
> If you still have a problem, attach a log from DebugView :)


Nevermind, it once again decided to wait until I marked the bug as
"worksforme". 
Here's the log:
https://sta.sh/02cz710pg0gx
I'm going to do more testing with the build vs the latest nightly build, and
try the swap file thing again. I'll let you know what happens.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

4lph4dr4g0nl...@gmail.com changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #26 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #24)
> Git commit 2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad by Dmitry Kazakov.
> Committed on 05/09/2019 at 08:22.
> Pushed by dkazakov into branch 'master'.
> 
> Fix QRandomGenerator initialization on AMD CPUs
> 
> Some AMD CPUs (e.g. AMD A4-6250J and AMD Ryzen 3000-series) have a
> failing random generation instruction, which always returns
> 0x, even when generation was "successful".
> 
> This code checks if hardware random generator can generate four
> consecutive distinct numbers. If it fails the test, then we probably
> have a failing one and should disable it completely.
> 
> Gerrit review:
> https://codereview.qt-project.org/c/qt/qtbase/+/272837
> 
> A  +214  -0   
> 3rdparty/ext_qt/0070-Fix-QRandomGenerator-initialization-on-AMD-CPUs.patch
> M  +7-03rdparty/ext_qt/CMakeLists.txt
> 
> https://invent.kde.org/kde/krita/commit/
> 2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad


I do run on an AMD Ryzen 5 3600X 6-Core Processor, so that
(In reply to 4lph4dr4g0nl1ch from comment #25)
> (In reply to Dmitry Kazakov from comment #22)
> > Ah, I'm sorry. I gave you a link to a wrong branch, sorry :(
> > 
> > Could you try this one:
> > https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/
> > 
> > And at the same time, could you check if you have access to this folder?
> > C:\Users\nitef\AppData\Local\Temp
> > 
> > It looks like Krita tries to create a swap file there, but fails. 
> > 
> > If you still have a crash, try to go to
> > Preferences->Performance->SwapFileLocation and select some writable
> > location, which you are sure about. After that restart Krita.
> > 
> > If you still have a problem, attach a log from DebugView :)
> 
> -
> Sorry for waiting so long to reply, but because it didn't show itself last
> time, I took a few days to test the build for the crash. I've been actively
> trying to duplicate the crash, and so far it hasn't happened yet.

---
Scratch that, it's crashed again.(In reply to Dmitry Kazakov from comment #24)
> Git commit 2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad by Dmitry Kazakov.
> Committed on 05/09/2019 at 08:22.
> Pushed by dkazakov into branch 'master'.
> 
> Fix QRandomGenerator initialization on AMD CPUs
> 
> Some AMD CPUs (e.g. AMD A4-6250J and AMD Ryzen 3000-series) have a
> failing random generation instruction, which always returns
> 0x, even when generation was "successful".
> 
> This code checks if hardware random generator can generate four
> consecutive distinct numbers. If it fails the test, then we probably
> have a failing one and should disable it completely.
> 
> Gerrit review:
> https://codereview.qt-project.org/c/qt/qtbase/+/272837
> 
> A  +214  -0   
> 3rdparty/ext_qt/0070-Fix-QRandomGenerator-initialization-on-AMD-CPUs.patch
> M  +7-03rdparty/ext_qt/CMakeLists.txt
> 
> https://invent.kde.org/kde/krita/commit/
> 2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad


I do run on an AMD Ryzen-3600 processor, so that adds up. What am I supposed to
do there at those links? Are those just separate forums discussing the issue
or?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

4lph4dr4g0nl...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #25 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #22)
> Ah, I'm sorry. I gave you a link to a wrong branch, sorry :(
> 
> Could you try this one:
> https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/
> 
> And at the same time, could you check if you have access to this folder?
> C:\Users\nitef\AppData\Local\Temp
> 
> It looks like Krita tries to create a swap file there, but fails. 
> 
> If you still have a crash, try to go to
> Preferences->Performance->SwapFileLocation and select some writable
> location, which you are sure about. After that restart Krita.
> 
> If you still have a problem, attach a log from DebugView :)

-
Sorry for waiting so long to reply, but because it didn't show itself last
time, I took a few days to test the build for the crash. I've been actively
trying to duplicate the crash, and so far it hasn't happened yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-09-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/9f4cf95f26e995 |krita/commit/2fdd504dfe6ec6
   |800aa1028bd0b9c26d86ec1620  |3b654ee0878c9f95cb69d4a6ad
 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED

--- Comment #24 from Dmitry Kazakov  ---
Git commit 2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad by Dmitry Kazakov.
Committed on 05/09/2019 at 08:22.
Pushed by dkazakov into branch 'master'.

Fix QRandomGenerator initialization on AMD CPUs

Some AMD CPUs (e.g. AMD A4-6250J and AMD Ryzen 3000-series) have a
failing random generation instruction, which always returns
0x, even when generation was "successful".

This code checks if hardware random generator can generate four
consecutive distinct numbers. If it fails the test, then we probably
have a failing one and should disable it completely.

Gerrit review:
https://codereview.qt-project.org/c/qt/qtbase/+/272837

A  +214  -0   
3rdparty/ext_qt/0070-Fix-QRandomGenerator-initialization-on-AMD-CPUs.patch
M  +7-03rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/kde/krita/commit/2fdd504dfe6ec63b654ee0878c9f95cb69d4a6ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-30 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=411081

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #23 from Boudewijn Rempt  ---
Setting to needinfo

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #22 from Dmitry Kazakov  ---
Ah, I'm sorry. I gave you a link to a wrong branch, sorry :(

Could you try this one:
https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/

And at the same time, could you check if you have access to this folder?
C:\Users\nitef\AppData\Local\Temp

It looks like Krita tries to create a swap file there, but fails. 

If you still have a crash, try to go to
Preferences->Performance->SwapFileLocation and select some writable location,
which you are sure about. After that restart Krita.

If you still have a problem, attach a log from DebugView :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #21 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #20)
> Hi, 4lph4dr4g0nl1ch!
> 
> Could you check today's nightly build, is the bug finally fixed for you?
> https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/
> 
> If the crash still happens, please generate a log with DebugView for me:
> https://docs.microsoft.com/en-us/sysinternals/downloads/debugview

---
Not completely, but another issue concerning the reference tool was fixed (that
I was about to make another bug report for). That having to do with it freaking
out and becoming unresponsive when I tried deleting images and serious lag when
I moved or resize them. So that's good, I guess.

Here's the debugview log.
https://sta.sh/0ihpi62miy6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #20 from Dmitry Kazakov  ---
Hi, 4lph4dr4g0nl1ch!

Could you check today's nightly build, is the bug finally fixed for you?
https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/

If the crash still happens, please generate a log with DebugView for me:
https://docs.microsoft.com/en-us/sysinternals/downloads/debugview

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-27 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=411081

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||coolcat...@gmail.com

--- Comment #19 from Boudewijn Rempt  ---
*** Bug 410866 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-27 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=411081

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

4lph4dr4g0nl...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|FIXED   |---

--- Comment #18 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #17)
> I will close the report, since the original bug has been fixed. Please
> contact me on IRC to get more help about swap/bundle file locations (my name
> is dmitryK|log at https://krita.org/en/irc/).
> 
> If you happen to get original crash again in future builds, please reopen
> the bug.

-
(In reply to Dmitry Kazakov from comment #16)
> Hi, 4lph4dr4g0nl1ch!
> 
> It looks like the original bug has been fixed! :)
> 
> Though I can see some weird things in your log file. Krita cannot open brush
> bundles, like these:
> C:/Users/nitef/AppData/Roaming/krita/bundles/HC_Paintbrush.bundle
> C:/Users/nitef/AppData/Roaming/krita/bundles/concept
> C:/Users/nitef/AppData/Roaming/krita/bundles/vb1B_CONCEPT.bundle
> 
> You might just try to remove (or backup) all these bundles.
> 
> During the first run, Krita also didn't manage to create a swap file with
> the following location:
> 
> C:/Users/nitef/AppData/Local/Temp
> 
> Please check if this location exists and you have write access to it. There
> might also be some antivirus software, that blocks Krita from accessing
> these folders.


Seems the bug is still there, just conveniently didn't happen during the
initial testing of the nightly build.
I checked and the temp location does exist. 
I've never had a problem with the bundles before. What makes them incompatible?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Dmitry Kazakov  ---
I will close the report, since the original bug has been fixed. Please contact
me on IRC to get more help about swap/bundle file locations (my name is
dmitryK|log at https://krita.org/en/irc/).

If you happen to get original crash again in future builds, please reopen the
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-22 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #16 from Dmitry Kazakov  ---
Hi, 4lph4dr4g0nl1ch!

It looks like the original bug has been fixed! :)

Though I can see some weird things in your log file. Krita cannot open brush
bundles, like these:
C:/Users/nitef/AppData/Roaming/krita/bundles/HC_Paintbrush.bundle
C:/Users/nitef/AppData/Roaming/krita/bundles/concept
C:/Users/nitef/AppData/Roaming/krita/bundles/vb1B_CONCEPT.bundle

You might just try to remove (or backup) all these bundles.

During the first run, Krita also didn't manage to create a swap file with the
following location:

C:/Users/nitef/AppData/Local/Temp

Please check if this location exists and you have write access to it. There
might also be some antivirus software, that blocks Krita from accessing these
folders.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #15 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #13)
> Hi, 4lph4dr4g0nl1ch!
> 
> Could you please check the following:
> 
> 1) Download the following package, unpack and run: 
> https://yadi.sk/d/H0y2qxDqOnPtGg
> 
> 2) Check if it doesn't crash (it shouldn't)
> 3) Go to Preferences->Performance->General and set "Swap File Location" to
> some non-writable location, e.g. "C:\Program Files"
> 4) Restart Krita
> 5) Go to Preferences->Performance->General again, and check if the location
> was automatically reset to your local Temp location.


I ran it by your instructions, and the temp location switched back to its
default after restarting.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

4lph4dr4g0nl...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Ever confirmed|1   |0
 Status|RESOLVED|REPORTED

--- Comment #14 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #11)
> Hi,4lph4dr4g0nl1ch!
> 
> Could you please make a few tests for me? I still wonder why you had these
> swap failures.
> 
> 1) Download and run DebugView to get more logging: 
> https://docs.microsoft.com/en-us/sysinternals/downloads/debugview
> 
> 2) Download 'swap1-fatal' build, uncompress it, run and try to reproduce the
> crash. It should crash a bit faster. Make sure you have DebugView open
> during this run. 
> 
> swap1-fatal: https://yadi.sk/d/AY_N0uRmBJjY8A
> 
> 3) Attach the log from DebugView to this bug report. It should have lines
> like: "KisTileDataStore::trySwapTileData: couldn't swap out tile data" and
> "KisMemoryWindow: couldn't move sliding window"
> 
> 4) Clear the log in DebugView (or just restart it).
> 
> 5) Download 'swap2' build, uncompress it and run. It shouldn't crash and
> should work normally. Check if it doesn't crash and attach the log as well.
> 
> swap2: https://yadi.sk/d/YAYgT4acCJHBsQ


The second version didn't crash, but I ran into a strange error regarding
saving (that I thought I fixed), with krita claiming it can't save because the
file can't be opened. It seems to fix when I save into another folder, but I
thought I should mention it anyway.
These should be the right logs for tests 1 and 2.
https://sta.sh/22f0xbyuvkcc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #13 from Dmitry Kazakov  ---
Hi, 4lph4dr4g0nl1ch!

Could you please check the following:

1) Download the following package, unpack and run: 
https://yadi.sk/d/H0y2qxDqOnPtGg

2) Check if it doesn't crash (it shouldn't)
3) Go to Preferences->Performance->General and set "Swap File Location" to some
non-writable location, e.g. "C:\Program Files"
4) Restart Krita
5) Go to Preferences->Performance->General again, and check if the location was
automatically reset to your local Temp location.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
   |krita/commit/ac020c6cb41213 |krita/commit/9f4cf95f26e995
   |d65f40be8aafb960af8259ff1d  |800aa1028bd0b9c26d86ec1620
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #12 from Dmitry Kazakov  ---
Git commit 9f4cf95f26e995800aa1028bd0b9c26d86ec1620 by Dmitry Kazakov.
Committed on 21/08/2019 at 16:12.
Pushed by dkazakov into branch 'master'.

Fix checking if swap location is set to a writable location

QFileInfo::isWritable() doesn't work on NTFS by default, so we should
just try to create a test fiel to check that.
Related: bug 411129

M  +31   -5libs/image/kis_image_config.cpp

https://invent.kde.org/kde/krita/commit/9f4cf95f26e995800aa1028bd0b9c26d86ec1620

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #11 from Dmitry Kazakov  ---
Hi,4lph4dr4g0nl1ch!

Could you please make a few tests for me? I still wonder why you had these swap
failures.

1) Download and run DebugView to get more logging: 
https://docs.microsoft.com/en-us/sysinternals/downloads/debugview

2) Download 'swap1-fatal' build, uncompress it, run and try to reproduce the
crash. It should crash a bit faster. Make sure you have DebugView open during
this run. 

swap1-fatal: https://yadi.sk/d/AY_N0uRmBJjY8A

3) Attach the log from DebugView to this bug report. It should have lines like:
"KisTileDataStore::trySwapTileData: couldn't swap out tile data" and
"KisMemoryWindow: couldn't move sliding window"

4) Clear the log in DebugView (or just restart it).

5) Download 'swap2' build, uncompress it and run. It shouldn't crash and should
work normally. Check if it doesn't crash and attach the log as well.

swap2: https://yadi.sk/d/YAYgT4acCJHBsQ

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-21 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #10 from Dmitry Kazakov  ---
Okay, if you happen to get some swap/memory-related bugs, please let me know :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #9 from 4lph4dr4g0nl...@gmail.com ---
(In reply to Dmitry Kazakov from comment #8)
> Hi, 4lph4dr4g0nl1ch!
> 
> The fix will be available tomorrow in the nightly builds, please test!
> https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/
> 
> And please make sure you have enough of free space on the hard drive, where
> your swap file is located. The crash happened because Krita behaved
> incorrectly, when there was not enough disk space left. I have fixed the
> crash now, but if you don't clean up on your hard drive, Krita will still
> lack memory, :)


Thanks for all your help c: <3
Though I should mention this computer is brand new, and this issue has been
present ever since I set it up, so it can't be lack of hard drive space.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #8 from Dmitry Kazakov  ---
Hi, 4lph4dr4g0nl1ch!

The fix will be available tomorrow in the nightly builds, please test!
https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/

And please make sure you have enough of free space on the hard drive, where
your swap file is located. The crash happened because Krita behaved
incorrectly, when there was not enough disk space left. I have fixed the crash
now, but if you don't clean up on your hard drive, Krita will still lack
memory, :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #6 from Dmitry Kazakov  ---
Git commit 2ffdc5b070522bf1df73844ff47f525cb4a9262c by Dmitry Kazakov.
Committed on 20/08/2019 at 16:10.
Pushed by dkazakov into branch 'master'.

Fix ConcurrentMap::migrationInProcess() to handle initialization value (0)
properly

Job coordinator of the table may have three states:

1) jobCoordinator == 0: the table was initialized, but no migration
   has ever been started for this table
2) jobCoordinator > 1: a table migration is in progress right now. The
   caller should join *jobCoordinator to help finishing the migration.
3) jobCoordinator == 1: the table migration has been finished. It means
   that the table doesn't have any values in it anymore.

The patch actually fixes the map to consider case 1 as a situation, when
there is no migration.

M  +1-1libs/image/3rdparty/lock_free_map/concurrent_map.h

https://invent.kde.org/kde/krita/commit/2ffdc5b070522bf1df73844ff47f525cb4a9262c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=411081

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/ac020c6cb41213
   ||d65f40be8aafb960af8259ff1d
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Dmitry Kazakov  ---
Git commit 2ffdc5b070522bf1df73844ff47f525cb4a9262c by Dmitry Kazakov.
Committed on 20/08/2019 at 16:10.
Pushed by dkazakov into branch 'master'.

Fix ConcurrentMap::migrationInProcess() to handle initialization value (0)
properly

Job coordinator of the table may have three states:

1) jobCoordinator == 0: the table was initialized, but no migration
   has ever been started for this table
2) jobCoordinator > 1: a table migration is in progress right now. The
   caller should join *jobCoordinator to help finishing the migration.
3) jobCoordinator == 1: the table migration has been finished. It means
   that the table doesn't have any values in it anymore.

The patch actually fixes the map to consider case 1 as a situation, when
there is no migration.

M  +1-1libs/image/3rdparty/lock_free_map/concurrent_map.h

https://invent.kde.org/kde/krita/commit/2ffdc5b070522bf1df73844ff47f525cb4a9262c

--- Comment #7 from Dmitry Kazakov  ---
Git commit ac020c6cb41213d65f40be8aafb960af8259ff1d by Dmitry Kazakov.
Committed on 20/08/2019 at 16:10.
Pushed by dkazakov into branch 'master'.

Fix random crash when swap-file location has not got enough disk space

Lockfree hash table iterators have a requirement of no-concurrent-inserts,
so we must ensure that the swapper and pooler do *not* insert any tiles,
why iteration is in progress. KisTileDataStore::trySwapTileData() is called
exactly from inside of the swapper iteration loop.

If we break this requirement, the insert operation may request a table
migration, and the iterator will continue iterating the old, invalid,
table.

The actual crash happened after line 'item = iter->next()' in
KisTileDataSwapper::pass(), which actually returned value '1', meaning
"Redirect". Address 0x0029 is a fetch of
KisTileData::m_mementoFlag (offset 0x28) with 'this' set to 0x01 :)

M  +3-0libs/image/3rdparty/lock_free_map/concurrent_map.h
M  +1-4libs/image/tiles3/kis_tile_data_store.cc

https://invent.kde.org/kde/krita/commit/ac020c6cb41213d65f40be8aafb960af8259ff1d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #5 from Boudewijn Rempt  ---
Oh, just checking: are you the same person who reported this backtrace on the
forum?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-20 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=411081

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #4 from Boudewijn Rempt  ---
Yes, thanks for adding this. I've seen this backtrace before, though I haven't
been able to reproduce it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=411081

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #3 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 411081] Crash Without Warning

2019-08-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=411081

--- Comment #2 from 4lph4dr4g0nl...@gmail.com ---
(In reply to wolthera from comment #1)
> Hey, could you see if you can provide a backtrace?
> 
> 
> Instructions are here:
> https://docs.krita.org/en/reference_manual/dr_minw_debugger.html
> 
> We can use the backtrace as a blackbox to figure out where Krita is crashing
> and then more efficiently fix the issue.

--
Error occurred on Monday, August 19, 2019 at 18:12:22.

krita.exe caused an Access Violation at location 7FF84753C357 in module
libkritaimage.dll Reading from location 0029.

AddrPC   Params
7FF84753C357    
libkritaimage.dll!0x2dc357 KisTileDataSwapper::pass+0xb7
7FF847278CC0 388D2E10   
libkritaimage.dll!0x18cc0 KisTileDataSwapper::doJob+0x80
7FF847278D3F 7FF8477140E0 388D2E00  
libkritaimage.dll!0x18d3f KisTileDataSwapper::run+0x2f
7FF83D15169B    
Qt5Core.dll!0x2169b QThread::qt_metacall+0x68b
7FF891807BD4    
KERNEL32.DLL!0x17bd4 BaseThreadInitThunk+0x14
7FF8932CCE71    
ntdll.dll!0x6ce71 RtlUserThreadStart+0x21

00014000-000140F9 krita.exe
7FF89326-7FF89345 ntdll.dll 6.2.18362.267
7FF8917F-7FF8918A2000 KERNEL32.DLL  6.2.18362.86
7FF89028-7FF890523000 KERNELBASE.dll6.2.18362.267
7FF8918B-7FF89194E000 msvcrt.dll7.0.18362.1
7FF884DA-7FF884DDF000 libkritaglobal.dll
7FF86693-7FF866A64000 libkritawidgetutils.dll
7FF8145E-7FF815A8F000 libkritaui.dll
7FF84726-7FF84778D000 libkritaimage.dll
6144-6145A000 libgcc_s_seh-1.dll
6FC4-6FDA5000 libstdc++-6.dll
7FF88120-7FF88125E000 libKF5ConfigCore.dll
7FF891F7-7FF892103000 USER32.dll6.2.18362.267
7FF87F3D-7FF87F426000 libKF5I18n.dll
7FF89129-7FF8912B1000 win32u.dll6.2.18362.295
7FF83D13-7FF83D75B000 Qt5Core.dll   5.12.4.0
7FF891A9-7FF891AB6000 GDI32.dll 6.2.18362.1
7FF891EC-7FF891F63000 ADVAPI32.dll  6.2.18362.1
7FF830A0-7FF83101A000 Qt5Gui.dll5.12.4.0
7FF890E0-7FF890F94000 gdi32full.dll 6.2.18362.295
7FF8462E-7FF84684C000 Qt5Widgets.dll5.12.4.0
7FF891D6-7FF891EB6000 ole32.dll 6.2.18362.113
7FF892D1-7FF892DA7000 sechost.dll   6.2.18362.267
7FF890D6-7FF890DFE000 msvcp_win.dll 6.2.18362.267
7FF89287-7FF892BA6000 combase.dll   6.2.18362.267
7FF89119-7FF89128A000 ucrtbase.dll  6.2.18362.267
7FF88CE6-7FF88CE6E000 libkritaversion.dll
0060-0072 RPCRT4.dll6.2.18362.1
7FF890FC-7FF89104 bcryptPrimitives.dll  6.2.18362.295
7FF89211-7FF8927F2000 SHELL32.dll   6.2.18362.295
7FF87F0F-7FF87F12B000 Qt5Xml.dll5.12.4.0
7FF87D22-7FF87D2B3000 libkritaodf.dll
7FF8912C-7FF89130A000 cfgmgr32.dll  6.2.18362.1
7FF892BB-7FF892C59000 shcore.dll6.2.18362.1
7FF88101-7FF881033000 libkritaplugin.dll
7FF8808B-7FF8808D9000 libKF5ConfigGui.dll
7FF8774D-7FF877565000 libKF5CoreAddons.dll
7FF8905E-7FF890D5C000 windows.storage.dll   6.2.18362.295
7FF87F0C-7FF87F0EA000 libKF5GuiAddons.dll
7FF89014-7FF89015F000 profapi.dll   6.2.18362.1
7FF884CA-7FF884CBF000 libkritacommand.dll
7FF86680-7FF86692B000 libKF5WidgetsAddons.dll
7FF87E8A-7FF87E8DD000 libKF5ItemViews.dll
7FF8901A-7FF8901EA000 powrprof.dll  6.2.18362.1
7FF87E76-7FF87E798000 libkritametadata.dll
7FF89013-7FF89014 UMPDC.dll
7FF87EA0-7FF87EA2D000 libKF5WindowSystem.dll
7FF852F6-7FF8531E1000 libkritapigment.dll
7FF89195-7FF8919A2000 shlwapi.dll   6.2.18362.1
7FF891C7-7FF891CDF000 WS2_32.dll6.2.18362.1
7FF87D1C-7FF87D21F000 libkritapsd.dll
7FF89016-7FF890171000 kernel.appcore.dll6.2.18362.1
7FF87E87-7FF87E892000 libkritastore.dll
7FF890FA-7FF890FB7000 cryptsp.dll   6.2.18362.1
6494-64955000 libwinpthread-1.dll   1.0.0.0
7FF88C20-7FF88C20E000 libkritacolor.dll
7FF85C45-7FF85C663000 libkritaflake.dll
7FF865BE-7FF865CF1000 libfftw3.dll
7FF87D09-7FF87D0B1000 libkritaimpex.dll
7FF8789C-7FF878A18000 Qt5PrintSupport.dll   5.12.4.0
7FF87746-7FF8774CC000 libkritalibbrush.dll
7FF8919B-7FF891A7F000 comdlg32.dll  6.2.18362.1
7FF87920-7FF87924E000 libHalf.dll
7FF8652A-7FF8653CB000 

[krita] [Bug 411081] Crash Without Warning

2019-08-19 Thread wolthera
https://bugs.kde.org/show_bug.cgi?id=411081

wolthera  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||griffinval...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from wolthera  ---
Hey, could you see if you can provide a backtrace?


Instructions are here:
https://docs.krita.org/en/reference_manual/dr_minw_debugger.html

We can use the backtrace as a blackbox to figure out where Krita is crashing
and then more efficiently fix the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.