[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 --- Comment #7 from Tymond --- In the 4.3.0 if you do: 1. Write text 2. Change the font, font size, color, etc. etc. 3. Delete text 4. Write new text It would be: Before the fix: - text uses settings from point 1. After the fix (and expected): - text uses settings from point 2. @Tyson the version you're using is one day too old for this fix :) Maybe you could download a new one and check. If not, I'll just wait for beta testing. In any case, thanks for checking! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 Tyson Tan changed: What|Removed |Added CC||tyson...@tysontan.com --- Comment #6 from Tyson Tan --- Hi Tymond, coming from your request in bug 392473 here. I'm not sure I understand this bug. With krita-4.4.0-alpha-69d2027-x86_64.appimage, when I cleared the Rich Text Editor, it still remembers the old settings. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 --- Comment #5 from Tymond --- Git commit e6de213a7e3fdeade18a9ee09019907793bf7e08 by Agata Cacko. Committed on 15/09/2020 at 15:31. Pushed by tymond into branch 'krita/4.3'. Fix text marked modified when Text Editor is opened Before this commit, text would be marked modified if you opened a document with text and just opened the Text Editor. This was a regression from a24aa5c7 (a fix for bug 411393). This commit fixes that behaviour. Additionally I renamed setShape to setInitialShape because the fix relies on the function being called only once, at the very opening of the editor. (cherry picked from commit fe20ff434cd7fded59c85b2d5a33eded3aca1fe9) M +2-2plugins/tools/svgtexttool/SvgTextEditor.cpp M +1-1plugins/tools/svgtexttool/SvgTextEditor.h M +1-1plugins/tools/svgtexttool/SvgTextTool.cpp https://invent.kde.org/graphics/krita/commit/e6de213a7e3fdeade18a9ee09019907793bf7e08 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 --- Comment #4 from Tymond --- Git commit fe20ff434cd7fded59c85b2d5a33eded3aca1fe9 by Agata Cacko. Committed on 15/09/2020 at 15:26. Pushed by tymond into branch 'master'. Fix text marked modified when Text Editor is opened Before this commit, text would be marked modified if you opened a document with text and just opened the Text Editor. This was a regression from a24aa5c7 (a fix for bug 411393). This commit fixes that behaviour. Additionally I renamed setShape to setInitialShape because the fix relies on the function being called only once, at the very opening of the editor. M +2-2plugins/tools/svgtexttool/SvgTextEditor.cpp M +1-1plugins/tools/svgtexttool/SvgTextEditor.h M +1-1plugins/tools/svgtexttool/SvgTextTool.cpp https://invent.kde.org/graphics/krita/commit/fe20ff434cd7fded59c85b2d5a33eded3aca1fe9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 Tymond changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/a24aa5c79 |hics/krita/commit/19393578b |905163619a1ac7d6659d79de54a |bb1b100ae760085424acf32170e |cdc4|c4c5 --- Comment #3 from Tymond --- Git commit 19393578bbb1b100ae760085424acf32170ec4c5 by Agata Cacko. Committed on 13/09/2020 at 18:32. Pushed by tymond into branch 'krita/4.3'. Fix font options after clearing the rich text editor Before this commit, if the rich text editor for SVG Text Tool was cleared, the options for the text would be lost and changed to the default ones. This commit fixes it by remembering the old options and restoring them. Note: it might be beneficial to consider figuring out how to set the Format in the location just before the text instead, because that would (partially) fix bug 411739. (cherry picked from commit a24aa5c79905163619a1ac7d6659d79de54acdc4) M +201 -15 plugins/tools/svgtexttool/SvgTextEditor.cpp M +3-0plugins/tools/svgtexttool/SvgTextEditor.h M +8-8plugins/tools/svgtexttool/SvgTextTool.action https://invent.kde.org/graphics/krita/commit/19393578bbb1b100ae760085424acf32170ec4c5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 Tymond changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/a24aa5c79 ||905163619a1ac7d6659d79de54a ||cdc4 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #2 from Tymond --- Git commit a24aa5c79905163619a1ac7d6659d79de54acdc4 by Agata Cacko. Committed on 13/09/2020 at 18:31. Pushed by tymond into branch 'master'. Fix font options after clearing the rich text editor Before this commit, if the rich text editor for SVG Text Tool was cleared, the options for the text would be lost and changed to the default ones. This commit fixes it by remembering the old options and restoring them. Note: it might be beneficial to consider figuring out how to set the Format in the location just before the text instead, because that would (partially) fix bug 411739. M +201 -15 plugins/tools/svgtexttool/SvgTextEditor.cpp M +3-0plugins/tools/svgtexttool/SvgTextEditor.h M +8-8plugins/tools/svgtexttool/SvgTextTool.action https://invent.kde.org/graphics/krita/commit/a24aa5c79905163619a1ac7d6659d79de54acdc4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 Tymond changed: What|Removed |Added CC||tamtamy.tym...@gmail.com Status|CONFIRMED |ASSIGNED Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 411393] bug(SVG Text Tool): cleaned “Rich text” field
https://bugs.kde.org/show_bug.cgi?id=411393 wolthera changed: What|Removed |Added CC||griffinval...@gmail.com Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from wolthera --- Yes, this is because the text defaults to the basic markup. There will probably never be resolved until we change the current editor. Bugzilla doesn't have markup, we use plaintext to describe our issues here. -- You are receiving this mail because: You are watching all bug changes.
