[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #16 from acc4commissi...@gmail.com --- I was wrong. Sorry. It seems to be a different problem and wasn't solved at all. I will write a separated bug report. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #15 from acc4commissi...@gmail.com --- (In reply to acc4commissions from comment #14) > It is certainly reduced drastically in the latest nightly, but I don't think > it's 'fixed' enough to call it so. It still happens when the size goes over > 750~850px. Although it's fairly usable as it is. For now I'm personally fine if you need to ignore this. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 acc4commissi...@gmail.com changed: What|Removed |Added CC||acc4commissi...@gmail.com --- Comment #14 from acc4commissi...@gmail.com --- It is certainly reduced drastically in the latest nightly, but I don't think it's 'fixed' enough to call it so. It still happens when the size goes over 750~850px. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/0ca332c7089c69 |krita/commit/06cb53798c1c6a |0a62c6d7b66515fe9aacdabbdb |c69d28b3d280b86513424c6923 --- Comment #13 from Dmitry Kazakov --- Git commit 06cb53798c1c6ac69d28b3d280b86513424c6923 by Dmitry Kazakov. Committed on 31/01/2020 at 14:14. Pushed by dkazakov into branch 'krita/4.2'. Fix hiccups when doing canvas actions Fixed KisSignalCompressor became too precise and tries to keep the interval too hard. Sometimes the signal handler is too slow, in such cases we should still give some time for event loop to execute. To achieve that, KisSignalCompressor now has an additional operational mode: "additive interval mode". When this mode is active, then interval time is counted from the moment, when the execution path is returned from the signal handler. In "precise interval mode" (default), in reverse, the interval is counted from the moment, when start() signal arrives. Related: bug 414576 CC:kimages...@kde.org M +23 -3libs/global/kis_signal_compressor.cpp M +7-0libs/global/kis_signal_compressor.h M +36 -4libs/global/tests/KisSignalCompressorTest.cpp M +2-0libs/global/tests/KisSignalCompressorTest.h M +3-1libs/ui/input/kis_input_manager_p.cpp https://invent.kde.org/kde/krita/commit/06cb53798c1c6ac69d28b3d280b86513424c6923 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/ ||krita/commit/0ca332c7089c69 ||0a62c6d7b66515fe9aacdabbdb Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #12 from Dmitry Kazakov --- Git commit 0ca332c7089c690a62c6d7b66515fe9aacdabbdb by Dmitry Kazakov. Committed on 31/01/2020 at 14:06. Pushed by dkazakov into branch 'master'. Fix hiccups when doing canvas actions Fixed KisSignalCompressor became too precise and tries to keep the interval too hard. Sometimes the signal handler is too slow, in such cases we should still give some time for event loop to execute. To achieve that, KisSignalCompressor now has an additional operational mode: "additive interval mode". When this mode is active, then interval time is counted from the moment, when the execution path is returned from the signal handler. In "precise interval mode" (default), in reverse, the interval is counted from the moment, when start() signal arrives. Related: bug 414576 CC:kimages...@kde.org M +23 -3libs/global/kis_signal_compressor.cpp M +7-0libs/global/kis_signal_compressor.h M +36 -4libs/global/tests/KisSignalCompressorTest.cpp M +2-0libs/global/tests/KisSignalCompressorTest.h M +3-1libs/ui/input/kis_input_manager_p.cpp https://invent.kde.org/kde/krita/commit/0ca332c7089c690a62c6d7b66515fe9aacdabbdb -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Boudewijn Rempt changed: What|Removed |Added Keywords||regression, release_blocker -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #11 from Dmitry Kazakov --- It must be related to https://bugs.kde.org/show_bug.cgi?id=414576 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Tymond changed: What|Removed |Added Assignee|tamtamy.tym...@gmail.com|krita-bugs-n...@kde.org Status|ASSIGNED|CONFIRMED --- Comment #10 from Tymond --- Git bisect points to this commit: tymon@yoga ~/devsec/krita ((no branch, bisect started on 5c6213e04c)) $ git bisect bad 34f3a4a815b3e489eeb4397045738eb2aa74e2d8 is the first bad commit commit 34f3a4a815b3e489eeb4397045738eb2aa74e2d8 Author: Dmitry Kazakov Date: Tue Oct 8 21:13:10 2019 +0300 Refactor signal compressor to have better timing properties * before: emits signals with time range [1.0...2.0] * interval * after: emits signals with time range [0.5...1.5] * interval Bascially, now it handles it much better when interval is around 10-20 ms. With the old version it caused KisCanvas2 to drop frames and look ugly when the user pans the canvas. CCBUG:409460 # Conflicts: # libs/global/tests/CMakeLists.txt :04 04 6fc3790e429be8218d33ac96d7774b373ebf03a2 d4ec7f7d30cb7e34ac05bfb91e612a02d1207503 M libs -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Tymond changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Tymond changed: What|Removed |Added Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #9 from Kruthers --- Excellent, thanks for looking into it! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Tymond changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 --- Comment #8 from Tymond --- @Kruthers Thanks! With Airbrush_Soft I can reproduce it as well. Thank you so much for this observation, will help immensely :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #7 from Kruthers --- Sorry for multiple comments... I forgot to mention that I tried all options for "Outline Shape" under Configure Krita -> General -> Cursor, and it made no difference. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #6 from Kruthers --- BTW, while testing just now I noticed something; the brush size freezing seems to be caused by the type of brush. Some of the brushes don't have the glitch at all, and some have it but not as bad: b)_Basic-1: no glitch at all, resizes smoothly b)_Airbrush_Soft: bad glitch, freezes for a long time as size gets large y)_Texture_Large_Splat: moderate glitch; freezes for only a few seconds when large Most of the brushes are like Airbrush Soft; the glitch causes freezing for a long time. Hope you guys can recreate this; I have to stick with 4.2.7 for now. If there's anything else you want me test just ask. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #5 from Kruthers --- @Tymond - It appears to make no difference; I see the same freezing effect with instant preview on or off. And no, I do NOT seem to experience the bug in that other ticket. I have zoom bound differently (CTRL-middle mouse drag) but that shouldn't matter. I do see some difference with instant preview on/off though; zooming is chunkier, and pauses for a fraction of a second here and there w/ instant preview on, and is smoother when off. But it's not serious. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Tymond changed: What|Removed |Added CC||tamtamy.tym...@gmail.com Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #4 from Tymond --- @Kruthers do you experience bug 414576 as well? If so, can you please answer Dmitry's question, that is, do you have View -> Instant Preview option turned on or off? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #3 from Bug Janitor Service --- Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 --- Comment #2 from Kruthers --- (In reply to Boudewijn Rempt from comment #1) > I'm sorry, but I cannot reproduce this with the 4.2.8 appimage with either > my tablet or my mouse. Is your mouse by any chance a hires gaming mouse? Can > you also check the latest nightly build? See > https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ Sure, I just tried krita-4.3.0-prealpha-9526f28-x86_64.appimage and it freezes the same as 4.2.8 for me. Yes it is a gaming mouse. But the tablet (Wacom Intuos) has the same problem so that shouldn't be the cause I assume. Just to be safe though I unplugged it and used a regular Logitech mouse but it made no difference. I tried both versions of Krita on a laptop and 4.2.8 was slower than 4.2.7, but not nearly as bad as this report, ie. not to the point of freezing up for long periods of time. This is strange because the laptop is underpowered compared to the desktop machine. However, I was able to partially recreate the problem on the laptop by increasing the maximum brush size to 2000px. Then when I scrubbed the scale values back and forth in the larger sizes (say between 1500 and 2000px), 4.2.8 was freezing for a few seconds at a time, whereas 4.2.7 was merely sluggish. Not sure why my desktop severely chokes on this, but you should be able to experience the performance decrease with the above procedure... A few others things I tried: - completely fresh preferences (under a different account so I wouldn't miss something) - disabling canvas acceleration Neither made a difference. Does the fact that it happens with canvas acceleration disabled rule out graphics drivers being the cause? The only other thing I can think of is that my desktop is an AMD cpu and the laptop is Intel. Could the brush resize code be using intel-specific instructions? In any case, thanks for looking into this. I will be happy to do any other tests you can think of. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415773] Krita 4.2.8 freezes when SHIFT-resizing brush
https://bugs.kde.org/show_bug.cgi?id=415773 Boudewijn Rempt changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC||b...@valdyas.org Resolution|--- |WAITINGFORINFO --- Comment #1 from Boudewijn Rempt --- I'm sorry, but I cannot reproduce this with the 4.2.8 appimage with either my tablet or my mouse. Is your mouse by any chance a hires gaming mouse? Can you also check the latest nightly build? See https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ -- You are receiving this mail because: You are watching all bug changes.
