[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #41 from Dmitry Kazakov --- Thank you a lot for testing! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #40 from to...@offensivelytolerant.com --- (In reply to Dmitry Kazakov from comment #37) > Hi, Tonja! > > Could you please check this AppImage package? Does it fix the problem for > you? > https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/651/ Hello Dmitry, it's fixed for me too in this package. Sample file opened without problem after a few moments. Thanks you all! You're doing an amazing work. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891
Dmitry Kazakov changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
|krita/commit/a2276890fa0e2d |krita/commit/df9d1aafd52d4b
|32535e98796ef6b6ec1f906bf8 |bdfe78ec6f742d9d321a3dc8b5
--- Comment #39 from Dmitry Kazakov ---
Git commit df9d1aafd52d4bbdfe78ec6f742d9d321a3dc8b5 by Dmitry Kazakov.
Committed on 17/02/2020 at 08:25.
Pushed by dkazakov into branch 'master'.
Fix hangup when loaging image with generator/file layers
When loading layers we shouldn't "block" updates, we shoudl just drop them.
When loading is finished, KisImage::initialRefreshGraph() will be called
anyway, and the projections will become initialized.
To implement proper dropping of the updates I had to (finally) implement
nested projection updates filters. Before the patch, there could be only
one filter installed. Now they can be stacked in a nested way. What is
more the caller now gets a special ticket ("cookie") for the installed
filter, so the system can catch interleaved/non-nested filter handling,
which is prohibited.
# Conflicts:
# libs/image/kis_suspend_projection_updates_stroke_strategy.cpp
# libs/image/tests/kis_strokes_queue_test.cpp
M +52 -23 libs/image/kis_image.cc
M +43 -6libs/image/kis_image.h
M +4-2libs/image/kis_image_interfaces.h
M +3-2libs/image/kis_projection_updates_filter.h
M +9-5libs/image/kis_regenerate_frame_stroke_strategy.cpp
M +4-2libs/image/kis_stroke_strategy_factory.h
M +6-11 libs/image/kis_strokes_queue.cpp
M +1-2libs/image/kis_strokes_queue.h
M +29 -17 libs/image/kis_suspend_projection_updates_stroke_strategy.cpp
M +8-2libs/image/kis_suspend_projection_updates_stroke_strategy.h
M +1-0libs/image/kis_types.h
M +2-7libs/image/kis_update_scheduler.cpp
M +3-8libs/image/kis_update_scheduler.h
M +8-8libs/image/tests/kis_strokes_queue_test.cpp
M +3-1libs/ui/KisDocument.cpp
M +0-14 libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp
M +2-2plugins/impex/kra/kra_converter.cpp
https://invent.kde.org/kde/krita/commit/df9d1aafd52d4bbdfe78ec6f742d9d321a3dc8b5
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #38 from Shlomi Fish --- (In reply to Dmitry Kazakov from comment #37) > Hi, Tonja! > > Could you please check this AppImage package? Does it fix the problem for > you? > https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/651/ Just for the record - the bug seems fixed with that .appimage here. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #37 from Dmitry Kazakov --- Hi, Tonja! Could you please check this AppImage package? Does it fix the problem for you? https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/651/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #36 from Boudewijn Rempt --- I'll kick off builds. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891
Dmitry Kazakov changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Latest Commit||https://invent.kde.org/kde/
||krita/commit/a2276890fa0e2d
||32535e98796ef6b6ec1f906bf8
Resolution|--- |FIXED
--- Comment #35 from Dmitry Kazakov ---
Git commit a2276890fa0e2d32535e98796ef6b6ec1f906bf8 by Dmitry Kazakov.
Committed on 14/02/2020 at 14:13.
Pushed by rempt into branch 'krita/4.2'.
Fix hangup when loaging image with generator/file layers
When loading layers we shouldn't "block" updates, we shoudl just drop them.
When loading is finished, KisImage::initialRefreshGraph() will be called
anyway, and the projections will become initialized.
To implement proper dropping of the updates I had to (finally) implement
nested projection updates filters. Before the patch, there could be only
one filter installed. Now they can be stacked in a nested way. What is
more the caller now gets a special ticket ("cookie") for the installed
filter, so the system can catch interleaved/non-nested filter handling,
which is prohibited.
M +52 -23 libs/image/kis_image.cc
M +43 -6libs/image/kis_image.h
M +4-2libs/image/kis_image_interfaces.h
M +3-2libs/image/kis_projection_updates_filter.h
M +9-5libs/image/kis_regenerate_frame_stroke_strategy.cpp
M +4-2libs/image/kis_stroke_strategy_factory.h
M +6-11 libs/image/kis_strokes_queue.cpp
M +1-2libs/image/kis_strokes_queue.h
M +29 -17 libs/image/kis_suspend_projection_updates_stroke_strategy.cpp
M +8-2libs/image/kis_suspend_projection_updates_stroke_strategy.h
M +1-0libs/image/kis_types.h
M +2-7libs/image/kis_update_scheduler.cpp
M +3-8libs/image/kis_update_scheduler.h
M +8-8libs/image/tests/kis_strokes_queue_test.cpp
M +3-1libs/ui/KisDocument.cpp
M +0-14 libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp
M +2-2plugins/impex/kra/kra_converter.cpp
https://invent.kde.org/kde/krita/commit/a2276890fa0e2d32535e98796ef6b6ec1f906bf8
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #34 from Shlomi Fish --- (In reply to Boudewijn Rempt from comment #33) > I doubt that a mageia build has the patches; better test with the nightly > stable appimage. It happens with the prealpha appimage from https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/lastStableBuild/ too. Checked now (mageia v8 x86-64). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #33 from Boudewijn Rempt --- I doubt that a mageia build has the patches; better test with the nightly stable appimage. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #32 from Shlomi Fish --- The bug still happens with krita-4.2.8.2-2.mga8 on mageia x86-64 v8. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #31 from to...@offensivelytolerant.com --- (In reply to Dmitry Kazakov from comment #27) > Hi, Tonja! > > Could you please check the latest nightly build? I think I have fixed this > bug in this commit: > https://invent.kde.org/kde/krita/commit/ > 45fa9fb936bb00faa75865b8663d20bbb0785ea3 > > Here is a link for packages: > https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ Hi! Thanks for your work ; however, I can only confirm that today's nightly build (a6d06f8) still has the issue... With the waiting operation pop-up, as Vanyossi mentioned -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #30 from vanyossi --- Created attachment 125999 --> https://bugs.kde.org/attachment.cgi?id=125999=edit Trace after interrumpting loading document. Im getting almost the same behaviour in master. The only difference now is that the waiting bar "Waiting for image operation to complete" is now displayed. However it never ends loading. I interrupted execution and attached the backtrace. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #29 from Dmitry Kazakov --- The bug is still reproducible in 4.2 branch -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 Dmitry Kazakov changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|FIXED |--- --- Comment #28 from Dmitry Kazakov --- Ah, wait, the bug is in 4.2, not in master :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 Dmitry Kazakov changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO Resolution|--- |FIXED --- Comment #27 from Dmitry Kazakov --- Hi, Tonja! Could you please check the latest nightly build? I think I have fixed this bug in this commit: https://invent.kde.org/kde/krita/commit/45fa9fb936bb00faa75865b8663d20bbb0785ea3 Here is a link for packages: https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com --- Comment #26 from Dmitry Kazakov --- I'll take this bug -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 Boudewijn Rempt changed: What|Removed |Added Keywords||regression, release_blocker -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #25 from vanyossi --- Bug introduced by commit 2d98dc83db71eba0f8775604ee75d049da505c20 (HEAD) Author: Dmitry Kazakov Date: Wed Sep 11 20:13:33 2019 +0300 Implement undoable and thread-safe Assign Profile functionality The patch basically implements KisAssignProfileProcessingVisitor which assigns a profile using strokes framework. The action is also undoable now. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 --- Comment #24 from vanyossi --- I can reproduce this bug. It is an infinite wait trying to process all events. I still don't know why it happens but I can at least get out of the waiting by changing the call in kis_file_layer.cpp:70 calls reloadImage() -> fileChangedCompressed(true) to false, which makes the image load normally -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 415891] Project file loads perfectly fine in seconds in 4.2.7.1, never finishes loading in 4.2.8
https://bugs.kde.org/show_bug.cgi?id=415891 vanyossi changed: What|Removed |Added CC||ghe...@gmail.com Summary|Project file loads |Project file loads |perfectly fine in seconds |perfectly fine in seconds |in 4.1.7, never finishes|in 4.2.7.1, never finishes |loading in 4.2.8|loading in 4.2.8 -- You are receiving this mail because: You are watching all bug changes.
