[krita] [Bug 417406] Undo to empty undoes only what stack size is set to and doesn't clear to empty.

2020-02-13 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=417406

Ahab Greybeard  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #4 from Ahab Greybeard  ---
 refers to the state of the undo stack, not the document.
If you undo actions, they stay on the stack in case you want to redo them, but
undone actions are cleared as soon as you perform any action, as can be seen by
observing the undo history.

The undo stack is not saved with the document, it's only for each document per
session. Because of this, the second thing , the random thing that you noticed
wouldn't actually matter. If your stack size is set to 100 then if it's
actually 100 or 99 is not of practical relevance. You can set it to 101 if you
have a definite need for exactly 100 undo actions capability.

Setting to Resolved Not A Bug but you can reopen this in the future if this
particular behaviour is definite and causes you problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 417406] Undo to empty undoes only what stack size is set to and doesn't clear to empty.

2020-02-13 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=417406

--- Comment #3 from lemp...@gmail.com ---
(In reply to Ahab Greybeard from comment #2)
> re. "Example: If stack size set to 10, I do 12 strokes, click on empty to
> clear everything last 10 strokes disappear while the first 2 are left on the
> canvas."
> 
> This is what I'd expect. You can't undo deeper than the stack size. The
> first two strokes are no longer recorded on the stack.
> 
> re. "then I clicked on empty and out of 2 remaining strokes 1 disappeared
> and 1 stayed. I tried again, this time both strokes disappeared."
> 
> I haven't seen that behaviour after a couple of tries. If it's a random
> thing, roughly what percentage of the time have you seen it happening?

I see, I'd expect the same behaviour Photoshop has with the same function when
it returns the document to its initial stage (let's say you save your work,
come back to it later, load the doc make changes and even if you go over the
undo stack limit you can always come back to the doc before changes quickly in
that particular session), that's my bad if that's not how it is meant to work
(I think I saw the same functionality in some other programs but definitely my
bad).

When it comes to the second part, it's really hard to tell how often certainly
not often or at least I haven't found a way to replicate it with decent success
(and considering during work I have a high number for undo stack noticing if if
happens or not mid work is impossible at that point unless it's early with
blank canvas), I remember something similar happening a few versions back last
year when there was something wrong with undo stack but that as fixed so I'll
say we can probably close this or delete this report if you know how (?)
because the main part is as you say Krita functionality I failed reaching that
point during my research before reporting here and the second half is so random
that I don't even know where to properly start.

Thank you very much and sorry to take your time on bug testing. :0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 417406] Undo to empty undoes only what stack size is set to and doesn't clear to empty.

2020-02-13 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=417406

Ahab Greybeard  changed:

   What|Removed |Added

 CC||ahab.greybe...@hotmail.co.u
   ||k

--- Comment #2 from Ahab Greybeard  ---
re. "Example: If stack size set to 10, I do 12 strokes, click on empty to clear
everything last 10 strokes disappear while the first 2 are left on the canvas."

This is what I'd expect. You can't undo deeper than the stack size. The first
two strokes are no longer recorded on the stack.

re. "then I clicked on empty and out of 2 remaining strokes 1 disappeared and 1
stayed. I tried again, this time both strokes disappeared."

I haven't seen that behaviour after a couple of tries. If it's a random thing,
roughly what percentage of the time have you seen it happening?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 417406] Undo to empty undoes only what stack size is set to and doesn't clear to empty.

2020-02-10 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=417406

--- Comment #1 from lemp...@gmail.com ---
Forgot to mention, if you go step by step (by clicking on undo history) it gets
messed up, I can't tell exactly how or why, the undo with empty just start
behaving differently.

I tried this: stack history set to 10, 12 strokes made, I went 1-by-1 back in
undo history by clicking in undo history docker, 2 strokes remain (not clicked
on empty yet!) which is expected, then I clicked on empty and out of 2
remaining strokes 1 disappeared and 1 stayed. I tried again, this time both
strokes disappeared.

As you can see it's difficult to find out what exactly happens in a 1-by-1 case
as it's not regular but kind of random (?) while clicking on empty right away
gives consistently 2 strokes out of 12.

(Btw I tried increasing the stack size to 100, same result as with 10)

-- 
You are receiving this mail because:
You are watching all bug changes.