[krita] [Bug 418922] On large document, merging down a layer results in different layer getting selected after the merge
https://bugs.kde.org/show_bug.cgi?id=418922 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/8fd316da1 |hics/krita/commit/87d27964b |1d6ec5c8a129bc88dd042fb0bcd |5893f67c95deb03d73198a8acb6 |c659|849a --- Comment #3 from Dmitry Kazakov --- Git commit 87d27964b5893f67c95deb03d73198a8acb6849a by Dmitry Kazakov. Committed on 19/08/2020 at 22:09. Pushed by dkazakov into branch 'master'. Fix temporary wrongly selected layer when merging down huge layers The problem happened because of our workaround for Qt's removed item avoidance algorithm. On element removal, Qt selects an item above that, but we need a reverse, below it. The previous implementation just tried to fix Qt's behavior after the removal, but that didn't seem to work correctly in case of merge down. Therefore, this patch implements a special signal that is fired *before* beginRemoveRows(), that fixes the selection before Qt can lay its hands on it. Related: bug 345601 M +15 -0libs/ui/kis_node_filter_proxy_model.cpp M +4-0libs/ui/kis_node_filter_proxy_model.h M +1-0libs/ui/kis_node_model.cpp M +1-0libs/ui/kis_node_model.h M +9-9plugins/dockers/layerdocker/LayerBox.cpp M +1-1plugins/dockers/layerdocker/LayerBox.h https://invent.kde.org/graphics/krita/commit/87d27964b5893f67c95deb03d73198a8acb6849a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418922] On large document, merging down a layer results in different layer getting selected after the merge
https://bugs.kde.org/show_bug.cgi?id=418922 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/8fd316da1 ||1d6ec5c8a129bc88dd042fb0bcd ||c659 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Git commit 8fd316da11d6ec5c8a129bc88dd042fb0bcdc659 by Dmitry Kazakov. Committed on 19/08/2020 at 22:08. Pushed by dkazakov into branch 'krita/4.3'. Fix temporary wrongly selected layer when merging down huge layers The problem happened because of our workaround for Qt's removed item avoidance algorithm. On element removal, Qt selects an item above that, but we need a reverse, below it. The previous implementation just tried to fix Qt's behavior after the removal, but that didn't seem to work correctly in case of merge down. Therefore, this patch implements a special signal that is fired *before* beginRemoveRows(), that fixes the selection before Qt can lay its hands on it. Related: bug 345601 M +15 -0libs/ui/kis_node_filter_proxy_model.cpp M +4-0libs/ui/kis_node_filter_proxy_model.h M +1-0libs/ui/kis_node_model.cpp M +1-0libs/ui/kis_node_model.h M +9-9plugins/dockers/layerdocker/LayerBox.cpp M +1-1plugins/dockers/layerdocker/LayerBox.h https://invent.kde.org/graphics/krita/commit/8fd316da11d6ec5c8a129bc88dd042fb0bcdc659 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418922] On large document, merging down a layer results in different layer getting selected after the merge
https://bugs.kde.org/show_bug.cgi?id=418922 Boudewijn Rempt changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Platform|Other |Compiled Sources -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418922] On large document, merging down a layer results in different layer getting selected after the merge
https://bugs.kde.org/show_bug.cgi?id=418922 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 418922] On large document, merging down a layer results in different layer getting selected after the merge
https://bugs.kde.org/show_bug.cgi?id=418922 Boudewijn Rempt changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||b...@valdyas.org --- Comment #1 from Boudewijn Rempt --- Yes, I see this happen. -- You are receiving this mail because: You are watching all bug changes.
