[krita] [Bug 419189] Krita crashes when undo a clear Assistants
https://bugs.kde.org/show_bug.cgi?id=419189 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/8e3f993a77b129 |krita/commit/0ac7f9fde8f1bb |e5b5406e753b34efc8b5d4c719 |fc4823d03753d47fc43b059e74 --- Comment #4 from Boudewijn Rempt --- Git commit 0ac7f9fde8f1bbfc4823d03753d47fc43b059e74 by Boudewijn Rempt, on behalf of Emmet O'Neill. Committed on 05/05/2020 at 07:27. Pushed by rempt into branch 'krita/4.3'. Fixed bad assertion and failure to undo removeAllAssistants. KisAssistantTool::removeAllAssistants function wasn't making correct use of EditAssistantsCommand. EditAssistantsCommand also contained a flawed and unnecessary assertion. Thanks for the help Eoin. (cherry picked from commit 8e3f993a77b129e5b5406e753b34efc8b5d4c719) M +10 -11 plugins/assistants/Assistants/EditAssistantsCommand.cpp M +6-5plugins/assistants/Assistants/kis_assistant_tool.cc https://invent.kde.org/kde/krita/commit/0ac7f9fde8f1bbfc4823d03753d47fc43b059e74 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 419189] Krita crashes when undo a clear Assistants
https://bugs.kde.org/show_bug.cgi?id=419189 Emmet O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/ ||krita/commit/8e3f993a77b129 ||e5b5406e753b34efc8b5d4c719 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Emmet O'Neill --- Git commit 8e3f993a77b129e5b5406e753b34efc8b5d4c719 by Emmet O'Neill. Committed on 05/05/2020 at 01:46. Pushed by emmetoneill into branch 'master'. Fixed bad assertion and failure to undo removeAllAssistants. KisAssistantTool::removeAllAssistants function wasn't making correct use of EditAssistantsCommand. EditAssistantsCommand also contained a flawed and unnecessary assertion. Thanks for the help Eoin. M +10 -11 plugins/assistants/Assistants/EditAssistantsCommand.cpp M +6-5plugins/assistants/Assistants/kis_assistant_tool.cc https://invent.kde.org/kde/krita/commit/8e3f993a77b129e5b5406e753b34efc8b5d4c719 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 419189] Krita crashes when undo a clear Assistants
https://bugs.kde.org/show_bug.cgi?id=419189 Emmet O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |emmetoneill@gmail.com CC||emmetoneill@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 419189] Krita crashes when undo a clear Assistants
https://bugs.kde.org/show_bug.cgi?id=419189 Boudewijn Rempt changed: What|Removed |Added Keywords||triaged CC||b...@valdyas.org --- Comment #2 from Boudewijn Rempt --- Note: the assert should not be present in release builds, but just removing them doesn't make undo work. There's a bit of work here. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 419189] Krita crashes when undo a clear Assistants
https://bugs.kde.org/show_bug.cgi?id=419189 Rebecca Breu changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||rebe...@rbreu.de --- Comment #1 from Rebecca Breu --- I can confirm this on 4.2.8, the 4.2.9 beta. My compiled master build gives me an assert: ASSERT (krita): "curAssistants.size() == assistants.size() + 1" in file /home/appimage/persistent/krita/plugins/assistants/Assistants/EditAssistantsCommand.cpp, line 62 -- You are receiving this mail because: You are watching all bug changes.
