[krita] [Bug 422428] Krita crashed when undoing

2020-11-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=422428

acc4commissi...@gmail.com changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #10 from acc4commissi...@gmail.com ---
(In reply to Tymond from comment #8)
> There was a question asked and unanswered. @acc4 do you remember this crash
> enough to answer? 
> 
> If not, what should be done about this report? Is the crash log helpful
> enough?

It's been a long time and I don't remember the detail. And I don't 'seem'
experience this anymore, so I guess it's good for me. At least for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-11-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=422428

--- Comment #9 from acc4commissi...@gmail.com ---
(In reply to Dmitry Kazakov from comment #7)
> Hi, acc4commissions!
> 
> Do you remember, did you use any snapshots functionality?
> 
> The backtrace looks quite like the one in bug 424697, but I don't think that
> the fix for bug 424697 will actually fix any bugs in undo. Unless you
> actually used snapshots. Otherwise we'll have to think how to reproduce this
> bug with undo (theoretically, it is possible and might be related to bug
> 426424)

No I didn't use the snapshot functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-11-09 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=422428

Tymond  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #8 from Tymond  ---
There was a question asked and unanswered. @acc4 do you remember this crash
enough to answer? 

If not, what should be done about this report? Is the crash log helpful enough?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-09-11 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=422428

Dmitry Kazakov  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=426424

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-09-11 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=422428

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #7 from Dmitry Kazakov  ---
Hi, acc4commissions!

Do you remember, did you use any snapshots functionality?

The backtrace looks quite like the one in bug 424697, but I don't think that
the fix for bug 424697 will actually fix any bugs in undo. Unless you actually
used snapshots. Otherwise we'll have to think how to reproduce this bug with
undo (theoretically, it is possible and might be related to bug 426424)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-09-11 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=422428

--- Comment #6 from Dmitry Kazakov  ---
Git commit cd4180b205e0077ec511cc02a73b42cec4ee85f2 by Dmitry Kazakov.
Committed on 11/09/2020 at 20:31.
Pushed by dkazakov into branch 'master'.

Fix a crash when recoverng the assistants via snapshots

Resetting the document via snapshots will add the fake decorations
layer itself, therefore we shouldn't try to execute
syncDecorationsWrapperLayerState() before the actual layers are cloned.
Related: bug 424697

M  +2-0libs/ui/KisDecorationsManager.cpp
M  +8-1libs/ui/KisDocument.cpp
M  +9-0libs/ui/kis_painting_assistants_decoration.cpp
M  +2-0libs/ui/kis_painting_assistants_decoration.h

https://invent.kde.org/graphics/krita/commit/cd4180b205e0077ec511cc02a73b42cec4ee85f2

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-09-11 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=422428

--- Comment #5 from Dmitry Kazakov  ---
Git commit 945bfad224b0c562dd81b57673fffb8e060855e4 by Dmitry Kazakov.
Committed on 11/09/2020 at 20:30.
Pushed by dkazakov into branch 'krita/4.3'.

Fix a crash when recoverng the assistants via snapshots

Resetting the document via snapshots will add the fake decorations
layer itself, therefore we shouldn't try to execute
syncDecorationsWrapperLayerState() before the actual layers are cloned.
Related: bug 424697

M  +2-0libs/ui/KisDecorationsManager.cpp
M  +8-1libs/ui/KisDocument.cpp
M  +9-0libs/ui/kis_painting_assistants_decoration.cpp
M  +2-0libs/ui/kis_painting_assistants_decoration.h

https://invent.kde.org/graphics/krita/commit/945bfad224b0c562dd81b57673fffb8e060855e4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-07-27 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=422428

--- Comment #4 from Tymond  ---
Note: bug 424697 shows a way to reproduce using a snapshot and assistants. I
didn't mark that one as the main bug because this one is the oldest and because
I'm not sure if snapshots and assistants are necessary (still, having a way to
reproduce is useful).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-07-27 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=422428

Tymond  changed:

   What|Removed |Added

 CC||nmaghfurus...@gmail.com

--- Comment #3 from Tymond  ---
*** Bug 424697 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-07-27 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=422428

Tymond  changed:

   What|Removed |Added

 CC||gudv...@gmail.com

--- Comment #2 from Tymond  ---
*** Bug 423740 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 422428] Krita crashed when undoing

2020-07-27 Thread Tymond
https://bugs.kde.org/show_bug.cgi?id=422428

Tymond  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
   Severity|normal  |crash
 CC||tamtamy.tym...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Tymond  ---
Since there is a backtrace and two duplicates, let's confirm it.

-- 
You are receiving this mail because:
You are watching all bug changes.