[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-11-04 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=425370

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/99f7f3039 |hics/krita/commit/3a9828651
   |1c23f20c2d53161997104975641 |dd5942885b80aa508b59e4ea3bb
   |6ef4|3ab5

--- Comment #9 from amyspark  ---
Git commit 3a9828651dd5942885b80aa508b59e4ea3bb3ab5 by L. E. Segovia.
Committed on 04/11/2020 at 20:42.
Pushed by lsegovia into branch 'krita/4.3'.

Add OS-specific action property retrieval to KisActionRegistry

This enables the retrieval of operating system-specific action
properties.

OS-specific action properties are labeled with the attributes
"operatingSystem" (for the selected OS; currently only "macos" is
defined) and "operatingSystemElse" (for the rest).

This commit adds a function, getChildContentForOS, that:
- When finding a matching "operatingSystem", returns the given node's
text
- When finding a node with "operatingSystemElse", stores the last seen
one
- When finding a node without any of these parameters, stores the first
seen one and ignores the rest

This commit implements said change on the Del and Backspace key
shortcuts for macOS. See krita.action.
CCMAIL: kimages...@kde.org
(cherry picked from commit 99f7f30391c23f20c2d531619971049756416ef4)

M  +4-2krita/kritamenu.action
M  +33   -1libs/widgetutils/kis_action_registry.cpp

https://invent.kde.org/graphics/krita/commit/3a9828651dd5942885b80aa508b59e4ea3bb3ab5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-11-04 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=425370

amyspark  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/99f7f3039
   ||1c23f20c2d53161997104975641
   ||6ef4
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #8 from amyspark  ---
Git commit 99f7f30391c23f20c2d531619971049756416ef4 by L. E. Segovia.
Committed on 04/11/2020 at 12:56.
Pushed by lsegovia into branch 'master'.

Add OS-specific action property retrieval to KisActionRegistry

This enables the retrieval of operating system-specific action
properties.

OS-specific action properties are labeled with the attributes
"operatingSystem" (for the selected OS; currently only "macos" is
defined) and "operatingSystemElse" (for the rest).

This commit adds a function, getChildContentForOS, that:
- When finding a matching "operatingSystem", returns the given node's
text
- When finding a node with "operatingSystemElse", stores the last seen
one
- When finding a node without any of these parameters, stores the first
seen one and ignores the rest

This commit implements said change on the Del and Backspace key
shortcuts for macOS. See krita.action.
CCMAIL: kimages...@kde.org

M  +4-2krita/kritamenu.action
M  +33   -1libs/widgetutils/kis_action_registry.cpp

https://invent.kde.org/graphics/krita/commit/99f7f30391c23f20c2d531619971049756416ef4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-11-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=425370

--- Comment #7 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/krita/-/merge_requests/567

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-11-03 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=425370

--- Comment #6 from Boudewijn Rempt  ---
I think that it might be easiest to do this when loading the shortcuts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-11-03 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=425370

--- Comment #5 from amyspark  ---
boud, should we exchange both in macOS? backspace -> clear, del -> fill with
background?
I'm trying to find a place where we can override their defaults.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-10-20 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=425370

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-08-15 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=425370

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Severity|wishlist|normal
 CC||b...@valdyas.org
 Status|REPORTED|CONFIRMED

--- Comment #4 from Boudewijn Rempt  ---
Given that the delete button clears the selection on all other macOS paint apps
I've tested, I think we should change the default on macOS.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-08-15 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=425370

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Hi, Wynter!

The default action for backspace shortcut is "Fill with Background Color".
Therefore, when you press Backspace key, it should do that instead of
"clearing". And, yes, you can change this behavior in the settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-08-15 Thread WynterTheCat
https://bugs.kde.org/show_bug.cgi?id=425370

--- Comment #2 from WynterTheCat  ---
And I was even changing other shortcuts earlier, and I didn't think of that...
One of those days. Though, I do think it should be that by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 425370] Ability to press Delete key alone instead of needing to perform PC-type delete to delete selection contents

2020-08-15 Thread Wojciech Trybus
https://bugs.kde.org/show_bug.cgi?id=425370

Wojciech Trybus  changed:

   What|Removed |Added

 CC||wojt...@gmail.com

--- Comment #1 from Wojciech Trybus  ---
There is an easy enough way to get it: go to settings > Configure krita... >
Keyboard shortcuts and type "clear" . You can then assign this action to the
key you want.

If this should be made a default choice for mac, would probably have to be
consulted with other mac users on krita artists forum.

-- 
You are receiving this mail because:
You are watching all bug changes.